Files
hermes-agent/agent/AGENTS.md
Siddharth Balyan fc6a0a1a39 P18a: the backend plays the desktop setup opening (hello, name, accent) as real setup_choose calls (#129346)
* feat(setup): the backend plays the desktop opening (hello, name, accent) as real setup_choose calls

A desktop /initiate-setup turn whose history has no setup_choose call now runs a
scripted prelude before its first model call: the intro text with the name card,
then a line with the name and the accent card. Each step goes through the unchanged
run_tool_round (row persisted before the tool runs, interim text and tool events
emitted, tool hooks fired); the same turn then continues with the model, whose first
words start at the apps card. No system prompt change, no user row added, no API call
counted. CLI, TUI and the messaging gateway keep the model-only opening.

Also: the first-contact note never fires in the marked setup profile, and a stored
[/initiate-setup] row projects as /initiate-setup instead of the whole skill body.

* fix(setup): a relaunch mid-opening replays only the unanswered cards, with one recovery owner

The desktop intro sends /initiate-setup again when a relaunch cut the opening off. The prelude
used to skip as soon as the history held any setup_choose call, so the model had to ask the rest
(after the name answer it skipped the accent card). Now the prelude plays only the opening cards
with no answer, and does not repeat a line already in the chat. It matches lines by text because
a resumed history keeps an unanswered card's row but drops its call.

The same relaunch also scheduled the desktop auto-continue of the cut-off turn. That continuation
raced the app's resend: the resend became a redirect, its row lost display_kind hidden (a visible
/initiate-setup bubble after reload) and a "resumed interrupted turn" row appeared. While the
setup intro is unseen the app owns recovery of that turn, so auto-continue clears its marker.

Docs: the setup offer line never fires in the setup profile; the desktop app asks the opening
questions itself.
2026-09-30 20:01:49 +05:30

10 KiB
Raw Blame History

agent/ — AIAgent, turn loop, prompt, compression

Applies on top of the root AGENTS.md (prompt-caching invariant, facade + siblings rules).

Shape

run_agent.py is the public facade: AIAgent is assembled from mixins (agent/turn_facade.py, client_lifecycle.py, stream_delivery.py, session_persistence.py, compression_facade.py, ...). Construction runs agent/agent_init.py::init_agent; a turn is agent/conversation_loop.py::run_conversation, which AIAgent.run_conversation forwards to after taking the session turn lease (turn_facade_lease.py). AIAgent.__init__ takes ~60 parameters (credentials, routing, callbacks, session context, budget, credential pool, ...) — read run_agent.py for the list; the subset you usually touch: base_url, api_key, provider, api_mode ("chat_completions" | "codex_responses" | ...), model (empty → resolved from config/provider later), max_iterations (default 500, shared with subagents), enabled_toolsets/disabled_toolsets, quiet_mode, save_trajectories, platform ("cli", "telegram", ...), session_id, skip_context_files, skip_memory, credential_pool. chat(message) -> str is the simple interface; run_conversation(user_message, system_message=None, conversation_history=None, task_id=None) -> dict returns final_response + messages.

Agent loop (agent/conversation_loop.py + agent/turn_*.py)

Entirely synchronous, with interrupt checks, budget tracking, and a one-turn grace call:

while (api_call_count < self.max_iterations and self.iteration_budget.remaining > 0) \
        or self._budget_grace_call:
    if self._interrupt_requested: break
    response = client.chat.completions.create(model=model, messages=messages, tools=tool_schemas)
    if response.tool_calls:
        for tc in response.tool_calls:
            messages.append(tool_result_message(handle_function_call(tc.name, tc.args, task_id)))
        api_call_count += 1
    else:
        return response.content

Each phase of an iteration is its own sibling, so a change to (say) overflow handling touches one ~600-line file: turn_preflight*, turn_iteration_prep, turn_request_assembly/turn_api_request, turn_api_call, turn_api_error, turn_response_intake/turn_response_check, turn_empty_response, turn_tool_round/turn_tool_validation, turn_overflow, turn_truncation, turn_scripted_prelude (tool calls a prompt built-in plays before the first model call), turn_context_compaction, turn_recovery, turn_recovery_autorecover (post-exhaustion wait-and-retry ladder), turn_retry_state, turn_stop_gates, turn_liveness, turn_usage, turn_final_response, turn_finalizer, turn_summary. Find the phase with grep -rn "def X" agent/turn_*.py.

Messages use OpenAI format {"role": "system|user|assistant|tool", ...}; reasoning content is stored in assistant_msg["reasoning"].

Agent-level tools (todo, memory, ...) are intercepted by agent/tool_executor.py through the INLINE_TOOL_EXECUTORS table in agent/inline_tool_executors.py before handle_function_call(). Adding one: register in that table (no if name == ... chain); tools/todo_tool.py is the pattern.

Message-flow invariants (every change is reviewed against these)

  • Prompt caching must not break. Never alter past context, change toolsets, reload memories, or rebuild the system prompt mid-conversation. The system prompt is byte-stable for the life of a conversation; the ONLY context mutation is compression. Anything that must inject content mid-conversation rides a user message or tool result, never the system prompt: skill slash commands (agent/skill_commands.py) inject as a user message; subdirectory AGENTS.md hints (agent/subdirectory_hints.py) append to the tool result (head+tail truncated past _MAX_HINT_CHARS = 32_000; the truncation is logged, never queued as a chat status warning — context_file_max_chars does not raise that cap).
  • Strict role alternation. Never two same-role messages in a row; never a synthetic user message injected mid-loop. The one exception is /steer, delivered as a standalone user row after a tool result (assistant(tool_calls) → tool → user is legal on every provider path) — never smeared onto the already-persisted tool row, which append-only persistence would leave divergent from the live request. Cron deliveries live in their own session for this reason.
  • Context files (agent/prompt_builder.py) load from the CWD only at startup and are capped (CONTEXT_FILE_MAX_CHARS / dynamic cap from the context window / context_file_max_chars). Never load an install-tree AGENTS.md as project context (PR #64611); subdirectory hints reject paths outside the working dir so ~/.codex/AGENTS.md / ~/.claude/CLAUDE.md never mix in.
  • _last_resolved_tool_names is a process-global in model_tools.py. _run_single_child() in tools/delegate_tool.py saves/restores it around subagent execution; code reading it may see a temporarily stale value during child runs.

Compression (agent/compression_facade.py, conversation_compression.py, turn_context_compaction.py)

Manual /compress on every surface (CLI, gateway, TUI, ACP) runs through agent/conversation_compression_manual.py::compress_now (one parser for here [N] / focus / --preview / --aggressive; surfaces only parse their own argv, install after_messages and render).

Two layers: gateway session hygiene (85% threshold) and the agent ContextCompressor (50%, configurable; per-model overrides; failure cooldown after provider-proven overflow). The algorithm prunes old tool results first (no LLM call), then picks boundaries, then generates a structured summary with the auxiliary compression model. In-place compaction keeps a single stable session id; native Responses/Codex compaction paths are provider-specific. A stalled summary stream retries once on auxiliary.compression.fallback_chain, and a repeated stall (a stall-class failure already on the cooldown ladder) ends with the deterministic fallback summary through the same pipeline — never a prune committed outside the lease/fence. Compression is the sanctioned cache break — keep it the only one. Full detail: website/docs/developer-guide/context-compression-and-caching.md.

Model and provider resolution

  • Runtime provider/model resolution and its precedence: website/docs/developer-guide/provider-runtime.md. Provider profiles are plugins (plugins/model-providers/<name>/, see plugins/AGENTS.md); agent/model_metadata.py holds context lengths and capabilities.
  • Auxiliary (side-LLM) work — curator, vision, embedding, title generation, session_search, compression — resolves through agent/auxiliary_client.py::_resolve_auto_route; each task can pin its own provider/model/base_url/reasoning_effort under auxiliary: in config.yaml. Every physical attempt funnels through _relay_sync_completion / _relay_async_completion / _relay_sync_stream, where agent/auxiliary_hooks.py emits pre_auxiliary_call / post_auxiliary_call (observer-only, fail-open, aux_task set); the main-loop pre/post_api_request events must NOT fire for aux calls (#79733).
  • Fallback models and credential pools are resolution-chain code: E2E them with real imports against a temp HERMES_HOME, not mocks (root rubric).

i18n (agent/i18n.py + i18n_layers.py + i18n_languages.py)

t(key) resolves plugin packs (last registered wins) → user overlay <home>/locales/<lang>.yaml (profile-scoped) → bundled locales/<lang>.yaml → the same for en → bare key; every layer is flat dotted keys and may be partial. One merged dict per (home, lang) is cached; reset_language_cache() (called by every pack registration and by config set display.language) drops everything. supported_languages() is the live set (bundled ∪ overlay ∪ packs) and is what display.language validation and _normalize_lang accept; SUPPORTED_LANGUAGES stays the bundled tuple. .tui.yaml / .desktop.yaml pack files are opaque here beyond parse/flatten/serve (surface_catalog, RPC i18n.catalog); for the tui surface the bundled locales/<lang>.tui.yaml is the bottom layer of what surface_catalog serves (the TUI ships English only in TS). Endonyms for bundled ids live in i18n_languages.py and must agree with apps/shared/src/i18n.ts.

Memory, context engines, curator

agent/memory_provider.py (ABC) + agent/memory_manager.py (orchestrator) drive memory-provider plugins; agent/context_engine.py drives context-engine plugins; agent/image_gen_provider.py image-gen plugins (all in plugins/AGENTS.md). agent/curator.py + curator_backup.py implement the skill curator (skills/AGENTS.md). Cron sessions pass skip_memory=True by default — memory providers intentionally do not run during cron.

  • End-of-session memory extraction and provider on_session_end run wherever the session ends — turn, eviction, shutdown, tui_gateway teardown — and the CALLER binds the owning profile's scope first (_run_release_in_profile_scope, _session_profile_runtime_scope); the agent never derives its home from os.environ at flush time (Path(_session_db.db_path).parent is the ground truth). Provider background work starts through memory_provider.py::spawn_context_thread (copies the contextvars), never a bare threading.Thread; title_generator.py is the shape.
  • agent/secret_scope.py::get_secret fails closed (UnscopedSecretError) only after set_multiplex_active(True); the gateway, cron, migrate and serve set it. A new multi-home host must too, or every guard is silently off. Isolation is BETWEEN profiles; children inherit via copy_context; a child's UnscopedSecretError is a spawn-site bug, never grounds for an os.getenv fallthrough. Delegated children carry delegation_context.py:: DELEGATED_CHILD_ENV_MARKER valued as the fenced Kanban board root, not a bare flag.

Tests

Loop/phase tests go in tests/agent/; patch the binding the phase actually reads (siblings often from run_agent import X inside the function — root "patch where production reads"). Assert message-shape invariants (alternation, byte-stable system prompt) rather than snapshotting prompt text.

Long-form: website/docs/developer-guide/agent-loop.md, prompt-assembly.md, context-compression-and-caching.md, provider-runtime.md, session-storage.md, subagent-lifecycle-api.md.