Files
Siddharth Balyan 4094ab610d hermes_platform.resolver: locate/inspect/probe tiers, AppResolver, gh lookup migrated (NS-921) (#118065)
* feat(platform): resolver core with locate/inspect/probe tiers and ordered candidates

Every resource lookup needs one result shape and one cost contract. `locate` reads
metadata only, `inspect` may open files and call OS APIs in-process, `probe` is fresh
and the only tier that may spawn or connect. `Resolution.candidates` keeps probe order
so fan-out consumers can try every present binary.
Linear NS-921.

* feat(platform): AppResolver over AppDef with plist, PE, registry, and server.json sources

Desktop apps need presence, version, and liveness as separate observations. The runtime
file's bearer token is parsed, used for one request, and discarded inside the probe;
no public type carries it. Endpoints are accepted only when loopback with a numeric port.

* refactor(copilot): gh candidates through locate_command and the Homebrew table

First consumer of the resolver. The gh token probe still tries every present binary in
order; the allowlist loses its two copilot_auth rows.

* feat(platform): availability() over an application declaration

locate() + inspect() only, never probes; the fail-closed _version in
app.py treats a vendor's plist/PE/registry entry as untrusted input.
Salvaged from PR #118122; reads any object with requires_app,
min_version, app_for(os) — nothing here imports the MCP catalog.

* feat(platform): application declarations parsed into AppDef per OS

The parser slice of PR #118122's catalog manifest, re-homed as a
catalog-free module: whoever owns an MCP server declares the app it
fronts per OS and what it needs, and registers it here. Stdlib +
hermes_platform.resolver only. register/lookup/clear are the one seam
the MCP check_fn and the skill gate both read.

* feat(mcp): check_fn honours a registered application declaration

_make_check_fn ANDs the declared app's availability into the
connection-alive check; with nothing registered for the server the
behaviour is the pre-PR3 connection check. Provenance is explicit
registration, not endpoint matching. Returns a plain bool: the registry
caches bool(fn()).

* feat(skills): requires_apps gate through registered declarations

Offer-time filter beside environments:; names resolve through
hermes_platform.declaration, an unknown name hides the skill (fail
closed). The disk snapshot carries requires_apps and the fast path
re-evaluates it (snapshot version bumped to 3): app presence is a host
fact that changes without SKILL.md changing.

* docs: application declarations page

The plugin-facing schema reference: app: and requires: blocks,
availability() states, and the two gates that read the registry.
Registered under Extending > Plugins in the docs sidebar.

* test(platform): declaration parser, availability, gates

The PR3 app-block tests re-homed off the catalog: fixtures are dicts
passed to parse_declaration, the check_fn gate keys on explicit
registration (not endpoint matching), and the import-hygiene probe now
covers hermes_platform.declaration and resolver.availability.
2026-09-22 17:08:30 +05:30

149 lines
4.4 KiB
Python

"""Result and context types shared by every resolver, plus passive command location.
`locate_command` reads only file metadata. It never opens a file, spawns, or connects.
"""
from __future__ import annotations
import os
import shutil
from dataclasses import dataclass, field
from enum import Enum
from typing import Generic, Literal, TypeVar
Kind = Literal["explicit_path", "path_executable", "known_path", "package_runner", "missing"]
T = TypeVar("T")
class _Absent:
__slots__ = ()
def __repr__(self) -> str:
return "ABSENT"
ABSENT = _Absent()
class CheckState(Enum):
NOT_CHECKED = "not_checked"
PRESENT = "present"
ABSENT = "absent"
UNAVAILABLE = "unavailable"
ERROR = "error"
@dataclass(frozen=True)
class Observation(Generic[T]):
"""One checked fact. Consumers branch on `state`; `detail` is never parsed."""
state: CheckState
value: T | None = None
detail: str = ""
@classmethod
def not_checked(cls) -> "Observation[T]":
return cls(CheckState.NOT_CHECKED)
@dataclass(frozen=True)
class Candidate:
value: str
source: str
present: bool
@dataclass(frozen=True)
class LookupContext:
"""`path`: ABSENT = caller did not say (ambient), None = ambient, "" = search nothing."""
path: str | None | _Absent = ABSENT
pathext: str | None = None
def effective_path(self) -> str | None:
if isinstance(self.path, str):
return self.path
return None
@dataclass(frozen=True)
class Resolution:
kind: Kind
candidates: tuple[Candidate, ...] = field(default_factory=tuple)
@property
def command(self) -> tuple[str, ...]:
first = next((c for c in self.candidates if c.present), None)
return (first.value,) if first else ()
@property
def source(self) -> str:
first = next((c for c in self.candidates if c.present), None)
return first.source if first else "none"
@property
def present(self) -> tuple[Candidate, ...]:
return tuple(c for c in self.candidates if c.present)
@property
def found(self) -> bool:
return self.kind != "missing"
def _which(name: str, ctx: LookupContext) -> str | None:
if ctx.path == "":
return None
if ctx.pathext is not None and os.name == "nt":
# shutil.which reads PATHEXT from os.environ; an explicit pathext is honored without mutating it.
exts = [e for e in ctx.pathext.split(os.pathsep) if e]
for ext in ["", *exts]:
hit = shutil.which(name + ext, path=ctx.effective_path())
if hit:
return hit
return None
return shutil.which(name, path=ctx.effective_path())
def _is_executable_file(path: str) -> bool:
return os.path.isfile(path) and os.access(path, os.X_OK)
def _expand(path: str) -> str:
return os.path.expandvars(os.path.expanduser(path))
def locate_command(name: str, ctx: LookupContext | None = None, *, known_dirs: tuple[str, ...] = ()) -> Resolution:
"""Find `name` on PATH, then in `known_dirs`, recording every candidate in probe order."""
ctx = ctx or LookupContext()
name = name.strip()
if os.sep in name or (os.altsep and os.altsep in name):
expanded = _expand(name)
# A relative explicit path would resolve against the ambient cwd; only absolute paths are trusted.
present = os.path.isabs(expanded) and _is_executable_file(expanded)
cand = Candidate(expanded, "explicit", present)
return Resolution("explicit_path" if present else "missing", (cand,))
candidates: list[Candidate] = []
hit = _which(name, ctx)
candidates.append(Candidate(hit or name, "PATH", hit is not None))
for d in known_dirs:
base = os.path.join(_expand(d), name)
found = next((v for v in _known_dir_variants(base) if _is_executable_file(v)), None)
candidates.append(Candidate(found or base, f"known_dir:{d}", found is not None))
kind: Kind = "missing"
for c in candidates:
if c.present:
kind = "path_executable" if c.source == "PATH" else "known_path"
break
return Resolution(kind, tuple(candidates))
def _known_dir_variants(base: str) -> tuple[str, ...]:
"""On Windows a bare name in a known dir may carry any PATHEXT suffix; one candidate is recorded per dir."""
if os.name != "nt":
return (base,)
exts = [e for e in os.environ.get("PATHEXT", ".EXE;.CMD;.BAT").split(os.pathsep) if e]
return (base, *[base + e for e in exts])