Commit Graph

41378 Commits

Author SHA1 Message Date
ethernet
207f8fedfd Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	hermes_cli/local_runtime/binaries.py
#	hermes_cli/plugins_cmd.py
#	hermes_constants.py
#	tests/test_hermes_constants.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_voice_wsl_pipewire.py
#	tools/computer_use/cua_backend.py
#	tools/voice_mode.py
2026-09-22 09:55:47 -04:00
ethernet
feb643ec89 Merge branch 'fix/r6-linux-e2e' into ethie/pm-clean 2026-09-22 09:38:37 -04:00
ethernet
4d43a4632f Merge branch 'fix/r6-win-old' into ethie/pm-clean 2026-09-22 09:38:29 -04:00
ethernet
7c9ab175d8 Merge branch 'fix/r6-win-ci' into ethie/pm-clean 2026-09-22 09:38:29 -04:00
ethernet
ca4ae35190 Merge branch 'fix/r6-compat' into ethie/pm-clean 2026-09-22 09:38:29 -04:00
ethernet
aed7ffd821 test(installer): isolate Linux update Electron route 2026-09-22 09:37:10 -04:00
ethernet
29f74ab71c fix(e2e): bridge historical Windows desktop launches
The v2026.6.19 Desktop starts its source backend through the host Python.
Windows cannot expose that process environment or working directory. Carry
the app's verified source root into the existing strict provenance check.

A PM update can leave a locked historical executable beside the current
command-file launcher. Settle the updated runtime through the command file and
use verbatim cmd.exe arguments so paths with spaces remain valid.

Verified with the focused Desktop smoke tests, the tests-js typecheck, syntax
checks, and a native Windows ARM command-file launch probe.
2026-09-22 09:36:53 -04:00
ethernet
98489771f8 Merge branch 'fix/r6-memory-plugin' into ethie/pm-clean 2026-09-22 09:29:35 -04:00
ethernet
69c9e18b01 Merge branch 'fix/r6-yaml-tests' into ethie/pm-clean 2026-09-22 09:29:35 -04:00
ethernet
439dd69a45 fix(memory): honor disabled providers without PyYAML
Parse memory-provider manifests through the declared hermes_yaml layer so manifest-name deny-list entries cannot fail open when PyYAML is absent. Exercise enabled and disabled profiles A→B→A to lock down config and module cache isolation.
2026-09-22 09:28:53 -04:00
ethernet
ce16d3691b fix(compat): make skills hub hook installation idempotent
A merge reordered the skills-hub compatibility wrapper ahead of its saved
resolver, so the later capture pointed the wrapper at itself. Install the
wrapper once after its lazy table is defined and retain the native resolver
through module reloads and repeated installation.
2026-09-22 09:28:52 -04:00
ethernet
56954c23f5 test(ci): reuse native PowerShell for store eligibility
Run all release identity cases in one native PowerShell session instead of
charging a cold start and a scheduler-sensitive deadline to every parameter.
Keep the workflow scripts and native exit handling real, with the canonical
per-file runner as the deadlock guard.
2026-09-22 09:27:38 -04:00
ethernet
0186236872 test: use canonical YAML helpers in plugin fixtures 2026-09-22 09:26:20 -04:00
kshitijk4poor
e2f8a0731b test(desktop): one discriminating guard test per empty-page site
The "records no signature" test could not fail: the second page differed
from the first, so it landed whether or not the ignored read left a
signature. Re-feed the SAME empty page once the runtime is genuinely empty
instead — that publish is deduped away only if the signature was wrongly
recorded (mutation-checked). Fold the plain "keeps the transcript" case into
it, keep the foreign-runtime carve-out, drop the two green-on-main boundary
tests, and add one guard each for the tile refresh and the post-turn hydrate.
2026-09-22 18:35:52 +05:30
kshitijk4poor
fbb0181224 fix(desktop): a kept truncated tail entry still counts as a use
Returning early on the empty page skipped setTranscriptTailEntry, and with
it the MRU bump an identical re-record gets — a run of empty pages let the
constantly re-read active session drift toward the eviction end of the
256-entry tail map. Re-record the kept entry instead: the identical-entry
path writes nothing and bumps the key.
2026-09-22 18:35:52 +05:30
kshitijk4poor
1993202ffb refactor(desktop): read the post-await session state once per refresh
Both refresh paths read $sessionStates twice after the await (once for the
stale-read check, once for the empty-page guard); hoist it into one local
that both consume. Keep the WHY of the guard on the predicate and leave the
call site with the one fact unique to it (bail before the signature write).
Type the page as readonly.
2026-09-22 18:35:52 +05:30
kshitijk4poor
2d46d124c7 fix(desktop): tile refresh and post-turn hydrate ignore an empty page too
The same zero-row page that blanked the active pane also blanked a
populated session tile (reconcileTileTranscripts published [] over it) and
was accepted by the post-turn fallback as the turn's answer. Apply the one
predicate at both sibling sites: the tile keeps its rows and no signature is
recorded; the hydrate falls through to its next attempt instead of
publishing.
2026-09-22 18:35:52 +05:30
Calvin Ng
c785dd8001 fix(desktop): keep a populated active transcript through an empty refresh page
A `sessions.changed` refresh can read zero rows while the backend respawns or
its state.db read races the event. reconcileActiveTranscript accepted that page
as the whole transcript, which blanked the view, tripped the routed
loading branch and re-ran the composer lifecycle (flash + caret reset).

- use-background-sync: ignore an empty page when the runtime for the SAME
  stored session already holds messages; leave the accepted-signature map
  untouched so the next usable page still lands. Same rule as the
  warm-activation guard (f0748b451c).
- transcript-tail: an empty page no longer downgrades a possiblyTruncated
  entry, so "Show earlier" stays armed through the transient read.

Companion to #118855 (unanchored stale tail) and #117898 (warm-gate hold);
this covers the third seam neither touches. Refs #118850, #117867, #98005.

(cherry picked from commit 070343591027017e95fdece1aa42e85d723da4b7)
2026-09-22 18:35:52 +05:30
kshitijk4poor
76b2f3eefb chore: map calvinnwq@gmail.com to @calvinnwq (PR #119100 salvage) 2026-09-22 18:35:52 +05:30
Gille
2c65d5aee6 fix(desktop): clarify plugins folder label (#118848) 2026-09-22 08:34:36 -04:00
hermes-seaeye[bot]
171073f528 fmt(js): npm run fix on merge (#119114)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-09-22 12:31:58 +00:00
Siddharth Balyan
571ceec006 Desktop plugin card shows each declared server's state and the sentence that explains it (NS-941) (#119051)
* feat: expose plugin server states

* feat: reduce plugin server snapshots

* feat: render plugin server health
2026-09-22 17:54:42 +05:30
Siddharth Balyan
eb5d735e9a Application-backed MCP servers: live endpoint per attempt, tools follow app liveness, errors and the tool catalog say why (NS-943) (#119050)
* feat: expose interactive and live endpoint facts

* feat: hydrate application-backed MCP liveness

* feat: export interactive session fact

* fix: classify unsupported declared hosts

* test(mcp): a runtime file without a token connects without an Authorization header

* fix(mcp): server_json liveness fields default to http/token/pid; an invalid declaration degrades to static instead of failing the server task

* fix(mcp): a connected server is offerable regardless of the interactive-session rule; the rule only shapes the not-connected sentence

* test(mcp): follow main's ToolSearchConfig fields and patch _bump_server_error at its origin module
2026-09-22 17:54:42 +05:30
Siddharth Balyan
adefd99671 Portable plugins declare the application each MCP server needs; install refuses on an unsupported host (NS-942) (#119049)
* feat: enforce portable server declarations

* test: cover portable plugin host gates
2026-09-22 17:54:41 +05:30
hermes-seaeye[bot]
f14f86dd5c fmt(js): npm run fix on merge (#119091)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-09-22 12:04:08 +00:00
Siddharth Balyan
f21e583211 chore(desktop): remove the old MCP tab (#119083)
The Connectors page replaced the MCP tab in #119074, but `McpTab` stayed
in the tree because the desktop SDK exported it and the bundled Bots
plugin rendered it in a bot's profile editor. The SDK now exports
`ConnectorsTab` in its place (same `gateway` and `profile` props) and the
Bots editor embeds that; older shells that lack the export still get the
plugin's own checkbox list, as before.

Deleted with the tab: its avatar component and the 45 `settings.mcp` and
`skills.tabMcp` strings nothing reads any more, in every locale.
2026-09-22 17:28:06 +05:30
hermes-seaeye[bot]
725cba2f80 fmt(js): npm run fix on merge (#119079)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-09-22 11:51:53 +00:00
Siddharth Balyan
dc50403a81 feat(desktop): the Connectors page replaces the MCP tab (#119074)
* feat(connectors): the backend serves a connector's tool list, cached for 24 hours

The Connectors page opens one app and shows every tool it has. The backend
had no way to read that list.

- `tools/connectors/portal/`: a client for the portal's tool-list route and a
  JSON cache under the Hermes home, one file per portal origin and connector.
  An entry is fresh for 24 hours. After that the read revalidates with the
  stored ETag: 304 keeps the list, 404 deletes the entry, an upstream failure
  serves the stored list marked stale, and a 401 never serves the cache.
- `connectors.tools {slug, refresh}`: account-level, routed by `profile`, no
  chat session. Errors carry a fixed `reason` from one closed set on the rail.
- Every connector model that is not operation state moves into
  `tui_gateway/contracts/connectors.py`. Handlers that no chat session owns
  live in `tui_gateway/methods_connectors_account.py`.

The wire model is tolerant: an unknown facet reads as unclassified and one odd
tool never blanks a connector.

* feat(connectors): catalog, accounts and member tool rules by RPC

The Connectors page needs the app catalog, the connected account of one app,
a way to disconnect it, and the member's own on/off rules. None had an RPC.

- `connectors.catalog`: name, description, category and logo of each app.
- `connectors.accounts`, `connectors.accounts.remove`: read the accounts at
  the tool gateway and remove one by id.
- `connectors.policy.get`: the rule layers that apply to the member, widest
  first. The body is a union on `mode`, so a reader can name who turned a
  tool off.
- `connectors.policy.set`: one change, a union on `type` (the tools of one
  connector, or one connector on or off), with the revision the user saw. A
  stale revision answers `POLICY_CONFLICT`. The backend composes the upstream
  write in one pure function, so no renderer learns the upstream rules.
- Bundled MCP manifests can name their hosted twin with `connector:`, so the
  page can show one card per app.

* feat(connectors): connect an app without a chat session

Every connector RPC took a `session_id`, and a connect that did not come from
the model's tool call minted a link with no watcher. The Connectors page has
no chat session, and its card must flip to connected by itself.

- `connectors.list`, `connectors.connect`, `connectors.operation.status`,
  `connectors.operation.wake` and `connection.respond` take `owner`, a union
  on `type`: `session` (today's behaviour and authorization) or `account`
  (routed by `profile`, authorized by the live transport like `mcp.*`).
  `session_id` is gone from these params; every desktop caller sends `owner`.
- An account connect runs the same operation lifecycle on a background
  thread, under the profile's scope, so the watcher reads the account and
  settles the operation. A second connect for an app that is already
  connecting returns the open operation and mints nothing.
- `connection.update` carries `owner`. An account operation has no session to
  address, so its updates go out on the session-less broadcast path.

* feat(mcp-catalog): eighteen more bundled entries name their hosted connector

A bundled MCP entry and a hosted connector for the same app are one card
on the Connectors page only when the manifest names its hosted twin.
Linear and Notion had the field. These entries get it too: airtable,
asana, attio, calendly, dropbox, figma, railway, supabase, todoist,
betterstack, canva, cloudflare, datadog, intercom, neon, sentry, stripe
and vercel. Atlassian maps to two hosted connectors and Prisma Postgres
is not clearly the same app, so both stay without one.

* refactor(connectors): the account handlers share one gate, one params model and one write table

The six account-level handlers each repeated the availability gate, the
auth catch and the catch-all reply. One decorator now owns that, and each
handler validates its params with its contract model instead of a ladder
of isinstance checks. The five connection RPCs share one guard for the
unexpected-failure reply.

The four write composers for the member rules were the same function
with a different list key and polarity. They are one table now.

The owner union lives in contracts/common.py, so the params side and the
event side stop declaring it twice and the import cycle is gone.

An account operation start carries one event and a flag, so the wait for
the sign-in link blocks instead of polling every 50 ms. run_operation
loses its two account-only parameters; drive_operation is the second
entry point.

Tests: four deleted (they exercised pydantic or the mock), three merged
into tables, two added (a client that still sends the old top-level
session_id is refused; all six account RPCs run off the server loop).
The shared reply helper and the HTTP and managed-client fakes move to
one place each. Comments are one line or gone.

* fix(connectors): a missing tool-list route reads as "unavailable", not "connector gone"

The tool-list read treated every 404 as the portal's "this connector is
not in the catalog" answer. It deleted the cache entry and answered
CONNECTOR_NOT_FOUND, so a page would offer to remove an app that is
connected and works. A portal that does not serve the route yet answers
a bare 404 for every app.

Only the portal's own {"error": "connector_not_found"} means the
connector is gone. Any other 404 is now a tool-list outage: the cached
list is served as stale, or the RPC answers TOOLS_UNAVAILABLE.

* fix(connectors): a connect from the page returns to the app after sign-in

The sign-in link carries a return target only when the session's surface
is the desktop. A chat session binds that surface. An account-owned call
has no chat session, so nothing bound it: the link was minted without a
return target and the browser ended on the portal's done page instead of
coming back to Hermes.

Every account-owned call now runs with the process's own surface bound,
next to its profile scope. The operation thread copies that context, so
the first link and every reissued link carry the return target and the
operation id.

* test(connectors): defer the new connector RPC coverage

The tests for the new account RPCs, the portal client, the tool-list cache
and the rule composer leave this PR and come back in one later change, after
the API is settled. The same was done for #111008.

Kept: the edits that existing tests need because the five connection RPCs
now take `owner` instead of `session_id`, and the rename of the managed
client seam.

Removed: six new test files, their two fakes and the gateway conftest, and
the new cases in test_mcp_catalog.py, test_connectors_gateway_client.py,
gateway-rpc.test.ts and notifications.test.ts. Reverting this commit restores
all of them.

* fix(cli): the connection panel hands the tool thread back at once

The classic CLI's connection callback waited on a queue for the user's first
decision. The operation's watcher starts only after the callback returns, and
the watcher is what polls a hosted account, runs the 300-second deadline and
sees Ctrl+C.

For a hosted connector the panel opens on the sign-in link, where the only
key that filled the queue was Cancel. The account was never polled: the user
signed in, the panel never changed, and Esc reported the app as skipped.
Ctrl+C set the interrupt flag but left the thread parked on the queue, so the
turn never ended.

The callback now opens the panel and returns, as the gateway's callback does
for the desktop and the Ink TUI. The panel's actions already reach the
operation through apply_answer on the UI thread, so the queue is removed. An
install with a form still waits for Connect, because the backend starts no
work for a pending row. Ctrl+C now settles the operation as `interrupt`, and
open rows become `not_connected`.

Checked on the e2e rig with the fake tool gateway: hosted connect completes on
the third status read; Ctrl+C ends the turn and the polling stops; an MCP
install with a plain and a secret field still saves config and both values.

* fix(connectors): "run it again" lives in the library, so the classic CLI can use it

Making a new sign-in link for a failed or expired hosted connector was
implemented only in the JSON-RPC layer (`_reissue`). The classic CLI does not
go through JSON-RPC: its Connect button on a failed row called apply_answer,
which does nothing for a hosted operation because it has no MCP runner. The
panel showed "Waiting…" until the deadline.

`tools.connectors.run.reissue(operation, names)` now holds the checks and the
per-kind action, and returns a refusal reason or None. The gateway maps each
reason to the same JSON-RPC error as before. The CLI calls it for a hosted
row; a refusal is shown on the row. MCP rows keep their path, because Connect
on a failed MCP row re-sends the form values.

Checked on the e2e rig: a scripted failed sign-in, then Connect: a second mint
with `reinitiate: true`, a new link with a new connection id, then connected.

* feat(connectors): the account list and disconnect go through the portal

`connectors.accounts` and `connectors.accounts.remove` called the tool
gateway. They now call the portal's account-management routes
(`GET /api/v1/connectors/accounts`, `DELETE /api/v1/connectors/accounts/{id}`),
which apply the organisation membership checks and write the disconnect audit
row. There is no fallback to the gateway when the portal is unavailable, and a
removal is never retried.

The read of ONE account stays on the gateway (`GET v1/connectors/accounts/{id}`):
the portal has no such route, and the operation watcher polls it once per second.

`ConnectorClient.list_accounts` and `delete_account` are removed. The removed
account's reply model carries `connector`, which both services send.

* fix(connectors): the account RPCs answer what the portal really sends

Checked against the portal source and against the staging and production
services.

- Errors are read from the upstream error code, not the HTTP status. A rule
  write answered 409 for a stale revision and for a user with no organisation;
  both read as "the policy changed". `org_required` is now `ORG_REQUIRED` and
  403 `no_access` is `ORG_ACCESS_DENIED` on every account RPC; only a rejected
  sign-in is `NEEDS_NOUS_AUTH`. `connectors.list` and `connectors.connect` with
  the account owner map these too.
- `connectors.policy.get` and `connectors.policy.set` carry `effective`: the
  portal's own result for this user, with its stamp and without provider or
  subject ids. Nothing is recomputed locally.
- A rule write needs the revision the user saw: `expected_revision` is required
  and must be a revision string; a bad one is refused before any HTTP call.
- A tool row carries `no_auth`; a list without the upstream flag is an invalid
  answer, not `false`.
- `connectors.accounts.remove` returns the app of the removed account. An
  invalid id is `INVALID_PARAMS`.
- The tool-list cache is per signed-in member (a hash of the token's `sub`),
  so two Nous accounts on one profile do not share entries.
- A malformed slug is a local error, not a 404 from a server nobody called.

Live, staging: no revision and a malformed revision refused locally; a good
revision wrote one disabled Gmail tool and returned it in `effective`; the
same revision again answered `POLICY_CONFLICT`; the list row showed the tool;
the restore brought the member rules back to the start. Live, staging and
production, read-only: all 60 tool lists (5483 tools) parse.

* fix(connectors): the operation RPCs match their contract; a settled card cannot start a new link

Found by two adversarial reviews of the RPC layer and its types.

- `connectors.connect` from a chat session with no open operation is refused
  (`UNKNOWN_OPERATION`). It used to call `manage_connections` through the tool
  registry with no card: it made a link nobody watched, returned a reply
  without the required `settled` field, and named an operation that was never
  registered. There is one way into an operation: the agent's call, or the
  account owner's `connectors.connect`. "Run it again" inside an open
  operation is unchanged.
- `connection.update` for a session is routed by session key AND profile; two
  profiles with the same key no longer cross-deliver a sign-in link. The event
  payload gets the same redaction as the RPC replies.
- `connection.respond` runs on the long-handler pool: an approval can start MCP
  OAuth discovery, which blocked every RPC of the gateway while it ran.
- `connectors.list` rows are a closed snake_case model: `connector`, `enabled`,
  `connected`, `connection_status`, `status_reason`, `gateway_disabled_tools`.
  The last one is display data: the gateway enforces the rules, the backend
  only passes the list on. The phantom `name` and `description` are gone, and
  the desktop uses the generated types instead of hand-written copies.
- `tools_listing` (model-only data) no longer rides on `connectors.operation.status`.
- `unavailable` is removed from the target states and settle reasons: nothing
  produces it. The contract generator now fails when a contract enum and its
  domain enum differ.
- `ConnectorErrorReason` is part of the generated TypeScript and OpenRPC.
- The desktop sends `connection.respond` on the socket that holds the session,
  as wake and reissue already did.
- Contract violations are logged every time, at error level.
- An account connect whose prepare step is slow returns the live operation
  instead of an error while the operation keeps running.
- The MCP-manifest `connector` field leaves this PR (it moves to a later one
  on top of the catalog-reader change). `hermes_cli/mcp_catalog.py` and
  `optional-mcps/` are untouched by this PR again.

anti-slop: no net-new findings (15 touched files).

* fix(connectors): the model gets no sign-in link wherever a card exists; side agents cannot connect

The flag that tells the model "a connection card exists" was the session
platform (`== "desktop"`). The Ink TUI and the classic CLI also draw a card,
so there a connector call on an unconnected app handed the model the raw
`connect_url` and told it to pass the link to the user.

- The agent turn now declares how a link can reach the user
  (`tools/connectors/turn.py`): CARD when the agent was built with a
  connection callback, SIDE for a subagent or a background turn, LINK for a
  headless run (`-q`, cron, ACP, api_server, messaging). It is set once per
  tool batch in the agent loop and read by the connector dispatch path, which
  never sees the agent. The session platform decides return-to-app only.
- CARD: the result carries `connect_card_available` and our hint, never the
  link and never the gateway's own hint.
- SIDE: subagents (`delegate_tool`), gateway background turns and the classic
  CLI `/bg` are built with `side_agent=True`. They hold no `manage_connections`
  tool on any path that derives the tool list, and a connector call on an
  unconnected app gets no link, only "report this to the main agent".
- LINK is unchanged.
- The hosted path with no card builds a detached operation, as the MCP path
  does, so no `connection.update` is emitted for an operation no client asked
  for. Names and docstrings that said "off desktop" now say "no card".
- A settled card is dead on the desktop: `reissueConnectionTarget` and
  `respondToConnectionRequest` share one guard and send nothing for a settled
  or unknown operation.
- The model-facing settled result no longer carries `connection_id`; the model
  repeated it to the user.

Shown on the real clients with a real model (rig, fake tool gateway): Ink TUI
and classic CLI get `connect_card_available` and no link, the model opens the
card, the account connects, the retried call succeeds; `-q` still gets the
link; a subagent and a background turn have no `manage_connections` and get
the no-link hint; on the desktop a card settled with Continue has no enabled
control and sends no RPC.

* feat(tools): every call made through tool_search + tool_call shows a real label on all three clients

A bridged call showed as a generic `tool_call` row in the Ink TUI and as
`⚡ tool_call` in the classic CLI, because the display looked the name up in
the tool registry and bridged names are made at run time. The desktop labelled
only batches that were all hosted connector calls, by parsing names itself.

- `tools/tool_labels.py` is the one place that turns a bridged call into a
  label: kind, app, action, emoji and text. Hosted: `connectors__gmail__GMAIL_SEND_EMAIL`
  → "Gmail · send email". MCP: "Linear · list issues". A local deferred tool
  keeps its own emoji, verb and primary-argument preview. A batch gets exactly
  one label per entry, always; an entry with no name gets a generic label.
- Classic CLI: one row per inner call; the duration on the last row; the
  failure text on the row of the call that failed. With friendly labels off
  it prints what it printed before.
- Gateway: tool start, progress and complete events and stored transcript rows
  carry a typed `labels` field. It does not depend on the classic CLI's
  display setting. Clients no longer parse tool names.
- Ink TUI: rows from the labels; the verbose trail keeps Args and Result.
- Desktop: `ConnectorExecution` renders hosted, MCP and mixed turns from the
  labels, one row per call. The labels reach the row under a key no tool
  argument can use. The connect card it drew under a failed tool result is
  gone: after `CONNECTION_REQUIRED` the one way in is the agent's own
  `manage_connections` call.
- `tool_search` and `tool_describe` rows read "Searching tools · <query>" and
  "Reading tool details · N tools".

Shown on the real desktop (video and screenshots), the Ink TUI and the classic
CLI with the rig: hosted rows, MCP rows, a two-entry batch, a failed entry, a
`CONNECTION_REQUIRED` row with no card under it, labels after a reload, and the
desktop rows with the classic CLI setting off.

* fix(connectors): the model can tell "hosted tools unavailable" from "no such tool"; manage_connections routes MCP names correctly

- A failed hosted search or describe used to return nothing, by design, so the
  model saw only local tools and told the user that a connected app was
  missing. The local results are unchanged; when the hosted leg failed, the
  `tool_search` and `tool_describe` results carry
  `connectors: {status: "unavailable", reason: "unreachable" | "sign_in_expired"}`
  and one hint line. A rejected token is `sign_in_expired`; an entitlement
  refusal or a shut gate adds nothing. `tool_describe` no longer lists those
  names under `not_found` next to "search again".
- NS-932. The description now says which side a name belongs to: a bare name
  is a hosted connector account; `mcp: true` only when the user asks for an MCP
  server, a local server or an install, or when the name exists only in the
  catalog; connect and reconnect are hosted verbs, install, enable and
  authorize are MCP verbs. It names the three clients that draw a card.
- A misrouted target is refused with the call that works. Only when the
  gateway does not know the connector (confirmed on that failure path) and the
  name is a catalog entry does the target fail with "X is a local MCP server.
  Call manage_connections with action install ...". It is a per-target
  outcome: other targets of the same call keep their links and their card. A
  vendor failure on a name both sides know stays an ordinary failed row. The
  MCP side mirrors it, and never for an entry that is only not installed.
- "Do not re-ask after a skip or a timeout" no longer stops the model when the
  USER asks for that app again; the description and the settled-result notes
  say so. A builder saw the model refuse a direct user request.

Shown on the Ink TUI and the classic CLI with a real model: a dead gateway and
a 401; "connect fxmail" goes hosted; "install the fx-noauth MCP server" goes
MCP; "connect fx-noauth" reaches the MCP install card in one corrective round
with no hosted mint; a two-target call where one is misrouted still connects
the other with exactly one mint.

* fix(tui): the connection card answers every key, shows what is happening, and is dead once settled

Reproduced on the real Ink TUI with the rig, then fixed:

- The keyboard was dead during the sign-in wait: the card kept a `submitting`
  flag that the normal OAuth path never cleared, and Esc went through the same
  guard. The in-flight state now belongs to the answered row and clears when
  that row moves, when any later frame of the operation arrives, or after
  five seconds. Esc skips the row in every phase; Ctrl+C interrupts the turn
  (the input handler had no branch for this overlay); Shift+arrows scroll the
  transcript and the card ignores them; arrow keys no longer move the text
  cursor and the field focus at once.
- The card was lost at turn idle: the overlay flag was cleared while the
  operation stayed in the store, and a resume dropped the pending card. The
  flag survives idle, a resume shows the pending card again, a session switch
  clears it.
- States with no branch: `not_connected` and a row with no link fell into the
  credential form; `expired` vanished with no note. The title and the row text
  now name the action (connect, reconnect, install, enable, authorize); a
  failed or expired row with no fields offers Try again / Skip; a failed row
  WITH fields reopens the form over the typed draft, with the failure above it.
- A settled card is dead: at settle the overlay closes and one transcript line
  per app states the outcome. A settled or dismissed operation id is
  remembered, so no replay or resume can reopen its card. Esc in the last
  "Finishing…" moment hides the card and still writes the outcome lines.
- A failed `connection.respond` and a browser that did not open are shown on
  the card in one sentence.

Also: `tui_gateway/connector_payload.py` redacted the BOOLEAN `secret` flag of
a credential field to the string "[REDACTED]". On the desktop every credential
field therefore rendered as a password and lost its prefilled default. A
boolean is no longer redacted.

* chore(connectors): remove the comments and docstrings this branch added

Deletions only. Kept: tool directives (`# noqa`, `// eslint-disable`, ...),
`// SAFETY:` lines, and the docstrings of the contract models under
`tui_gateway/contracts/`, which become the descriptions in the generated
OpenRPC and TypeScript.

Checked that no code changed: every Python file has the same AST as before
once docstrings and `pass` are ignored (62 files), and every TypeScript file
prints the same with comments stripped by the TypeScript printer (32 files).
The generated contract files are unchanged.

* fix(connectors): a card restored after a reload answers again; every account RPC names auth and org failures

Found by the end-to-end runs on the pushed head.

- Desktop: after a window reload, Continue on the restored card sent nothing.
  The answer looked up the backend that holds the session with the runtime
  session id, the lookup wants the stored id, and a failed lookup returned
  silently. When the lookup gives no owner the answer now goes out on the
  window's active socket, which is what main does.
- `connectors.policy.get` answered `POLICY_UNAVAILABLE` for a rejected sign-in,
  a refused scope, a non-member and a missing organisation alike: the handler
  runs with the gateway's globals and did not import the reason enum, so its
  own error mapping raised. `connectors.accounts.remove` caught auth failures
  in its generic branch. `org_required` was mapped on `policy.set` only. All
  six account RPCs now answer `NEEDS_NOUS_AUTH`, `FORBIDDEN_SCOPE`,
  `ORG_ACCESS_DENIED` and `ORG_REQUIRED` for those four upstream answers.

* wip(desktop): port the Connectors tab files and wiring onto the #115191 head

* wip(desktop): Connectors tab on the #115191 contract, catalog arm removed, audit defects fixed

* wip(desktop): Connectors tab passes the anti-slop ratchet; dormant two-ways code and the Available collapse removed

* wip(mcp): every server row says whether config or a plugin provides it; writes refuse plugin rows

* wip(desktop): Connectors tab, the owner's first live round (custom MCP form, kind words, compact dialog)

* wip(desktop): the connector dialog fits its content

* wip(desktop): catalog MCPs show on the Connectors tab until the catalog dies; connector_slug pairs a manifest with its managed app; the closed-gate state

* wip(desktop): connectors cache v3, the seed shape gained connector_slug

* wip(desktop): the owner's answers on the connectors page

A plugin-provided server now shows its tool list: the dialog probes it
through the existing read-only test endpoint, shows the tools without
switches (the plugin owns them), and shows the probe's error with a
Retry when the server cannot start. Its card is named after the server
key in the plugin's mcp.json, not the namespaced runtime key.

The paste box no longer parses `--header` on a `hermes mcp add` line;
the CLI has no such flag.

The rule write sends the member layer's revision only. The portal
always returns a member layer (baseline revision when no row exists)
and compares the write against that row, so the effective revision was
never the right guess. Verified live on staging: two writes in a row,
both accepted, policy restored.

The page cache keeps every read for signed-in accounts too and only
clears itself when the account is signed out. The storage version moves
to v4 so old blobs are ignored.

* chore(desktop): strip the prose comments the connectors page branch added

Comments and docstrings this branch added relative to main are gone;
tool directives, SAFETY lines and the contract docstrings that feed the
generated OpenRPC stay. Guards: Python AST and TypeScript printer output
are identical before and after; ruff, tsc, eslint, the ratchet and the
generated contracts are unchanged.
2026-09-22 17:16:00 +05:30
Siddharth Balyan
4094ab610d hermes_platform.resolver: locate/inspect/probe tiers, AppResolver, gh lookup migrated (NS-921) (#118065)
* feat(platform): resolver core with locate/inspect/probe tiers and ordered candidates

Every resource lookup needs one result shape and one cost contract. `locate` reads
metadata only, `inspect` may open files and call OS APIs in-process, `probe` is fresh
and the only tier that may spawn or connect. `Resolution.candidates` keeps probe order
so fan-out consumers can try every present binary.
Linear NS-921.

* feat(platform): AppResolver over AppDef with plist, PE, registry, and server.json sources

Desktop apps need presence, version, and liveness as separate observations. The runtime
file's bearer token is parsed, used for one request, and discarded inside the probe;
no public type carries it. Endpoints are accepted only when loopback with a numeric port.

* refactor(copilot): gh candidates through locate_command and the Homebrew table

First consumer of the resolver. The gh token probe still tries every present binary in
order; the allowlist loses its two copilot_auth rows.

* feat(platform): availability() over an application declaration

locate() + inspect() only, never probes; the fail-closed _version in
app.py treats a vendor's plist/PE/registry entry as untrusted input.
Salvaged from PR #118122; reads any object with requires_app,
min_version, app_for(os) — nothing here imports the MCP catalog.

* feat(platform): application declarations parsed into AppDef per OS

The parser slice of PR #118122's catalog manifest, re-homed as a
catalog-free module: whoever owns an MCP server declares the app it
fronts per OS and what it needs, and registers it here. Stdlib +
hermes_platform.resolver only. register/lookup/clear are the one seam
the MCP check_fn and the skill gate both read.

* feat(mcp): check_fn honours a registered application declaration

_make_check_fn ANDs the declared app's availability into the
connection-alive check; with nothing registered for the server the
behaviour is the pre-PR3 connection check. Provenance is explicit
registration, not endpoint matching. Returns a plain bool: the registry
caches bool(fn()).

* feat(skills): requires_apps gate through registered declarations

Offer-time filter beside environments:; names resolve through
hermes_platform.declaration, an unknown name hides the skill (fail
closed). The disk snapshot carries requires_apps and the fast path
re-evaluates it (snapshot version bumped to 3): app presence is a host
fact that changes without SKILL.md changing.

* docs: application declarations page

The plugin-facing schema reference: app: and requires: blocks,
availability() states, and the two gates that read the registry.
Registered under Extending > Plugins in the docs sidebar.

* test(platform): declaration parser, availability, gates

The PR3 app-block tests re-homed off the catalog: fixtures are dicts
passed to parse_declaration, the check_fn gate keys on explicit
registration (not endpoint matching), and the import-hygiene probe now
covers hermes_platform.declaration and resolver.availability.
2026-09-22 17:08:30 +05:30
kshitijk4poor
e175ee3a4d test(desktop): trim kanban scope tests to their invariants
Store test header points at the store/connections.ts comment instead of
restating it; drop the two assertions implied by the final-tag check; drawer
test invalidates via taskKey() instead of a raw prefix literal. Revert the
comment-style churn on the unrelated $activeConnectionProfile subscription.
2026-09-22 17:00:02 +05:30
kshitijk4poor
944e017cbe fix(desktop): kanban queries fetch only while keyed to the routed connection
On a connection switch the request tag moves (applyActive →
setApiRequestConnection) before the descriptor publishes, and React re-keys
the kanban observers later still. The app-wide invalidations that fire in that
window (the connection twin, the profile twin) refetched observers still
sitting on the OUTGOING scope's key with the INCOMING tag — writing the new
gateway's boards/tasks under the old connection's cache key, which then
painted on the way back. Three fetches per query per switch, one of them
poison.

Install `enabled: routedToScope` as the `['kanban']` query default in bindApi:
a kanban query only fetches while its key's scope segment matches where a
request is routed right now (`host.activeConnectionId()`). Outgoing observers
are skipped; the incoming keys are already a cache miss and fetch once on
re-render. The drawer's two `enabled: !!id` sites compose it.

Also: the connection listener uses nanostores' previous value instead of a
mutable tracker; 'local' literal hoisted to LOCAL_SCOPE; duplicated rationale
comments cut.

Test: an observer on boardsKey('local') with the route moved to spark is not
refetched by invalidateQueries(); back on local it is. Red without the
default (`[null, 'spark']`), green with it.
2026-09-22 17:00:02 +05:30
kshitijk4poor
49f47ef64c refactor(desktop): connection-scope invalidation is a listen on $activeConnectionId
$activeConnectionId is a computed of a primitive: nanostores' set() drops
equal values and listen() does not fire on attach, so the undefined
sentinel, the change guard and the comment explaining them are already
provided by the store. One listener replaces the block riding the
$activeConnectionProfile subscription; both connection-scope tests hold.
2026-09-22 17:00:02 +05:30
kshitijk4poor
e4a1969fd6 fix(desktop): kanban keeps the bare slug key for local and dials once per switch
boardSlug.<scope> for every connection abandoned the slug existing users
had persisted under the bare key and broke the lib/connection-scoped.ts
contract (the local connection keeps the bare key, byte-identical storage
for single-backend users). Local now reads and writes `boardSlug`; remote
connections get `boardSlug.<id>`.

On a connection change whose persisted slug differed, hydrating $boardSlug
already reopened the socket through the $boardSlug listener, and the
listener then dialed a second time. Reopen explicitly only when the slug is
unchanged (the backend behind it still changed), so each switch dials once.

Test covers both plus the render-time key following the connection without
a manual rerender.
2026-09-22 17:00:02 +05:30
kshitijk4poor
a625189410 fix(desktop): kanban query keys read the connection scope reactively
The list keys (BOARDS_KEY, PROFILES_KEY, PROJECTS_KEY, ORCHESTRATION_KEY)
were module-level consts, so their scope segment was evaluated once at
import and stayed 'local' for the life of the app — the boards list, the
query behind the reported symptom, never got the cache miss the scoping
promised. The per-slug builders read host.state.connectionId.get() during
render with no subscription, so when the slug was the same on both
gateways (the default '' is) the observer kept the old-scoped key, the
twin's refetch stored the new gateway's data under the old scope, and the
next re-render flipped the key into a second fetch.

Every builder now takes the scope explicitly: rendering components get it
from useKanbanScope() (useValue on the SDK atom, so a switch re-renders
them and their observers move to the new key), non-rendering actions
(mutation settles, socket frames) from kanbanConnectionScope() at call
time. boardKeyPrefix(scope) replaces the raw ['kanban', 'board'] arrays
that leaked the key shape into six call sites.
2026-09-22 17:00:02 +05:30
Ben Barclay
8027c370a1 fix(desktop): kanban (and every connection-scoped query) follows the gateway switch
A connection switch left the kanban pane painting the previous
gateway's boards. Three holes, one root cause — the switch commit
runs its cache wipe BEFORE the activation publishes the new request
scope, and nothing re-invalidates after the tags move:

- store/connections: the CONNECTION twin of profile.ts's
  $activeGatewayProfile subscription. beginGatewaySwitch →
  invalidateProfileScopedQueries fires inside beforeActivate, so its
  refetches ride the OUTGOING backend; when the connection id moves
  (profile unchanged, e.g. default→default) nothing re-invalidates.
  Ride the existing $activeConnectionProfile.subscribe (no new
  computed listener) and invalidate on the actual id change; an
  undefined sentinel suppresses the first fire because the id is
  legitimately null on the local primary.

- plugins/kanban/api: every query key embeds the active connection
  scope (kanbanConnectionScope — the hermes-bots roster pattern), so
  a switch is a clean cache miss and one gateway's boards can never
  paint under another connection's route. The persisted board slug
  becomes per-connection storage (boardSlug.<id>): a slug that pins a
  localhost board 404s on the next gateway and froze the pane on the
  last successful (localhost) data.

- plugins/kanban/api: the events socket re-opens on a connection
  change — pluginSocket resolves the backend only at connect time, so
  a socket left open across a switch streamed the old gateway's
  events against the new connection's cache forever.

Regression tests in src/store/kanban-connection-scope.test.ts drive
the REAL selectConnection chain: the post-switch refetch must be
tagged for the NEW gateway, and a no-change registry republication
must not refetch. Mutation-checked: both fail without the twin.

(cherry picked from commit 3ea28be090c3ee885b296694c74be40f84081d2c)
2026-09-22 17:00:02 +05:30
Siddharth Balyan
de5bb5cf13 Merge pull request #117863 from NousResearch/sid/ns-920-hermes-platform-host
hermes_platform.host: one machine-facts package, WSL/container predicates, NVIDIA ARM64 SoC recognizer (NS-920)
2026-09-22 16:49:01 +05:30
ethernet
a49d196b5c Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	hermes_cli/env_loader.py
#	hermes_cli/urllib_security.py
#	tools/terminal_scope.py
2026-09-22 07:05:11 -04:00
ethernet
9d5fce810c Merge branch 'fix/r5-credits' into ethie/pm-clean 2026-09-22 06:59:41 -04:00
ethernet
4d9fc32165 Merge branch 'fix/r5-compression' into ethie/pm-clean 2026-09-22 06:59:41 -04:00
ethernet
24a6827de1 test(compression): synchronize stale-attempt ownership causally
Resolve the lazy context length before worker launch and gate both ownership
interleavings with events, so loaded runners cannot lose the provider-dispatch
race to an arbitrary ten-second timeout. Keep the fallback commit ordered
before the detached primary is released.
2026-09-22 06:57:00 -04:00
ethernet
5533a76086 fix(tests): synchronize credits seed causally
The background seed tests found workers by process enumeration and failed if a contended runner did not finish them within ten seconds.

Capture the exact context-bound worker. Hold its first side effect until the launcher returns, then release and join it without a scheduling deadline. This keeps the real fire-and-forget thread contract under test.

Verification: HERMES_TEST_FILE_RETRIES=0 scripts/run_tests.sh tests/agent/test_credits_cold_start.py (10 passed)

Focused file only. No full suite was run.
2026-09-22 06:46:36 -04:00
kshitijk4poor
92dd332192 test(skill_ledger): gc test ages its orphan blobs past the in-flight grace
The blob GC contract is now "unreferenced AND older than
_BLOB_GC_GRACE_SECS"; the existing test stored its orphans and swept
them in the same second, which the grace window (correctly) refuses.

PROOF: test_gc_blobs_removes_only_unreferenced red on the previous head
(1 deleted expected, 0 observed), green now; 11 passed in the file.
2026-09-22 16:16:30 +05:30
kshitijk4poor
058f817aad fix(computer_use): _computer_use_cfg reads config through load_config again
b5a9f44829 switched the shared computer_use config reader to
load_config_readonly. That reader also serves the daemon-launch paths
(overlay flag, Wayland child env), and tests/computer_use pins
hermes_cli.config.load_config as the seam at 13 sites; the deepcopy it
saves is noise next to an 80-500 ms capture. The ledger half of that
commit stays.

PROOF: tests/computer_use/test_cua_wayland_env.py and
test_cua_no_overlay.py::test_linux_x11_explicit_false_overrides_auto_detect
red on the previous head, green now (macOS-only
test_serve_process_disables_overlay fails identically on origin/main).
2026-09-22 16:16:30 +05:30
kshitijk4poor
65d33f20ba test(skill_ledger): shorten the concurrency test's forced-race wait to 1 s
`b_done.wait(3.0)` always times out on correct code (the lock blocks writer B
until A's sweep finishes), so it was a fixed 3 s sleep. 1.0 s keeps the same
guarantee: on the broken-lock path B's append lands in milliseconds, and no
assertion depends on the timing.

PROOF: run_tests.sh ledger + AX files 29 passed; test_skill_ledger.py file
time 5.6 s -> 3.9 s.
2026-09-22 16:16:30 +05:30
kshitijk4poor
ed6b55d1d8 fix(skill_ledger): blob GC keeps unreferenced blobs younger than an hour
`snapshot_paths` / `_store_blob` write blobs OUTSIDE `_ledger_lock`, seconds
before the row that references them is appended. Since `_maintain_size` now
runs `gc_blobs()` on any append that trims, a sweep in another process during
that window deleted the in-flight capture: its row then landed with sha256
values `read_blob` cannot resolve and `rollback_entry` failed.

`_gc_blobs_locked` now skips any unreferenced blob file (incl. `.tmp-*`) whose
st_mtime is newer than `_BLOB_GC_GRACE_SECS = 3600`; no new config key.
Docs (curator.md) and the `gc_blobs` docstring say so.

PROOF: probes/s5_final_inflight_blob.py before -> `P1 blob survives P2's
sweep: False ... read_blob: None`; after -> `True ... read_blob: b'P1
in-flight skill file'`. test_concurrent_appends_never_lose_a_middle_row gained
a fresh + 2h-aged unreferenced blob pair: red with the grace set to 0 (fresh
blob deleted), green at 3600 (aged deleted, fresh kept). ruff clean,
check-windows-footguns --all clean, run_tests.sh ledger + AX files 29 passed.
2026-09-22 16:16:30 +05:30
kshitijk4poor
2866bc6dff perf(skill_ledger): skip the compaction rewrite when nothing changed
Append-time `_delta` already strips unchanged paths, so on any ledger written
since it landed `compact_ledger` parsed every row and then `_rewrite_ledger`
wrote the identical file (up to 5 MB) on every maintenance sweep. Compare the
compacted payload with the raw bytes and return `(kept, len(raw), len(raw))`
without touching the file when they are equal; return semantics are unchanged.

PROOF: probe (probes/S5_compact_noop.py) with `os.replace` wrapped in a counter —
first sweep over 5 legacy fat rows: (5, 1545, 585), 1 os.replace; second sweep on
the now-compact file: (5, 585, 585), 0 os.replace. Existing ledger tests green
(29 passed in tests/tools/test_skill_ledger.py + test_computer_use_ax_walk_bound.py).
2026-09-22 16:16:30 +05:30
kshitijk4poor
c86607124f fix(skill_ledger): hold .locks/ledger.lock across append + sweep and the CLI compact/GC path
`_maintain_size()` now runs inside every `append_entry`, and `compact_ledger`/
`_trim_oldest` do read-bytes -> `os.replace` over the ledger with no cross-writer
lock, so a concurrent appender's O_APPEND write landing on the replaced inode was
silently lost — and `gc_blobs` then deleted that row's blobs. `_ledger_lock()`
(same `skill_file_lock` idiom as `_skill_mutation_lock`; fcntl/msvcrt, re-entrant,
no-op where neither exists) is held across the append AND the sweep, and inside
`compact_ledger`/`_trim_oldest`/`gc_blobs` for the `curator ledger --compact` path.

PROOF: tests/tools/test_skill_ledger.py::test_concurrent_appends_never_lose_a_middle_row
forces writer B to append between writer A's sweep read and its os.replace; every
row must be present or counted as trimmed. Green 2/2 (3.5 s). With `_ledger_lock`
made `contextlib.nullcontext()`: red 4/4 ("none silently lost").
2026-09-22 16:16:30 +05:30
kshitijk4poor
99ced8117c refactor(skill_ledger): name the 5 MB ledger default and drop the dead <= 0 branch
Hoist the sole remaining `5 * 1024 * 1024` literal to `_DEFAULT_LEDGER_MAX_BYTES`
(fold-3 already collapsed the docstring/except copies into `_skills_cfg`), and
spell `_trim_oldest`'s early return as `if not dropped` — `dropped` is a length
difference and can never be negative. The `if lines else b""` payload guard now
lives in the shared `_rewrite_ledger` and stays: `compact_ledger` can legitimately
reach it with an empty row list.

PROOF: scripts/run_tests.sh tests/tools/test_skill_ledger.py
tests/tools/test_computer_use_ax_walk_bound.py green, no assertion changes;
`_max_ledger_bytes()` returns 5242880 via real import; ruff + footguns clean.
2026-09-22 16:16:30 +05:30
kshitijk4poor
8b41224bfc refactor(computer_use): capture() derives the AX-walk bound from the args it sends
Drop the `_ax_max_elements_sent` side channel, its `getattr` default and the
`contextlib.suppress(Exception)` around the lazy `cua_backend` import:
`_cua_configured_ax_max_elements()` already swallows config errors, and the
same lazy import is bare in `_resolve_capture_windows`. `capture()` now reads
`_gws_args().get("max_elements", 0)` directly (one more cached
`load_config_readonly` hit); the vision lane still reports 0.

PROOF: tests/tools/test_computer_use_ax_walk_bound.py 5 passed; hardcoding
`ax_max_elements=0` in capture() turns `stub.capture("ax").ax_max_elements == 350`
red (observed), restored green. ruff clean; check-windows-footguns clean; real import ok.
2026-09-22 16:16:30 +05:30
kshitijk4poor
8268fc7810 refactor(skill_ledger): one _skills_cfg reader behind ledger_enabled and _max_ledger_bytes
Both gates repeated the try / lazy-import / cfg_get(load_config_readonly(), "skills",
…) / debug-log / default shape. `_skills_cfg(key, default)` owns it; the callers keep
their bool()/int() coercion and defaults. Still a lazy import of the module attribute,
so tests that monkeypatch `hermes_cli.config.load_config_readonly` keep taking effect.

PROOF: tests/tools/test_skill_ledger.py 23 passed unchanged (incl.
test_config_gate_off_no_ledger_writes); mutation — `_skills_cfg` returns the default
without reading config → test_config_gate_off_no_ledger_writes,
test_auto_compact_triggers_at_threshold, test_trim_oldest_when_still_over_cap fail.
2026-09-22 16:16:30 +05:30