hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(lsp): strip credentials from installer env

Browse Source 
npm and go install run third-party package code; they now start from
hermes_subprocess_env() instead of a full os.environ copy (go keeps
GOBIN, npm keeps the Hermes-managed Node path).

Ported from #55556 onto current main; the pip path now provisions
through pm.ensure_python_tool and is not part of this change.
This commit is contained in:
dsad
2026-09-27 20:53:47 +09:00
committed by kshitij
parent 75a97dfcfe
commit ea2dae4f4e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
agent/lsp/install.py
View File

@@ -262,7 +262,9 @@ def _install_npm(pkg: str, bin_name: str, extra_pkgs: Optional[list] = None) ->
install_targets = [pkg] + list(extra_pkgs or [])
cmd = [pm_bin, *_NODE_PM_ARGV[pm](str(staging)), *install_targets]
logger.info("[install] %s %s", pm, " ".join(cmd[1:]))
if not _run_installer(pm, pkg, cmd, timeout=300, env=with_hermes_node_path()):
from tools.environments.local import hermes_subprocess_env
# Package install scripts are third-party code: scrubbed env, never Hermes' credentials.
if not _run_installer(pm, pkg, cmd, timeout=300, env=with_hermes_node_path(hermes_subprocess_env())):
return None
found = _first_existing(staging / "node_modules" / ".bin" / bin_name)
if found is not None:
@@ -281,7 +283,9 @@ def _install_go(pkg: str, bin_name: str) -> Optional[str]:
return None
staging = hermes_lsp_bin_dir()
logger.info("[install] go install %s (GOBIN=%s)", pkg, staging)
if not _run_installer("go", pkg, [go, "install", pkg], timeout=600, env={**os.environ, "GOBIN": str(staging)}):
from tools.environments.local import hermes_subprocess_env
env = {**hermes_subprocess_env(), "GOBIN": str(staging)}
if not _run_installer("go", pkg, [go, "install", pkg], timeout=600, env=env):
return None
bin_path = (staging / bin_name).with_suffix(".exe") if _is_windows() else staging / bin_name
if bin_path.exists():