fix(cli): answer clarify headless in single-query turns

hermes chat -q wired the interactive prompt_toolkit clarify callback
unconditionally, but a -q turn never builds the prompt_toolkit
application — the modal can never be painted or answered, so the turn
polls its response queue until agent.clarify_timeout expires (default
3600 s, 0 = unlimited). The gateway, cron jobs, the kanban dispatcher
and inter-agent wakeups all deliver work as -q turns. Route the
single-query case to a headless callback at the agent-construction site
that already knows _single_query_mode, mirroring _oneshot_clarify_callback
on the -z path (#94943; third member of the family after #86909 and
#88013).
This commit is contained in:
liuhao1024
2026-08-26 02:44:19 +08:00
committed by Teknium
parent 808a22ea00
commit db2fd5f59a
2 changed files with 114 additions and 1 deletions

View File

@@ -21,6 +21,34 @@ from rich.markup import escape as _escape
from utils import base_url_host_matches
def _single_query_clarify_callback(question: str, choices=None, multi_select=False) -> str:
"""Clarify has no interactive surface in a single-query (-q) turn.
``hermes chat -q`` runs one turn without ever building the
prompt_toolkit application, so the interactive clarify modal can never
be painted or answered — the CLI callback would poll its response queue
until ``agent.clarify_timeout`` expires (default 3600 s, 0 = unlimited)
while the gateway/cron/kanban-dispatcher caller sees a silent hang. The
oneshot path answers immediately via ``_oneshot_clarify_callback``;
single-query turns need the same headless behavior (#94943)."""
if choices:
if multi_select:
return (
f"[single-query mode: no user available to answer {question!r}. "
f"Pick the best subset from {choices} using your own judgment "
f"and continue.]"
)
return (
f"[single-query mode: no user available to answer {question!r}. "
f"Pick the best option from {choices} using your own judgment "
f"and continue.]"
)
return (
f"[single-query mode: no user available to answer {question!r}. Make "
f"the most reasonable assumption you can and continue.]"
)
class CLIAgentSetupMixin:
"""Agent construction + session-resume display methods for ``HermesCLI``."""
@@ -521,7 +549,15 @@ class CLIAgentSetupMixin:
session_id=self.session_id,
platform="cli",
session_db=self._session_db,
clarify_callback=self._clarify_callback,
# A -q turn never builds the prompt_toolkit application, so
# the interactive modal can never be painted or answered —
# answer headless instead of polling until clarify_timeout
# (#94943; mirrors _oneshot_clarify_callback on the -z path).
clarify_callback=(
_single_query_clarify_callback
if getattr(self, "_single_query_mode", False)
else self._clarify_callback
),
reasoning_callback=self._current_reasoning_callback(),
fallback_model=self._fallback_model,

View File

@@ -0,0 +1,77 @@
"""Regression tests for the single-query clarify guard (#94943).
``hermes chat -q`` wires the interactive prompt_toolkit clarify callback
unconditionally: a -q turn never builds the prompt_toolkit application, so
``CLIApp._clarify_callback`` polls its response queue with nothing able to
answer it — the turn hangs until ``agent.clarify_timeout`` expires (default
3600 s, 0 = unlimited). The gateway, cron jobs, the kanban dispatcher and
inter-agent wakeups all deliver work as ``hermes chat -q``, so an agent that
calls ``clarify`` in those turns stalls silently. The oneshot (-z) path
already answers immediately via ``_oneshot_clarify_callback``; this pins the
same headless behavior for -q, wired at the ``CLIAgentSetupMixin`` agent
construction site that already knows it is in single-query mode.
"""
from __future__ import annotations
import inspect
def test_no_choices_returns_immediate_headless_answer():
from hermes_cli.cli_agent_setup_mixin import _single_query_clarify_callback
result = _single_query_clarify_callback("Which timezone should I use?")
assert result.startswith("[single-query mode: no user available")
assert "most reasonable assumption" in result
def test_choices_return_pick_best_guidance():
from hermes_cli.cli_agent_setup_mixin import _single_query_clarify_callback
result = _single_query_clarify_callback(
"Format?", choices=["json", "yaml"]
)
assert result.startswith("[single-query mode: no user available")
assert "Pick the best option from ['json', 'yaml']" in result
def test_multi_select_choices_return_subset_guidance():
from hermes_cli.cli_agent_setup_mixin import _single_query_clarify_callback
result = _single_query_clarify_callback(
"Which checks?", choices=["lint", "types", "tests"], multi_select=True
)
assert result.startswith("[single-query mode: no user available")
assert "Pick the best subset from ['lint', 'types', 'tests']" in result
def test_callback_signature_matches_oneshot_contract():
"""The headless callback must be a drop-in wherever a clarify callback is
accepted — same (question, choices, multi_select) shape as the oneshot
one and the interactive CLIApp one."""
from hermes_cli.cli_agent_setup_mixin import _single_query_clarify_callback
from hermes_cli import oneshot
ours = inspect.signature(_single_query_clarify_callback)
oneshot_cb = inspect.signature(oneshot._oneshot_clarify_callback)
assert list(ours.parameters) == list(oneshot_cb.parameters)
def test_agent_construction_gates_clarify_callback_on_single_query_mode():
"""The mixin's AIAgent construction site must route -q turns to the
headless callback — the regression this pins is wiring the blocking
interactive callback unconditionally (#94943). Source-level pin modeled
on test_cli_active_agent_ref_wiring: _init_agent is too integration-heavy
to drive with a stub, but the wiring contract is one expression."""
from hermes_cli import cli_agent_setup_mixin as mixin_mod
src = inspect.getsource(mixin_mod)
assert "_single_query_clarify_callback" in src, (
"the headless single-query clarify callback disappeared from the mixin"
)
init_agent_src = inspect.getsource(mixin_mod.CLIAgentSetupMixin._init_agent)
assert 'clarify_callback=' in init_agent_src
assert '"_single_query_mode"' in init_agent_src or "'_single_query_mode'" in init_agent_src, (
"the clarify_callback wiring no longer consults _single_query_mode — "
"-q turns would hang on the interactive modal again (#94943)"
)