refactor: drop dead sys.exc_info check in delivery error log

The result-error path in _deliver_result is not inside an except block,
so sys.exc_info() always returns (None, None, None) — the condition was
always False. Simplify to a plain logger.error call with accurate comment.
This commit is contained in:
kshitij
2026-08-10 10:53:57 +05:30
parent 100219f664
commit d3e87eef44

View File

@@ -2231,11 +2231,11 @@ def _deliver_result(job: dict, content: str, adapters=None, loop=None) -> Option
if result and result.get("error"):
# Include target context (platform/chat) so a bare error string
# like "Discord send failed: TimeoutError: " is attributable;
# no active exception here (error comes from the send result),
# so exc_info is only attached when one is in flight.
# like "Discord send failed: TimeoutError: " is attributable.
# Not inside an except block — the error comes from the send
# result dict, so there is no traceback to attach.
msg = f"delivery error: {result['error']} (target {platform_name}:{chat_id})"
logger.error("Job '%s': %s", job["id"], msg, exc_info=sys.exc_info()[0] is not None)
logger.error("Job '%s': %s", job["id"], msg)
target_errors.extend([msg])
delivery_errors.extend(target_errors)
continue