hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 32 Packages Projects Releases Wiki Activity

fix(integration): restore explicit utf-8 encoding on codesign/loginctl subprocess calls flagged by footgun scanners

Browse Source
This commit is contained in:
Teknium
2026-09-02 19:39:38 -07:00
parent 69bb5982ad
commit c4668fa77e
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hermes_cli/doctor_platform.py
View File

@@ -380,7 +380,7 @@ def _macos_desktop_dr(app: Path) -> str | None:
if not codesign:
return None
try:
proc = subprocess.run([codesign, "-d", "--requirements", "-", str(app)], capture_output=True, text=True, timeout=15)
proc = subprocess.run([codesign, "-d", "--requirements", "-", str(app)], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=15)
except (FileNotFoundError, subprocess.TimeoutExpired):
return None
if proc.returncode != 0:

4
tools/computer_use/cua_backend.py
View File

@@ -184,8 +184,8 @@ def _linux_session_locked() -> Optional[bool]:
return None
def _loginctl(*args: str) -> subprocess.CompletedProcess:
return subprocess.run(["loginctl", *args], capture_output=True, text=True,
timeout=2.0, stdin=subprocess.DEVNULL)
return subprocess.run(["loginctl", *args], capture_output=True, text=True, encoding="utf-8",
errors="replace", timeout=2.0, stdin=subprocess.DEVNULL)
try:
proc = _loginctl("list-sessions", "--no-legend")

4
tools/computer_use/cua_backend_daemon.py
View File

@@ -49,8 +49,8 @@ def _validate_cua_driver_app_signature(app_path: str) -> None:
if not codesign:
raise RuntimeError("codesign is required to verify CuaDriver.app before launching it.")
try:
proc = subprocess.run([codesign, "-dv", app_path], capture_output=True, text=True, timeout=15,
stdin=subprocess.DEVNULL)
proc = subprocess.run([codesign, "-dv", app_path], capture_output=True, text=True, encoding="utf-8",
errors="replace", timeout=15, stdin=subprocess.DEVNULL)
except (OSError, subprocess.TimeoutExpired) as exc:
raise RuntimeError(f"could not verify CuaDriver.app signature: {exc}") from exc
if proc.returncode != 0: