hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

refactor(gateway): one wildcard-host predicate for the HTTP listeners

Browse Source 
Gate review: tcp_site.py grew its own `_WILDCARD_HOSTS` that already diverged
from shared_ingress.py (dropped "*" and ""). One `is_wildcard_host` in
shared_ingress, used by both the TIME_WAIT rebind guard and
`listener_base_url`.
This commit is contained in:
kshitijk4poor
2026-09-19 03:18:10 +05:30
committed by kshitij
parent 741d8db2da
commit aaaca43c84
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gateway/platforms/shared_ingress.py
View File

@@ -24,6 +24,11 @@ logger = logging.getLogger(__name__)
_WILDCARD_HOSTS = frozenset({"", "0.0.0.0", "::", "*"})
def is_wildcard_host(host: Any) -> bool:
"""True for the dual-stack default (None/"") and the per-family wildcards."""
return host is None or str(host).strip() in _WILDCARD_HOSTS
def shared_ingress_profile(adapter: Any) -> Optional[str]:
"""Profile name when *adapter* was constructed in shared-listener mode, else None."""
return getattr(adapter, "_shared_listener_profile", None) or None
@@ -31,7 +36,7 @@ def shared_ingress_profile(adapter: Any) -> Optional[str]:
def listener_base_url(host: Any, port: Any) -> str:
"""``http://host:port`` clients use to reach a listener bound on ``host`` (wildcards → loopback)."""
host = "127.0.0.1" if host is None or str(host).strip() in _WILDCARD_HOSTS else str(host)
host = "127.0.0.1" if is_wildcard_host(host) else str(host)
if ":" in host and not host.startswith("["):
host = f"[{host}]"
return f"http://{host}:{port or 0}"

10
gateway/platforms/tcp_site.py
View File

@@ -10,16 +10,10 @@ from typing import Optional
from aiohttp import web
from gateway.platforms.shared_ingress import is_wildcard_host
logger = logging.getLogger(__name__)
_WILDCARD_HOSTS = frozenset({"0.0.0.0", "::"})
def is_wildcard_host(host: Optional[str]) -> bool:
"""True for the dual-stack default (None/"") and the per-family wildcards."""
return not host or host.strip() in _WILDCARD_HOSTS
def has_live_listener(host: str, port: int) -> bool:
"""Blocking probe: True when something accepts connections on ``host:port``. Refused = nobody listens;
any other failure (timeout, unroutable) is treated as live so the caller stays exclusive."""