hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

refactor: trim empty-frame salvage to the translated error only

Browse Source 
Drop the raw JSONDecodeError belt from _is_provider_stream_empty_frame_error:
every chat stream iteration goes through _iter_provider_stream_chunks, which
already translates the decode failure, so the belt guarded a path that does
not exist. Drop the explicit classifier entry for the new code: unknown codes
already resolve to the same retryable unknown verdict (verified live: identical
ClassifiedError with and without the entry).
This commit is contained in:
teknium1
2026-09-15 11:40:29 -07:00
committed by Teknium
parent 71281fb266
commit 857133babd
2 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
agent/chat_completion_helpers.py
View File

@@ -262,17 +262,11 @@ def _provider_stream_error_from_json_decode_error(error: json.JSONDecodeError, *
def _is_provider_stream_empty_frame_error(exc: BaseException) -> bool:
"""True for a contentless SSE frame: either the translated ``ProviderStreamError`` carrying
the empty-frame code, or the SDK's raw ``JSONDecodeError`` with an empty ``doc`` (belt for
iteration sites that surface it without translation — ``json.loads`` only ever sees an
empty document when the frame carried no payload). A malformed payload is neither: its
``doc`` holds the offending text. Re-streaming cannot help either way — a degraded gateway
answers every stream that way — so the caller must change channel."""
"""True for the translated contentless-SSE-frame error. Re-streaming cannot help
(a degraded gateway answers every stream that way), so the caller must change channel."""
body = getattr(exc, "body", None)
error_obj = body.get("error") if isinstance(body, dict) else None
if isinstance(error_obj, dict) and error_obj.get("code") == PROVIDER_STREAM_EMPTY_FRAME_ERROR_CODE:
return True
return isinstance(exc, json.JSONDecodeError) and not str(getattr(exc, "doc", "") or "").strip()
return isinstance(error_obj, dict) and error_obj.get("code") == PROVIDER_STREAM_EMPTY_FRAME_ERROR_CODE
def _iter_provider_stream_chunks(stream, *, response: Any = None):

3
agent/error_classifier.py
View File

@@ -495,9 +495,6 @@ _ERROR_CODE_VERDICTS: Dict[str, Verdict] = {
**dict.fromkeys(("context_length_exceeded", "max_tokens_exceeded"), _V_CONTEXT_OVERFLOW),
**dict.fromkeys(_MEMORY_CEILING_ERROR_CODES, _V_OVERLOADED),
"invalid_encrypted_content": _V_INVALID_ENCRYPTED,
# An empty SSE keepalive frame: the retry it triggers is issued non-streaming
# (``_maybe_disable_streaming``), so the turn can still complete — never a format error.
PROVIDER_STREAM_EMPTY_FRAME_ERROR_CODE: _V_UNKNOWN,
}
# Generic ``invalid_request_error`` is deliberately NOT a 400 validation