hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

test(disk-cleanup): fold the untracked-scratch control into the checkout test

Browse Source 
The control test only added one thing over the first new test: a quick()
deletion check for untracked scratch in a git-init'ed HERMES_HOME. It also
passed on base, so it pinned no new behaviour. Save both entries in the
first test's quick() call and assert the tracked file survives while the
scratch beside it is deleted, then drop the control. The stack now adds
one test, and that test is still red on base.

Update test_scratch_outside_git_trees_still_cleaned's docstring. It said
only a .git below HERMES_HOME marks a file git-owned, which stopped being
true once an enclosing repo that tracks the file counts too.
This commit is contained in:
kshitijk4poor
2026-09-26 23:22:52 +05:30
committed by kshitij
parent f0df5e05b1
commit 6e8a0a0f99
1 changed files with 11 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/plugins/test_disk_cleanup_plugin.py
View File

@@ -264,8 +264,9 @@ class TestGitWorktreeFilesNeverCleaned:
def test_scratch_outside_git_trees_still_cleaned(self, _isolate_env):
"""Control: root-level test_* scratch is still auto-deleted — even when HERMES_HOME
itself lives inside a git checkout (dotfiles repo); only .git entries strictly below
HERMES_HOME mark a file as git-owned."""
itself lives inside a git checkout (dotfiles repo); a bare .git at or above HERMES_HOME
does not make untracked scratch git-owned — only a .git strictly below HERMES_HOME, or
git actually tracking the file, does."""
dg = _load_lib()
(_isolate_env.parent / ".git").mkdir()
scratch = _isolate_env / "test_scratch.py"
@@ -303,14 +304,18 @@ class TestGitWorktreeFilesNeverCleaned:
assert dg.guess_category(tracked) is None
assert dg.guess_category(scratch) == "test"
# A stale pre-fix entry is dropped by quick()'s re-validation, not deleted.
dg.save_tracked([{"path": str(tracked), "category": "test",
"timestamp": datetime.now(timezone.utc).isoformat(), "size": 1}])
# A stale pre-fix entry is dropped by quick()'s re-validation, not deleted, while
# untracked scratch beside it in the same repo is still cleaned.
now = datetime.now(timezone.utc).isoformat()
dg.save_tracked([{"path": str(p), "category": "test", "timestamp": now, "size": 1}
for p in (tracked, scratch)])
result = dg.quick()
assert tracked.exists(), "a git-tracked test file must never be auto-deleted"
assert result["deleted"] == 0
assert not scratch.exists()
assert result["deleted"] == 1
# Committed AFTER first classification in the same process: seen immediately.
scratch.write_text("x")
assert dg.guess_category(scratch) == "test"
subprocess.run(["git", "-C", str(_isolate_env), "add", "test_untracked.py"], check=True)
assert dg.guess_category(scratch) is None
@@ -325,25 +330,6 @@ class TestGitWorktreeFilesNeverCleaned:
monkeypatch.setenv("HERMES_HOME", str(outer / ".hermes"))
assert dg.guess_category(nested) is None
def test_untracked_scratch_beside_tracked_files_is_still_cleaned(self, _isolate_env):
"""Control for the checkout case: the guard protects what git TRACKS, not the whole
home. An untracked ``test_*`` scratch file in the same repo is still disposable, so
the fix must not disable cleanup for every file under a git-backed HERMES_HOME."""
import subprocess
dg = _load_lib()
subprocess.run(["git", "init", "-q", str(_isolate_env)], check=True)
scratch = _isolate_env / "test_scratch.py"
scratch.write_text("x")
assert dg._inside_git_worktree(scratch) is False
assert dg.guess_category(scratch) == "test"
dg.save_tracked([{"path": str(scratch), "category": "test",
"timestamp": datetime.now(timezone.utc).isoformat(), "size": 1}])
result = dg.quick()
assert not scratch.exists()
assert result["deleted"] == 1
class TestStaleCronEntryMigration:
"""Regression tests for #37721 — stale cron-output entries in tracked.json."""