fix(install): let HERMES_RUNTIME_DIR decide where the guarded store lands

The HermesHome/InstallDir guard checked HermesHome first and never looked at
HERMES_RUNTIME_DIR once HermesHome sat inside InstallDir, so the documented
escape hatch could not lift the refusal (Windows lane: store-guard case 4).
The store is HERMES_RUNTIME_DIR when set, else under HermesHome; judge that.

The runtime.ps1 Unicode tests read the helper's answer through a UTF-8 file:
under code page 437/936 the console cannot carry the profile's characters,
so a stdout capture lost them (and the 65001 cell's piped ConvertTo-Json
unrolled the one-element array into a string).
This commit is contained in:
Brooklyn Nicholson
2026-10-03 16:25:58 -05:00
committed by brooklyn!
parent 732b63d61a
commit 667b232535
2 changed files with 25 additions and 22 deletions

View File

@@ -336,17 +336,13 @@ function Initialize-ResolvedPaths {
# run populated it, and `git stash --include-untracked` would sweep the
# toolchain into the stash. Refuse before anything downloads (#124526)
# unless HERMES_RUNTIME_DIR parks the store outside the checkout.
$cmpHome = "$resolvedHome".TrimEnd('\', '/')
# The store lands in HERMES_RUNTIME_DIR when set (Get-PmStoreRoot), else under HermesHome.
$cmpStore = if ($env:HERMES_RUNTIME_DIR) { "$env:HERMES_RUNTIME_DIR" } else { "$resolvedHome" }
$cmpStore = $cmpStore.TrimEnd('\', '/')
$cmpDir = "$resolvedDir".TrimEnd('\', '/')
$dirPrefix = $cmpDir + [IO.Path]::DirectorySeparatorChar
$storeInside = $cmpHome -eq $cmpDir -or
$cmpHome.StartsWith($dirPrefix, [StringComparison]::OrdinalIgnoreCase)
if (-not $storeInside -and $env:HERMES_RUNTIME_DIR) {
# The override owns the store; only it decides where that lands.
$cmpStore = "$env:HERMES_RUNTIME_DIR".TrimEnd('\', '/')
$storeInside = $cmpStore -eq $cmpDir -or
$cmpStore.StartsWith($dirPrefix, [StringComparison]::OrdinalIgnoreCase)
}
$storeInside = $cmpStore -eq $cmpDir -or
$cmpStore.StartsWith($dirPrefix, [StringComparison]::OrdinalIgnoreCase)
if ($storeInside) {
Fail "HermesHome ($resolvedHome) cannot be the install directory or live inside it ($resolvedDir): the tool store would land inside the checkout. Use a separate -HermesHome, or point HERMES_RUNTIME_DIR outside -InstallDir."
}

View File

@@ -55,10 +55,20 @@ if __name__ == '__main__':
PROFILE = 'Balázs Paweł Ñuñez'
def _run_helper(script: str, home: Path, env_extra: dict[str, str]) -> subprocess.CompletedProcess:
return subprocess.run(['powershell', '-NoProfile', '-Command', script],
env={**os.environ, 'HERMES_HOME': str(home), **env_extra},
capture_output=True, text=True, timeout=120)
def _run_helper(script: str, home: Path, env_extra: dict[str, str], out: Path) -> list[str]:
"""Run *script*, which writes its answer lines to ``$out`` as UTF-8.
The answer goes through a file, not stdout: under code page 437 or 936 the console cannot
represent ``ł``, so stdout would lose the very characters under test.
"""
result = subprocess.run(['powershell', '-NoProfile', '-Command', f"$out = '{out}'; " + script],
env={**os.environ, 'HERMES_HOME': str(home), **env_extra},
capture_output=True, timeout=120)
assert result.returncode == 0, (result.stdout + result.stderr).decode('utf-8', 'replace')
return out.read_text(encoding='utf-8-sig').splitlines()
_WRITE = "[IO.File]::WriteAllLines($out, [string[]]@({lines}), (New-Object Text.UTF8Encoding($false)))"
@pytest.mark.platforms('windows')
@@ -90,10 +100,8 @@ def test_runtime_command_survives_a_non_ascii_profile_path(tmp_path: Path, code_
prefix = f"[Console]::OutputEncoding = [Text.Encoding]::GetEncoding({code_page}); "
script = (prefix + f". '{HELPER}'; "
f"$c = @(Get-HermesRuntimeCommand -InstallRoot '{target}'); "
f"$c[0]; [Console]::OutputEncoding.CodePage")
result = _run_helper(script, home, {'HERMES_RUNTIME_DIR': str(store)})
assert result.returncode == 0, result.stdout + result.stderr
lines = result.stdout.strip().splitlines()
+ _WRITE.format(lines="$c[0], [Console]::OutputEncoding.CodePage"))
lines = _run_helper(script, home, {'HERMES_RUNTIME_DIR': str(store)}, tmp_path / 'answer.txt')
assert lines[0] == str(python), (
f"interpreter path was mojibaked under code page {code_page}: {lines[0]!r}")
assert int(lines[1]) == code_page, 'the capture must restore the caller console encoding'
@@ -123,9 +131,8 @@ def test_legacy_version_identity_check_matches_a_non_ascii_install(tmp_path: Pat
target = str(install).replace("'", "''")
prefix = f"[Console]::OutputEncoding = [Text.Encoding]::GetEncoding({code_page}); "
script = (prefix + f". '{HELPER}'; "
f"try {{ @(Get-HermesRuntimeCommand -InstallRoot '{target}') | ConvertTo-Json -Compress }} "
f"catch {{ exit 1 }}")
result = _run_helper(script, home, {})
assert result.returncode == 0, result.stdout + result.stderr
assert json.loads(result.stdout)[0] == str(external), (
f"try {{ $c = @(Get-HermesRuntimeCommand -InstallRoot '{target}') }} catch {{ exit 1 }}; "
+ _WRITE.format(lines="$c[0]"))
lines = _run_helper(script, home, {}, tmp_path / 'answer.txt')
assert lines[0] == str(external), (
f"legacy identity check lost the non-ASCII path under code page {code_page}")