hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 29 Packages Projects Releases Wiki Activity

fix(rehearsal): record the raised VSS cap before raising it

Browse Source 
pre raised the shadow-storage cap to 128 GB and wrote the originals only
after the whole loop, so a pre that died mid-way left a raised cap with no
record for post to restore from. The cap must stay raised until post (it
is what keeps the snapshot alive during the update), so an exit trap is
wrong; instead record each original before raising it, and have status
list every recorded cap with the vssadmin command that puts it back when
post is never run.

The gateway stop the review flagged (`pkill -f "hermes gateway"`) is
already scoped: the .sh post runs `hermes gateway stop` under this
HERMES_HOME.
This commit is contained in:
ethernet
2026-09-24 13:54:50 -04:00
parent 2ba873b93a
commit 5956061fca
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/update-test/hermes-update-rehearsal.ps1
View File

@@ -389,18 +389,21 @@ function Invoke-Pre {
# disk; past the cap Windows deletes the snapshot. The cap is a ceiling, not
# a reservation. Raised AFTER the snapshot: on client Windows the storage
# association may only exist once a shadow does.
$storageLines = @()
# Each original cap is recorded BEFORE it is raised, so a pre that dies
# mid-way still leaves post and status the record to put it back from;
# restoring a cap that never got raised is a no-op.
$storageFile = Join-Path $script:Snap 'shadowstorage.txt'
Set-Content -LiteralPath $storageFile -Encoding utf8 -Value @()
foreach ($v in $volumes) {
$orig = Get-ShadowStorageMax $v
if ($null -eq $orig) { Warn "could not read the snapshot room on $v; leaving it as it is"; continue }
if ($orig -ge $ShadowStorageMax) { Ok "snapshot room on $v is $(Format-Bytes $orig)"; continue }
Add-Content -LiteralPath $storageFile -Encoding utf8 -Value "$v`t$orig"
if (Set-ShadowStorageMax $v $ShadowStorageMax) {
$storageLines += "$v`t$orig"
Ok "snapshot room on $v raised from $(Format-Bytes $orig) to $(Format-Bytes $ShadowStorageMax) (post puts it back)"
}
else { Warn "could not raise the snapshot room on $v; it stays $(Format-Bytes $orig) -- writing more than that to the disk before post drops the snapshot" }
}
Set-Content -LiteralPath (Join-Path $script:Snap 'shadowstorage.txt') -Encoding utf8 -Value $storageLines
# Plain text, not JSON: post compares this string byte-for-byte to decide
# whether the backup belongs to the home it is about to restore.
@@ -471,6 +474,15 @@ function Invoke-Status {
Say "snapshot $($s.Volume) $(if (Test-ShadowAlive $s) { 'present' } else { 'GONE -- post cannot roll back' })"
}
}
# The raised cap outlives this backup if post never runs; say how to undo it.
$storageFile = Join-Path $snap 'shadowstorage.txt'
if (Test-Path -LiteralPath $storageFile) {
foreach ($line in @(Get-Content -LiteralPath $storageFile | Where-Object { $_.Trim() })) {
$f = $line -split "`t"
$d = $f[0].TrimEnd('\')
Say "snapshot room $($f[0]) was $(Format-Bytes ([UInt64]$f[1])) before pre (post puts it back; without post: vssadmin resize shadowstorage /for=$d /on=$d /maxsize=$($f[1]))"
}
}
Say "data backup $(if (Test-Path -LiteralPath (Join-Path $snap 'hermes-backup.zip')) { 'hermes-backup.zip' } else { 'none' })"
Say "marker $(if (Test-Path -LiteralPath (Join-Path $P.Home '.skip_upstream_prompt')) { 'present' } else { 'absent' })"
$n = @(Invoke-GitCmd @('config', '--global', '--get-regexp', '^url\.')).Count