hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 31 Packages Projects Releases Wiki Activity

test: drop vacuous identity assertions from marker sync guard (#92231 review)

Browse Source 
CPython interns identifier-like string literals, so 'is' cannot
distinguish an import alias from a copy-pasted literal (verified:
two exec'd namespaces each defining the literal share one object).
The equality assertions three lines above are the full honest guard.
Also reword a comment: raw == is marker-SENSITIVE, not asymmetric.
This commit is contained in:
Kshitij Kapoor
2026-08-23 13:28:02 +05:30
committed by kshitij
parent 183e53656e
commit 4621a2d699
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/agent/test_load_time_durability_stamp_92231.py
View File

@@ -73,10 +73,6 @@ def test_marker_constant_in_sync() -> None:
assert _DB_PERSISTED_MARKER_KEY == run_agent._DB_PERSISTED_MARKER
assert _DB_PERSISTED_MARKER_KEY == cc._DB_PERSISTED_MARKER
assert _DB_PERSISTED_MARKER_KEY == tf._DB_PERSISTED_MARKER
# The import aliases must be the SAME object as the canonical constant,
# not re-defined literals.
assert _DB_PERSISTED_MARKER_KEY is cc._DB_PERSISTED_MARKER
assert tf._DB_PERSISTED_MARKER is cc._DB_PERSISTED_MARKER
def test_loaded_rows_are_stamped_durable(tmp_path: Path) -> None:
@@ -181,7 +177,7 @@ def test_noop_progress_check_is_marker_insensitive(tmp_path: Path) -> None:
{k: v for k, v in m.items() if k != _DB_PERSISTED_MARKER_KEY}
for m in stamped
]
assert swept != stamped # raw equality is asymmetric — the bug shape
assert swept != stamped # raw == is marker-sensitive — the bug shape
assert _strip_marker_for_comparison(swept) == _strip_marker_for_comparison(
stamped
)