hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 33 Packages Projects Releases Wiki Activity

test(source-check): pin that an unpublished main record follows the branch

Browse Source 
The refusal matrix no longer carries ("main", "missing"). State the
intended behaviour at the source-check level instead: a 404 for
releases/channels/main.json yields no error, probes the configured
branch exactly as a published source-branch channel would, and leaves
the Desktop branch setting untouched.
This commit is contained in:
ethernet
2026-09-24 16:01:26 -04:00
parent 364bff76e4
commit 3351ec0967
1 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/hermes_cli/test_source_check.py
View File

@@ -243,8 +243,8 @@ def test_dynamic_source_channel_preserves_branch_precedence(installation, select
# An unpublished ``main`` record is not a channel failure: main IS the source
# branch, so the check follows it via git (covered by
# test_source_channel_integration.py::test_unpublished_main_record_keeps_following_the_git_branch).
# branch, so the check keeps following a branch via git, with the usual branch
# precedence (test_unpublished_main_record_follows_the_branch below).
@pytest.mark.parametrize("name,failure", [
("stable", "missing"), ("canary", "missing"),
(None, "missing"), (None, "malformed"), (None, "foreign"), (None, "unpublished"),
@@ -285,6 +285,28 @@ def test_channel_failure_never_probes_or_heals_a_branch(installation, name, fail
assert json.loads(branch_file.read_text())["branch"] == "deleted"
def test_unpublished_main_record_follows_the_branch(installation):
"""A 404 for main.json keeps a checkout updating via git: the configured
branch is probed exactly as for a published source-branch channel, and the
Desktop branch setting is left alone."""
from hermes_cli.source_check import check_for_updates
root, linked, home, base, head, responses, requests, git = installation
responses[MAIN_CHANNEL] = (404, source_channel("main", "fixture/fork"))
branch_path = "/repos/fixture/fork/commits/desktop-choice"
responses[branch_path] = (200, head)
branch_file = home / "desktop-update.json"
branch_file.write_text(json.dumps({"branch": "desktop-choice"}))
status = check_for_updates(install_root=linked, home=home, channel="main",
branch_config_path=branch_file)
assert "error" not in status, status
assert status.get("branch") == "desktop-choice", status
assert status.get("targetSha") == head, status
assert status["behind"] == 0
assert requests == [MAIN_CHANNEL, branch_path]
assert json.loads(branch_file.read_text())["branch"] == "desktop-choice"
def test_running_revision_is_not_applied_to_an_explicit_target(installation, monkeypatch):
from hermes_cli.source_check import check_for_updates
root, linked, home, base, head, responses, requests, git = installation