hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 30 Packages Projects Releases Wiki Activity

test(kanban): exercise acceptance races through real run lifecycle

Browse Source
This commit is contained in:
Teknium
2026-09-07 02:48:10 -07:00
parent dccdf31732
commit 285829c3fe
2 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
evals/kanban_pr_acceptance_live.py
View File

@@ -46,14 +46,15 @@ with tempfile.TemporaryDirectory(prefix='hermes-pr-live-') as home:
reports.append({'case': outcome, 'accepted': accepted, 'status': kb.get_task(conn, tid).status, 'receipt': receipt})
for outcome in (('success', 'failure') if 'completion_contract' in inspect.signature(kb.create_task).parameters else ()):
tid = kb.create_task(conn, title='Concurrent ownership', completion_contract='acme/repo')
conn.execute('UPDATE tasks SET current_run_id=101 WHERE id=?', (tid,))
conn.commit()
owner = kb.claim_task(conn, tid)
run_id = owner.current_run_id
def reclaim():
with connect() as other:
other.execute('UPDATE tasks SET current_run_id=102 WHERE id=?', (tid,))
other.commit()
kb.block_task(other, tid, reason='Reassigned during acceptance')
kb.unblock_task(other, tid)
state['replacement'] = kb.claim_task(other, tid).current_run_id
state.update(conclusion=outcome, race=reclaim)
accepted = kb.complete_task(conn, tid, expected_run_id=101, metadata={'published_pr': 'https://github.com/acme/repo/pull/7'})
accepted = kb.complete_task(conn, tid, expected_run_id=run_id, metadata={'published_pr': 'https://github.com/acme/repo/pull/7'})
reports.append({'case': 'CAS-'+outcome, 'accepted': accepted, 'run_id': kb.get_task(conn, tid).current_run_id,
'receipts': conn.execute("SELECT count(*) FROM task_events WHERE task_id=? AND kind='pr_acceptance'", (tid,)).fetchone()[0]})
del state['race']

22
tests/hermes_cli/test_kanban_pr_acceptance.py
View File

@@ -28,14 +28,14 @@ def github(tmp_path, monkeypatch):
value = [[]]
elif "/check-runs" in self.path:
run = {"id": 42, "name": "required", "head_sha": sha,
"app": {"id": 1}, "status": "completed", "conclusion": state["conclusion"],
"app": {"id": 1}, "status": "in_progress" if state["conclusion"] == "pending" else "completed", "conclusion": state["conclusion"],
"html_url": "https://github.com/acme/repo/actions/runs/42"}
if state.get("stale"):
run["head_sha"] = "b" * 40
runs = [] if state.get("missing") else [run]
value = [{"total_count": 101, "check_runs": [
value = [{"total_count": 100 + len(runs), "check_runs": [
{**run, "id": 1000 + i, "name": "optional", "conclusion": "skipped"}
for i in range(100)]}, {"total_count": 101, "check_runs": runs}]
for i in range(100)]}, {"total_count": 100 + len(runs), "check_runs": runs}]
if state.get("race"):
state["race"]()
if state.get("head_change"):
@@ -78,7 +78,7 @@ def github(tmp_path, monkeypatch):
@pytest.mark.linux_only
def test_pr_completion_requires_current_required_evidence(github):
with connect() as conn:
for conclusion in ("failure", "cancelled", "timed_out", "action_required", "neutral", "skipped", None, "success"):
for conclusion in ("failure", "pending", "cancelled", "timed_out", "action_required", "neutral", "skipped", None, "success"):
github.update(conclusion=conclusion, head="a" * 40)
tid = kb.create_task(conn, title="Publish", completion_contract="acme/repo")
ok = kb.complete_task(conn, tid, metadata={"published_pr": "https://github.com/acme/repo/pull/7"})
@@ -114,16 +114,18 @@ def test_acceptance_receipts_and_terminal_write_share_run_ownership(github):
with connect() as conn:
for conclusion in ("success", "failure"):
tid = kb.create_task(conn, title="race", completion_contract="acme/repo")
conn.execute("UPDATE tasks SET current_run_id=101 WHERE id=?", (tid,))
conn.commit()
owner = kb.claim_task(conn, tid)
run_id = owner.current_run_id
def reclaim():
with connect() as rival:
rival.execute("UPDATE tasks SET current_run_id=102 WHERE id=?", (tid,))
rival.commit()
assert kb.block_task(rival, tid, reason="Reassigned during acceptance")
assert kb.unblock_task(rival, tid)
github["replacement"] = kb.claim_task(rival, tid).current_run_id
github.update(conclusion=conclusion, race=reclaim)
assert not kb.complete_task(conn, tid, expected_run_id=101,
assert not kb.complete_task(conn, tid, expected_run_id=run_id,
metadata={"published_pr": "https://github.com/acme/repo/pull/7"})
assert kb.get_task(conn, tid).current_run_id == 102
assert kb.get_task(conn, tid).current_run_id == github["replacement"]
assert github["replacement"] != run_id
assert kb.get_task(conn, tid).status != "done"
assert conn.execute("SELECT count(*) FROM task_events WHERE task_id=? AND kind='pr_acceptance'", (tid,)).fetchone()[0] == 0
github.pop("race")