hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 33 Packages Projects Releases Wiki Activity

test(constants): gate the two symlink tests with require_symlinks, not pytest.skip

Browse Source 
The two get_hermes_dir symlink tests wrapped symlink_to() in a
try/except -> pytest.skip(). tests/conftest.py already has the
require_symlinks marker for exactly this (probes symlink support once,
skips at setup); using it keeps the test bodies straight-line and the
skip reason uniform with the sibling tests in this file.
This commit is contained in:
teknium1
2026-09-12 07:08:10 -07:00
committed by Teknium
parent 683e8d382b
commit 26f610e77a
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/test_hermes_constants.py
View File

@@ -749,6 +749,7 @@ class TestGetHermesDir:
@pytest.mark.require_symlinks
def test_dangling_legacy_symlink_returns_new(self, tmp_path, monkeypatch):
"""A dangling legacy symlink must NOT shadow populated new-layout data.
@@ -760,16 +761,14 @@ class TestGetHermesDir:
"""
self._set_home(tmp_path, monkeypatch)
legacy = tmp_path / "pairing"
try:
legacy.symlink_to(tmp_path / "does-not-exist")
except (OSError, NotImplementedError) as exc:
pytest.skip(f"Symlink not supported on this platform/permission: {exc}")
legacy.symlink_to(tmp_path / "does-not-exist")
new = tmp_path / "platforms" / "pairing"
new.mkdir(parents=True)
(new / "discord-approved.json").write_text("[]")
result = get_hermes_dir("platforms/pairing", "pairing")
assert result == new
@pytest.mark.require_symlinks
def test_symlink_to_populated_dir_returns_legacy(self, tmp_path, monkeypatch):
"""A legacy symlink pointing at a populated directory is honoured."""
self._set_home(tmp_path, monkeypatch)
@@ -777,10 +776,7 @@ class TestGetHermesDir:
real.mkdir()
(real / "cached.png").write_bytes(b"x")
legacy = tmp_path / "image_cache"
try:
legacy.symlink_to(real)
except (OSError, NotImplementedError) as exc:
pytest.skip(f"Symlink not supported on this platform/permission: {exc}")
legacy.symlink_to(real)
result = get_hermes_dir("cache/images", "image_cache")
assert result == legacy