Files
hermes-agent/apps
Brooklyn Nicholson ffc74885c5 fix(desktop): type window-menu against Electron's MenuItemConstructorOptions
Main's menu template is MenuItemConstructorOptions[], so the local
WindowMenuItem interface (role?: string, submenu: Array<{role: string}>)
no longer satisfies it and tsc rejects the pushed item. Derive the type
from MenuItemConstructorOptions instead: role comes from Electron's own
role union (which includes 'windowMenu'), and submenu items are full
MenuItemConstructorOptions so the click-only Close item fits.

Also carry main's #65457 behaviour into the extracted template: the
non-macOS Close item is click-only with registerAccelerator: false, not
role: 'close' (which would claim CommandOrControl+W before the
before-input-event run that routes terminal-focused Ctrl+W to word
erase). Test updated to match.

Co-authored-by: victorjmilagres <294917029+victorjmilagres@users.noreply.github.com>
2026-10-01 02:29:32 -05:00
..