Files
hermes-agent/tests/agent/test_plugin_context_engine_init.py
teknium1 d10bb2ab6f test: make tests/ mirror the source tree; drop issue numbers from filenames
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.

Parallel directories for one source package, folded into the mirror:
  tests/acp        -> tests/acp_adapter   (its __init__/conftest move with it)
  tests/cli        -> tests/hermes_cli    (prompt_toolkit fixture merged into
                                           hermes_cli/conftest.py)
  tests/run_agent  -> tests/agent         (backoff fixture becomes
                                           agent/conftest.py)
  tests/relay      -> tests/gateway/relay
  tests/state      -> tests/hermes_state

246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.

Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.

Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).

Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
2026-09-13 09:18:02 -07:00

213 lines
7.6 KiB
Python

"""Tests that plugin context engines get update_model() called during init.
Regression test for #9071 — plugin engines were never initialized with
context_length, causing the CLI status bar to show 'ctx --'.
"""
from unittest.mock import MagicMock, patch
from agent.context_engine import ContextEngine
class _StubEngine(ContextEngine):
"""Minimal concrete context engine for testing."""
@property
def name(self) -> str:
return "stub"
def update_from_response(self, usage):
pass
def should_compress(self, prompt_tokens=None):
return False
def compress(self, messages, current_tokens=None):
return messages
class _ToolEngine(_StubEngine):
def get_tool_schemas(self):
return [
{
"name": "stub_recover",
"description": "Recover context from the stub engine.",
"parameters": {"type": "object", "properties": {}},
}
]
def test_plugin_engine_gets_context_length_on_init():
"""Plugin context engine should have context_length set during AIAgent init."""
engine = _StubEngine()
assert engine.context_length == 0 # ABC default before fix
cfg = {"context": {"engine": "stub"}, "agent": {}}
with (
patch("hermes_cli.config.load_config", return_value=cfg), patch("hermes_cli.config.load_config_readonly", return_value=cfg),
patch("plugins.context_engine.load_context_engine", return_value=engine),
patch("agent.model_metadata.get_model_context_length", return_value=204_800),
patch("model_tools.get_tool_definitions", return_value=[]),
patch("model_tools.check_toolset_requirements", return_value={}),
patch("agent.process_bootstrap.OpenAI"),
):
from run_agent import AIAgent
agent = AIAgent(
api_key="test-key-1234567890",
base_url="https://openrouter.ai/api/v1",
quiet_mode=True,
skip_context_files=True,
skip_memory=True,
)
assert agent.context_compressor is engine
assert engine.context_length == 204_800
assert engine.threshold_tokens == int(204_800 * engine.threshold_percent)
def test_active_context_engine_tools_survive_explicit_platform_toolsets():
"""LCM-style recovery tools must survive saved `hermes tools` lists."""
engine = _ToolEngine()
cfg = {
"context": {"engine": "stub"},
"platform_toolsets": {"cli": ["web", "terminal"]},
"agent": {},
}
from hermes_cli.tools_config import _get_platform_tools
enabled_toolsets = _get_platform_tools(cfg, "cli", include_default_mcp_servers=False)
assert "context_engine" in enabled_toolsets
with (
patch("hermes_cli.config.load_config", return_value=cfg), patch("hermes_cli.config.load_config_readonly", return_value=cfg),
patch("plugins.context_engine.load_context_engine", return_value=engine),
patch("agent.model_metadata.get_model_context_length", return_value=204_800),
patch("model_tools.get_tool_definitions", return_value=[]),
patch("model_tools.check_toolset_requirements", return_value={}),
patch("agent.process_bootstrap.OpenAI"),
):
from run_agent import AIAgent
agent = AIAgent(
api_key="test-key-1234567890",
base_url="https://openrouter.ai/api/v1",
enabled_toolsets=sorted(enabled_toolsets),
quiet_mode=True,
skip_context_files=True,
skip_memory=True,
)
assert "stub_recover" in getattr(agent, "valid_tool_names", set())
assert "stub_recover" in {
tool.get("function", {}).get("name")
for tool in getattr(agent, "tools", [])
}
def test_plugin_engine_update_model_args():
"""Verify update_model() receives model, context_length, base_url, api_key, provider."""
engine = _StubEngine()
engine.update_model = MagicMock()
cfg = {"context": {"engine": "stub"}, "agent": {}}
with (
patch("hermes_cli.config.load_config", return_value=cfg), patch("hermes_cli.config.load_config_readonly", return_value=cfg),
patch("plugins.context_engine.load_context_engine", return_value=engine),
patch("agent.model_metadata.get_model_context_length", return_value=131_072),
patch("model_tools.get_tool_definitions", return_value=[]),
patch("model_tools.check_toolset_requirements", return_value={}),
patch("agent.process_bootstrap.OpenAI"),
):
from run_agent import AIAgent
agent = AIAgent(
model="openrouter/auto",
api_key="test-key-1234567890",
base_url="https://openrouter.ai/api/v1",
quiet_mode=True,
skip_context_files=True,
skip_memory=True,
)
engine.update_model.assert_called_once()
kw = engine.update_model.call_args.kwargs
assert kw["context_length"] == 131_072
assert "model" in kw
assert "provider" in kw
assert "api_mode" in kw
def _codex_agent_kwargs():
return dict(
model="gpt-5.5",
provider="openai-codex",
api_key="test-key-1234567890",
base_url="https://chatgpt.com/backend-api/codex",
quiet_mode=True,
skip_context_files=True,
skip_memory=True,
)
def test_codex_gpt55_autoraise_suppressed_for_plugin_engine():
"""Codex gpt-5.5 autoraise must not fire when an external engine is active.
Regression test for #44439 — the host compression threshold (including
the 0.85 autoraise) never reaches a plugin context engine, so the notice
announced a change that did not apply.
"""
engine = _StubEngine()
cfg = {
"context": {"engine": "stub"},
"compression": {"enabled": True, "threshold": 0.75},
"agent": {},
}
with (
patch("hermes_cli.config.load_config", return_value=cfg), patch("hermes_cli.config.load_config_readonly", return_value=cfg),
patch("plugins.context_engine.load_context_engine", return_value=engine),
patch("agent.model_metadata.get_model_context_length", return_value=272_000),
patch("model_tools.get_tool_definitions", return_value=[]),
patch("model_tools.check_toolset_requirements", return_value={}),
patch("agent.process_bootstrap.OpenAI"),
):
from run_agent import AIAgent
agent = AIAgent(**_codex_agent_kwargs())
assert agent.context_compressor is engine
assert agent._compression_threshold_autoraised is None
assert agent._compression_warning is None
# The engine's own policy is untouched by the host threshold.
assert engine.threshold_percent == 0.75
def test_codex_gpt55_autoraise_still_applies_to_builtin_compressor():
"""Stock built-in compressor keeps the 50% → 85% Codex gpt-5.5 autoraise."""
cfg = {
"compression": {"enabled": True, "threshold": 0.50},
"agent": {},
}
with (
patch("hermes_cli.config.load_config", return_value=cfg), patch("hermes_cli.config.load_config_readonly", return_value=cfg),
patch("agent.context_compressor.get_model_context_length", return_value=272_000),
patch("model_tools.get_tool_definitions", return_value=[]),
patch("model_tools.check_toolset_requirements", return_value={}),
patch("agent.process_bootstrap.OpenAI"),
):
from run_agent import AIAgent
agent = AIAgent(**_codex_agent_kwargs())
assert agent._compression_threshold_autoraised == {"model": "gpt-5.5", "from": 0.50, "to": 0.85}
assert agent.context_compressor.threshold_percent == 0.85
# Gateway parity: the notice is stashed for replay on turn 1.
assert agent._compression_warning and "85%" in agent._compression_warning