hermes-agent/tests/agent/test_memory_user_id.py

"""Tests for per-user memory scoping via user_id threading.

Verifies that gateway user_id flows from AIAgent -> MemoryManager -> plugins,
so each gateway user gets their own memory bucket instead of sharing a static one.
"""

import json
from unittest.mock import MagicMock, patch

from agent.memory_provider import MemoryProvider
from agent.memory_manager import MemoryManager

# ---------------------------------------------------------------------------
# Concrete test provider that records init kwargs
# ---------------------------------------------------------------------------

class RecordingProvider(MemoryProvider):
    """Minimal provider that records what initialize() receives."""

    def __init__(self, name="recording"):
        self._name = name
        self._init_kwargs = {}
        self._init_session_id = None

    @property
    def name(self) -> str:
        return self._name

    def is_available(self) -> bool:
        return True

    def initialize(self, session_id: str, **kwargs) -> None:
        self._init_session_id = session_id
        self._init_kwargs = dict(kwargs)

    def system_prompt_block(self) -> str:
        return ""

    def prefetch(self, query: str, *, session_id: str = "") -> str:
        return ""

    def sync_turn(self, user_content, assistant_content, *, session_id=""):
        pass

    def get_tool_schemas(self):
        return []

    def handle_tool_call(self, tool_name, args, **kwargs):
        return json.dumps({})

    def shutdown(self):
        pass

# ---------------------------------------------------------------------------
# MemoryManager user_id threading tests
# ---------------------------------------------------------------------------

class TestMemoryManagerUserIdThreading:
    """Verify user_id reaches providers via initialize_all."""

    def test_no_user_id_when_cli(self):
        """CLI sessions should not have user_id in kwargs."""
        mgr = MemoryManager()
        p = RecordingProvider()
        mgr.add_provider(p)

        mgr.initialize_all(
            session_id="sess-456",
            platform="cli",
        )

        assert "user_id" not in p._init_kwargs
        assert p._init_kwargs.get("platform") == "cli"

    def test_multiple_providers_all_receive_user_id(self):
        mgr = MemoryManager()
        # Use one provider named "builtin" (always accepted) and one external
        p1 = RecordingProvider("builtin")
        p2 = RecordingProvider("external")
        mgr.add_provider(p1)
        mgr.add_provider(p2)

        mgr.initialize_all(
            session_id="sess-multi",
            platform="slack",
            user_id="slack_U12345",
        )

        assert p1._init_kwargs.get("user_id") == "slack_U12345"
        assert p1._init_kwargs.get("platform") == "slack"
        assert p2._init_kwargs.get("user_id") == "slack_U12345"
        assert p2._init_kwargs.get("platform") == "slack"

    def test_session_title_provenance_and_cwd_reach_provider(self, tmp_path):
        from run_agent import AIAgent

        provider = RecordingProvider()
        session_db = MagicMock()
        session_db.get_session_title.return_value = "Generated title"
        session_db.get_session_title_source.return_value = "llm"

        with patch(
            "model_tools.get_tool_definitions",
            return_value=[],
        ), patch(
            "model_tools.check_toolset_requirements",
            return_value={},
        ), patch(
            "agent.process_bootstrap.OpenAI",
        ), patch(
            "hermes_cli.config.load_config_readonly",
            return_value={"memory": {"provider": "recording"}},
        ), patch(
            "plugins.memory.load_memory_provider",
            return_value=provider,
        ):
            agent = AIAgent(
                api_key="test-key-1234567890",
                base_url="https://openrouter.ai/api/v1",
                quiet_mode=True,
                skip_context_files=True,
                platform="telegram",
                session_id="session-with-title",
                session_db=session_db,
                gateway_session_key="agent:main:telegram:dm:42",
                cwd=str(tmp_path),
            )

        assert provider._init_kwargs["session_title"] == "Generated title"
        assert provider._init_kwargs["session_title_source"] == "llm"
        assert (
            provider._init_kwargs["gateway_session_key"]
            == "agent:main:telegram:dm:42"
        )
        assert provider._init_kwargs["cwd"] == str(tmp_path)
        agent.close()

# ---------------------------------------------------------------------------
# Mem0 provider user_id tests
# ---------------------------------------------------------------------------

class TestMem0UserIdScoping:
    """Verify Mem0 plugin uses gateway user_id when provided."""

    def test_no_user_id_falls_back_to_config(self):
        """Without user_id in kwargs, should use config default."""
        from plugins.memory.mem0 import Mem0MemoryProvider

        provider = Mem0MemoryProvider()
        with patch("plugins.memory.mem0._load_config", return_value={
            "api_key": "test-key",
            "user_id": "custom-default",
            "agent_id": "hermes",
            "rerank": True,
        }):
            provider.initialize(session_id="test-sess")

        assert provider._user_id == "custom-default"

    def test_different_users_get_different_ids(self):
        """Two providers initialized with different user_ids should be scoped differently."""
        from plugins.memory.mem0 import Mem0MemoryProvider

        p1 = Mem0MemoryProvider()
        p2 = Mem0MemoryProvider()

        with patch("plugins.memory.mem0._load_config", return_value={
            "api_key": "test-key",
            "user_id": "hermes-user",
            "agent_id": "hermes",
            "rerank": True,
        }):
            p1.initialize(session_id="sess-1", user_id="alice_123")
            p2.initialize(session_id="sess-2", user_id="bob_456")

        assert p1._user_id == "alice_123"
        assert p2._user_id == "bob_456"
        assert p1._user_id != p2._user_id

# ---------------------------------------------------------------------------
# Honcho provider user_id tests
# ---------------------------------------------------------------------------

class TestHonchoUserIdScoping:
    """Verify Honcho plugin keeps runtime user scoping separate from config peer_name."""

    def test_gateway_user_id_is_passed_as_runtime_peer(self):
        """Gateway user_id should scope Honcho sessions without mutating config peer_name."""
        from plugins.memory.honcho import HonchoMemoryProvider

        provider = HonchoMemoryProvider()

        mock_cfg = MagicMock()
        mock_cfg.enabled = True
        mock_cfg.api_key = "test-key"
        mock_cfg.base_url = None
        mock_cfg.peer_name = "static-user"
        mock_cfg.recall_mode = "context"
        mock_cfg.context_tokens = None
        mock_cfg.raw = {}
        mock_cfg.dialectic_depth = 1
        mock_cfg.dialectic_depth_levels = None
        mock_cfg.init_on_session_start = False
        mock_cfg.ai_peer = "hermes"
        mock_cfg.resolve_session_name.return_value = "test-sess"
        mock_cfg.session_strategy = "shared"

        with patch(
            "plugins.memory.honcho.client.HonchoClientConfig.from_global_config",
            return_value=mock_cfg,
        ), patch(
            "plugins.memory.honcho.client.get_honcho_client",
            return_value=MagicMock(),
        ), patch(
            "plugins.memory.honcho.session.HonchoSessionManager",
        ) as mock_manager_cls:
            mock_manager = MagicMock()
            mock_manager.get_or_create.return_value = MagicMock(messages=[])
            mock_manager_cls.return_value = mock_manager
            provider.initialize(
                session_id="test-sess",
                user_id="discord_user_789",
                platform="discord",
            )

        assert mock_cfg.peer_name == "static-user"
        assert mock_manager_cls.call_args.kwargs["runtime_user_peer_name"] == "discord_user_789"

    def test_session_manager_prefers_runtime_user_id_over_config_peer_name(self):
        """Session manager should isolate gateway users even when config peer_name is static."""
        from plugins.memory.honcho.session import HonchoSessionManager

        mock_cfg = MagicMock()
        mock_cfg.peer_name = "static-user"
        mock_cfg.ai_peer = "hermes"
        mock_cfg.write_frequency = "sync"
        mock_cfg.dialectic_reasoning_level = "low"
        mock_cfg.dialectic_dynamic = True
        mock_cfg.dialectic_max_chars = 600
        mock_cfg.observation_mode = "directional"
        mock_cfg.user_observe_me = True
        mock_cfg.user_observe_others = True
        mock_cfg.ai_observe_me = True
        mock_cfg.ai_observe_others = True

        manager = HonchoSessionManager(
            honcho=MagicMock(),
            config=mock_cfg,
            runtime_user_peer_name="discord_user_789",
        )

        with patch.object(manager, "_get_or_create_peer", return_value=MagicMock()), patch.object(
            manager,
            "_get_or_create_honcho_session",
            return_value=(MagicMock(), [], None),
        ):
            session = manager.get_or_create("discord:channel-1")

        assert session.user_peer_id == "discord_user_789"

    def test_no_user_id_preserves_config_peer_name(self):
        """Without user_id, the config peer_name should be preserved."""
        from plugins.memory.honcho import HonchoMemoryProvider

        provider = HonchoMemoryProvider()

        mock_cfg = MagicMock()
        mock_cfg.enabled = True
        mock_cfg.api_key = "test-key"
        mock_cfg.base_url = None
        mock_cfg.peer_name = "my-custom-peer"
        mock_cfg.recall_mode = "tools"

        with patch(
            "plugins.memory.honcho.client.HonchoClientConfig.from_global_config",
            return_value=mock_cfg,
        ):
            provider.initialize(
                session_id="test-sess",
                platform="cli",
            )

        # peer_name should not have been overridden
        assert mock_cfg.peer_name == "my-custom-peer"

# ---------------------------------------------------------------------------
# AIAgent user_id propagation test
# ---------------------------------------------------------------------------