d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
55 lines
1.7 KiB
Python
55 lines
1.7 KiB
Python
"""Regression test: temp file cleanup when materializing data URLs for vision.
|
|
|
|
`_materialize_data_url_for_vision` creates a `NamedTemporaryFile(delete=False)`
|
|
so the path can be handed to vision backends. If `base64.b64decode` raises on
|
|
a corrupt/unsupported data URL the temp file would otherwise persist forever
|
|
on disk, leaking once per failed call.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import base64
|
|
import os
|
|
import tempfile
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _list_anthropic_tmpfiles(tmpdir: str) -> list[str]:
|
|
return [
|
|
name for name in os.listdir(tmpdir)
|
|
if name.startswith("anthropic_image_")
|
|
]
|
|
|
|
|
|
def test_b64decode_failure_does_not_leak_tempfile(monkeypatch, tmp_path):
|
|
monkeypatch.setattr(tempfile, "tempdir", str(tmp_path))
|
|
|
|
bad_url = "data:image/png;base64,!!!not-valid-base64!!!"
|
|
with pytest.raises(Exception):
|
|
AIAgent._materialize_data_url_for_vision(bad_url)
|
|
|
|
leftovers = _list_anthropic_tmpfiles(str(tmp_path))
|
|
assert leftovers == [], f"leaked temp files after decode failure: {leftovers}"
|
|
|
|
|
|
def test_successful_decode_returns_path_to_existing_file(monkeypatch, tmp_path):
|
|
monkeypatch.setattr(tempfile, "tempdir", str(tmp_path))
|
|
|
|
payload = b"\x89PNG\r\n\x1a\n" + b"\x00" * 16 # a few bytes is enough
|
|
encoded = base64.b64encode(payload).decode("ascii")
|
|
good_url = f"data:image/png;base64,{encoded}"
|
|
|
|
path_str, path_obj = AIAgent._materialize_data_url_for_vision(good_url)
|
|
|
|
assert isinstance(path_obj, Path)
|
|
assert path_obj.exists()
|
|
assert path_obj.read_bytes() == payload
|
|
assert path_str == str(path_obj)
|
|
# Caller is responsible for cleanup; mimic that here so the test leaves
|
|
# no artifacts behind.
|
|
path_obj.unlink()
|