d63e380324
Every PLUGIN-COMPAT __getattr__ now calls hermes_cli.plugin_compat.warn_once(facade, name, target) before
resolving, emitting a HermesPluginCompatWarning (FutureWarning) once per process per name: old path, new
path, removal target. Importing a facade for its live API stays silent; only resolving a moved name warns.
COMPAT_MANIFEST.md documents the warning and how to silence it during migration.
Verified the runtime never routes through a pointer: every entry point (run_agent, cli, hermes_cli.main,
gateway.run, tui_gateway.server, web_server, model_tools + tool discovery, hermes_state, cron.scheduler,
browser_tool, mcp_tool, kanban, auth) imports clean and `hermes doctor` runs end to end with the warning
promoted to an error.
Also restores the check_compat_pointers CI step to .github/workflows/lint.yml, which a0be177aac dropped
when the compat layer was regenerated (the lint script itself was present; the workflow step was not).
hermes_cli/plugin_compat.py, tests/test_plugin_compat_warning.py and the two-line insert per facade are
part of the compat layer and go away with it.
72 lines
2.6 KiB
Python
72 lines
2.6 KiB
Python
#!/usr/bin/env python3
|
|
"""Read which OS window sits directly underneath the Hermes desktop window.
|
|
|
|
The window list lives with the OS, so this round-trips through the gateway's
|
|
blocking-prompt bridge like `read_terminal`: ``window.read.request`` -> the renderer's
|
|
main process (native window enumeration) -> ``window.read.respond``.
|
|
"""
|
|
|
|
from typing import Callable, Optional
|
|
|
|
from tools.read_terminal_tool import read_pane
|
|
from tools.registry import registry
|
|
|
|
|
|
def read_window_below_tool(callback: Optional[Callable] = None) -> str:
|
|
"""Return the window underneath the Hermes window as a JSON string."""
|
|
return read_pane(callback, (), (
|
|
"read_window_below is only available in the Hermes desktop app.",
|
|
"",
|
|
"Failed to read the window below: ",
|
|
"Could not determine the window underneath (the desktop app did "
|
|
"not answer, or window enumeration is unavailable on this system).",
|
|
))
|
|
|
|
|
|
READ_WINDOW_BELOW_SCHEMA = {
|
|
"name": "read_window_below",
|
|
"description": (
|
|
"Identify the app window directly behind the Hermes desktop window "
|
|
"(what the user is working in). JSON: {window: {app, title, bounds, "
|
|
"id}, frontmost, platform}. title may be empty when the OS withholds "
|
|
"it (noted in `note`); where windows cannot be enumerated at all, "
|
|
"{error, platform} says what would fix it — relay that instead of "
|
|
"retrying. Metadata only; never captures pixels."
|
|
),
|
|
"parameters": {
|
|
"type": "object", "properties": {}
|
|
},
|
|
}
|
|
|
|
|
|
registry.register(
|
|
name="read_window_below",
|
|
toolset="desktop_ui",
|
|
schema=READ_WINDOW_BELOW_SCHEMA,
|
|
handler=lambda args, **kw: read_window_below_tool(callback=kw.get("callback")),
|
|
emoji="🪟",
|
|
)
|
|
|
|
|
|
# ---- BEGIN PLUGIN-COMPAT (revert-scheduled; see COMPAT_MANIFEST.md) ----
|
|
# Names external plugins imported from this module before the Sep 2026 decomposition.
|
|
# Internal code MUST NOT use these (scripts/check_compat_pointers.py fails CI if it does).
|
|
# The whole block is removed by reverting the commit that added it.
|
|
import json # noqa: F401,E402
|
|
|
|
|
|
_PLUGIN_COMPAT_LAZY = {
|
|
'tool_error': ('tools.registry', 'tool_error'),
|
|
}
|
|
|
|
|
|
def __getattr__(name): # PEP 562 — lazy so no import cycles
|
|
target = _PLUGIN_COMPAT_LAZY.get(name)
|
|
if target is None:
|
|
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
|
|
import importlib
|
|
from hermes_cli.plugin_compat import warn_once
|
|
warn_once(__name__, name, *target)
|
|
return getattr(importlib.import_module(target[0]), target[1])
|
|
# ---- END PLUGIN-COMPAT ----
|