39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
"""Unit tests for gateway.whatsapp_identity.to_whatsapp_jid.
|
|
|
|
``to_whatsapp_jid`` is the outbound inverse of
|
|
``normalize_whatsapp_identifier``: it builds the bridge-safe JID a send
|
|
must use. Baileys' ``jidDecode`` crashes on a bare phone number (#8637),
|
|
so every outbound target must be rewritten to ``<digits>@s.whatsapp.net``
|
|
before it reaches the bridge.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from gateway.whatsapp_identity import to_whatsapp_jid
|
|
|
|
|
|
class TestToWhatsappJid:
|
|
@pytest.mark.parametrize(
|
|
"raw,expected",
|
|
[
|
|
# bare phone numbers → user JID
|
|
("+50766715226", "50766715226@s.whatsapp.net"),
|
|
("50766715226", "50766715226@s.whatsapp.net"),
|
|
# human-formatted phone numbers get stripped to digits
|
|
("+1 (555) 123-4567", "15551234567@s.whatsapp.net"),
|
|
("+1.555.123.4567", "15551234567@s.whatsapp.net"),
|
|
],
|
|
)
|
|
def test_bare_phone_becomes_user_jid(self, raw, expected):
|
|
assert to_whatsapp_jid(raw) == expected
|
|
|
|
@pytest.mark.parametrize(
|
|
"jid",
|
|
[
|
|
"50766715226@s.whatsapp.net", # already a user JID
|
|
"123456789-987654321@g.us", # group JID
|
|
"130631430344750@lid", # linked identity
|
|
"status@broadcast", # broadcast pseudo-chat
|
|
"123@newsletter", # channel/newsletter
|
|
],
|
|
)
|
|
def test_fully_qualified_jid_passes_through(self, jid):
|
|
assert to_whatsapp_jid(jid) == jid
|
|
|
|
|