39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
81 lines
2.2 KiB
Python
81 lines
2.2 KiB
Python
"""Tests for Teams pipeline runtime wiring into the gateway."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from types import ModuleType
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.run import GatewayRunner
|
|
from plugins.teams_pipeline.runtime import (
|
|
bind_gateway_runtime,
|
|
build_pipeline_runtime,
|
|
build_pipeline_runtime_config,
|
|
)
|
|
|
|
|
|
def test_gateway_runner_skips_wiring_without_msgraph_adapter(monkeypatch):
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner.adapters = {Platform.TELEGRAM: MagicMock()}
|
|
runner._teams_pipeline_runtime_error = None
|
|
|
|
called = False
|
|
|
|
def _bind(_gateway_runner):
|
|
nonlocal called
|
|
called = True
|
|
return True
|
|
|
|
monkeypatch.setattr("plugins.teams_pipeline.runtime.bind_gateway_runtime", _bind)
|
|
monkeypatch.setattr(
|
|
"gateway.run._load_gateway_config",
|
|
lambda: {"plugins": {"enabled": ["teams_pipeline"]}},
|
|
)
|
|
|
|
GatewayRunner._wire_teams_pipeline_runtime(runner)
|
|
|
|
assert called is False
|
|
|
|
|
|
def test_build_pipeline_runtime_skips_sender_when_adapter_layer_is_unavailable(monkeypatch):
|
|
gateway = SimpleNamespace(
|
|
config=SimpleNamespace(
|
|
platforms={
|
|
Platform("teams"): PlatformConfig(
|
|
enabled=True,
|
|
extra={
|
|
"delivery_mode": "graph",
|
|
"team_id": "team-1",
|
|
"channel_id": "channel-1",
|
|
},
|
|
),
|
|
}
|
|
)
|
|
)
|
|
|
|
monkeypatch.setattr(
|
|
"plugins.teams_pipeline.runtime.build_graph_client",
|
|
lambda: object(),
|
|
)
|
|
monkeypatch.setattr(
|
|
"plugins.teams_pipeline.runtime.resolve_teams_pipeline_store_path",
|
|
lambda: "/tmp/teams-pipeline-store.json",
|
|
)
|
|
monkeypatch.setattr(
|
|
"plugins.teams_pipeline.runtime.TeamsPipelineStore",
|
|
lambda path: {"path": path},
|
|
)
|
|
monkeypatch.setitem(
|
|
sys.modules,
|
|
"plugins.platforms.teams.adapter",
|
|
ModuleType("plugins.platforms.teams.adapter"),
|
|
)
|
|
|
|
runtime = build_pipeline_runtime(gateway)
|
|
|
|
assert runtime.teams_sender is None
|
|
|
|
|