Files
hermes-agent/tests/gateway/test_slack_model_picker.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

732 lines
27 KiB
Python

"""Tests for the Slack Block Kit interactive model picker.
Mirrors test_slack_approval_buttons.py (harness) and
test_discord_model_picker.py (semantics) for the ``send_model_picker``
override and the ``hermes_model_provider`` / ``hermes_model_model`` /
``hermes_model_back`` / ``hermes_model_cancel`` action dispatch.
"""
import sys
from pathlib import Path
from unittest.mock import AsyncMock, MagicMock
import pytest
# ---------------------------------------------------------------------------
# Ensure the repo root is importable
# ---------------------------------------------------------------------------
_repo = str(Path(__file__).resolve().parents[2])
if _repo not in sys.path:
sys.path.insert(0, _repo)
# ---------------------------------------------------------------------------
# Minimal Slack SDK mock so SlackAdapter can be imported (mirrors
# test_slack_approval_buttons.py)
# ---------------------------------------------------------------------------
def _ensure_slack_mock():
if "slack_bolt" in sys.modules:
return
slack_bolt = MagicMock()
slack_bolt.async_app.AsyncApp = MagicMock
sys.modules["slack_bolt"] = slack_bolt
sys.modules["slack_bolt.async_app"] = slack_bolt.async_app
handler_mod = MagicMock()
handler_mod.AsyncSocketModeHandler = MagicMock
sys.modules["slack_bolt.adapter"] = MagicMock()
sys.modules["slack_bolt.adapter.socket_mode"] = MagicMock()
sys.modules["slack_bolt.adapter.socket_mode.async_handler"] = handler_mod
sdk_mod = MagicMock()
sdk_mod.web = MagicMock()
sdk_mod.web.async_client = MagicMock()
sdk_mod.web.async_client.AsyncWebClient = MagicMock
sys.modules["slack_sdk"] = sdk_mod
sys.modules["slack_sdk.web"] = sdk_mod.web
sys.modules["slack_sdk.web.async_client"] = sdk_mod.web.async_client
_ensure_slack_mock()
from plugins.platforms.slack.adapter import SlackAdapter
from gateway.config import PlatformConfig, Platform
def _make_adapter():
"""Create a SlackAdapter instance with mocked internals."""
config = PlatformConfig(enabled=True, token="«redacted:xox…»")
adapter = SlackAdapter(config)
adapter._app = MagicMock()
adapter._bot_user_id = "U_BOT"
adapter._team_clients = {"T1": AsyncMock()}
adapter._team_bot_user_ids = {"T1": "U_BOT"}
adapter._channel_team = {"C1": "T1"}
return adapter
class _AuthRunner:
def __init__(self, auth_fn=None):
self._auth_fn = auth_fn or (lambda _source: True)
self.seen_sources = []
async def handle(self, event):
return None
def _is_user_authorized(self, source):
self.seen_sources.append(source)
return self._auth_fn(source)
def _attach_auth_runner(adapter, auth_fn=None):
runner = _AuthRunner(auth_fn=auth_fn)
adapter.set_message_handler(runner.handle)
return runner
_PROVIDERS = [
{
"slug": "openrouter",
"name": "OpenRouter",
"models": ["anthropic/claude-sonnet-4", "openai/gpt-5"],
"total_models": 2,
"is_current": True,
},
{
"slug": "anthropic",
"name": "Anthropic",
"models": ["claude-sonnet-4-20250514"],
"total_models": 1,
"is_current": False,
},
]
def _interaction_body(msg_ts="1234.5678", channel_id="C1", user="alice", uid="U_ALICE"):
return {
"message": {"ts": msg_ts, "blocks": []},
"channel": {"id": channel_id},
"user": {"name": user, "id": uid},
"team_id": "T1",
}
# ===========================================================================
# send_model_picker — Block Kit structure
# ===========================================================================
class TestSlackModelPickerSend:
"""Test send_model_picker sends the provider-stage Block Kit."""
@pytest.mark.asyncio
async def test_sends_provider_dropdown(self):
adapter = _make_adapter()
mock_client = adapter._team_clients["T1"]
mock_client.chat_postMessage = AsyncMock(return_value={"ts": "1234.5678"})
async def on_selected(chat_id, model_id, provider_slug):
return "Switched!"
result = await adapter.send_model_picker(
chat_id="C1",
providers=_PROVIDERS,
current_model="anthropic/claude-sonnet-4",
current_provider="openrouter",
session_key="test-session",
on_model_selected=on_selected,
)
assert result.success is True
assert result.message_id == "1234.5678"
kwargs = mock_client.chat_postMessage.call_args[1]
assert "blocks" in kwargs
blocks = kwargs["blocks"]
assert len(blocks) == 2
assert blocks[0]["type"] == "section"
assert "anthropic/claude-sonnet-4" in blocks[0]["text"]["text"]
assert blocks[1]["type"] == "actions"
elements = blocks[1]["elements"]
assert len(elements) == 2
assert elements[0]["type"] == "static_select"
assert elements[0]["action_id"] == "hermes_model_provider"
assert len(elements[0]["options"]) == 2
# Option values are list indices, never raw slugs (75-char value cap)
assert elements[0]["options"][0]["value"] == "0"
assert elements[0]["options"][1]["value"] == "1"
assert "OpenRouter" in elements[0]["options"][0]["text"]["text"]
assert elements[1]["type"] == "button"
assert elements[1]["action_id"] == "hermes_model_cancel"
# State should be stashed for the callback (no metadata → bare ts key)
assert "1234.5678" in adapter._model_picker_state
state = adapter._model_picker_state["1234.5678"]
assert state["stage"] == "provider"
assert state["session_key"] == "test-session"
@pytest.mark.asyncio
async def test_sends_in_thread(self):
adapter = _make_adapter()
mock_client = adapter._team_clients["T1"]
mock_client.chat_postMessage = AsyncMock(return_value={"ts": "1.2"})
async def on_selected(chat_id, model_id, provider_slug):
return "ok"
await adapter.send_model_picker(
chat_id="C1",
providers=_PROVIDERS,
current_model="m",
current_provider="openrouter",
session_key="s",
on_model_selected=on_selected,
metadata={"thread_id": "9999.0000"},
)
kwargs = mock_client.chat_postMessage.call_args[1]
assert kwargs.get("thread_ts") == "9999.0000"
@pytest.mark.asyncio
async def test_not_connected(self):
adapter = _make_adapter()
adapter._app = None
result = await adapter.send_model_picker(
chat_id="C1", providers=[], current_model="", current_provider="",
session_key="s", on_model_selected=AsyncMock(),
)
assert result.success is False
@pytest.mark.asyncio
async def test_no_providers(self):
adapter = _make_adapter()
result = await adapter.send_model_picker(
chat_id="C1", providers=[], current_model="", current_provider="",
session_key="s", on_model_selected=AsyncMock(),
)
assert result.success is False
@pytest.mark.asyncio
async def test_long_custom_slug_never_reaches_option_value(self):
"""A custom provider slug >75 chars would fail the whole picker post
with invalid_blocks if it were used as an option value; index values
keep every value well under the cap."""
adapter = _make_adapter()
mock_client = adapter._team_clients["T1"]
mock_client.chat_postMessage = AsyncMock(return_value={"ts": "1234.5678"})
long_slug = "custom-" + "x" * 100
providers = _PROVIDERS + [
{"slug": long_slug, "name": "CustomCo", "models": ["m1"], "total_models": 1},
]
result = await adapter.send_model_picker(
chat_id="C1", providers=providers, current_model="m",
current_provider="openrouter", session_key="s",
on_model_selected=AsyncMock(),
)
assert result.success is True
options = (
mock_client.chat_postMessage.call_args[1]["blocks"][1]["elements"][0]["options"]
)
assert len(options) == 3
assert all(len(o["value"]) <= 75 for o in options)
assert [o["value"] for o in options] == ["0", "1", "2"]
assert "CustomCo" in options[2]["text"]["text"]
@pytest.mark.asyncio
async def test_provider_stage_hint_when_over_option_cap(self):
adapter = _make_adapter()
mock_client = adapter._team_clients["T1"]
mock_client.chat_postMessage = AsyncMock(return_value={"ts": "1234.5678"})
providers = [
{"slug": f"p{i}", "name": f"P{i}", "models": [f"m{i}"], "total_models": 1}
for i in range(120)
]
result = await adapter.send_model_picker(
chat_id="C1", providers=providers, current_model="m",
current_provider="p0", session_key="s", on_model_selected=AsyncMock(),
)
assert result.success is True
blocks = mock_client.chat_postMessage.call_args[1]["blocks"]
options = blocks[1]["elements"][0]["options"]
assert len(options) == 100 # static_select caps at 100 options
assert "20 more available" in blocks[0]["text"]["text"]
# ===========================================================================
# _handle_model_picker_action — drill-down dispatch
# ===========================================================================
class TestSlackModelPickerAction:
"""Test the model picker action handler."""
def _seed_state(self, adapter, msg_ts="1234.5678", on_selected=None, stage="provider",
selected_provider="", bare_ts=False, providers=None):
# bare_ts=True mirrors the metadata-poor send path: no team id, so the
# state is keyed by the raw ts instead of the (team_id, ts) marker.
key = msg_ts if bare_ts else ("T1", msg_ts)
adapter._model_picker_state[key] = {
"providers": _PROVIDERS if providers is None else providers,
"session_key": "s1",
"chat_id": "C1",
"team_id": "" if bare_ts else "T1",
"current_model": "old",
"current_provider": "openrouter",
"on_model_selected": on_selected or AsyncMock(return_value="ok"),
"stage": stage,
"selected_provider_slug": selected_provider,
}
@pytest.mark.asyncio
async def test_provider_select_shows_models(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter)
ack = AsyncMock()
action = {
"action_id": "hermes_model_provider",
"selected_option": {"value": "0"}, # index 0 = openrouter
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
mock_client.chat_update.assert_called_once()
update_kwargs = mock_client.chat_update.call_args[1]
elements = update_kwargs["blocks"][1]["elements"]
assert elements[0]["action_id"] == "hermes_model_model"
# Two models for openrouter, values are indices
assert [o["value"] for o in elements[0]["options"]] == ["0", "1"]
# Back + Cancel buttons present
assert elements[1]["action_id"] == "hermes_model_back"
assert elements[2]["action_id"] == "hermes_model_cancel"
state = adapter._model_picker_state[("T1", "1234.5678")]
assert state["stage"] == "model"
assert state["selected_provider_slug"] == "openrouter"
@pytest.mark.asyncio
async def test_bare_ts_state_resolves_on_team_scoped_click(self):
"""A team-scoped click must find state stored under the bare ts.
The metadata-poor send path keys state by raw ts (no team id); the
click event still carries one. The handler's dual-key lookup must not
swallow that legitimate interaction.
"""
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter, bare_ts=True)
ack = AsyncMock()
action = {
"action_id": "hermes_model_provider",
"selected_option": {"value": "0"}, # index 0 = openrouter
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
mock_client.chat_update.assert_called_once()
state = adapter._model_picker_state["1234.5678"]
assert state["stage"] == "model"
assert state["selected_provider_slug"] == "openrouter"
@pytest.mark.asyncio
async def test_provider_select_with_no_models_dismisses_picker(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(
adapter,
providers=[{
"slug": "empty", "name": "EmptyCo", "models": [],
"total_models": 0, "is_current": False,
}],
)
ack = AsyncMock()
action = {
"action_id": "hermes_model_provider",
"selected_option": {"value": "0"}, # the single seeded provider
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
mock_client.chat_update.assert_called_once()
assert "No models available" in mock_client.chat_update.call_args[1]["text"]
assert ("T1", "1234.5678") not in adapter._model_picker_state
@pytest.mark.asyncio
async def test_model_select_calls_callback(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
events = []
async def on_selected(chat_id, model_id, provider_slug):
events.append((chat_id, model_id, provider_slug))
return "✅ Switched to claude-sonnet-4"
self._seed_state(
adapter, stage="model", selected_provider="openrouter", on_selected=on_selected
)
ack = AsyncMock()
action = {
"action_id": "hermes_model_model",
"selected_option": {"value": "0"}, # index 0 = anthropic/claude-sonnet-4
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
assert events == [("C1", "anthropic/claude-sonnet-4", "openrouter")]
# State cleaned up
assert ("T1", "1234.5678") not in adapter._model_picker_state
# chat_update called twice: "Switching..." then the confirmation
assert mock_client.chat_update.call_count == 2
last_update = mock_client.chat_update.call_args_list[-1][1]
assert "⚙ Model Switched" in last_update["text"]
assert "Switched to claude-sonnet-4" in last_update["text"]
@pytest.mark.asyncio
async def test_model_select_callback_error_is_reported(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
async def on_selected(chat_id, model_id, provider_slug):
raise RuntimeError("boom")
self._seed_state(
adapter, stage="model", selected_provider="openrouter", on_selected=on_selected
)
ack = AsyncMock()
action = {"action_id": "hermes_model_model", "selected_option": {"value": "1"}}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
last_update = mock_client.chat_update.call_args_list[-1][1]
assert "failed" in last_update["text"].lower()
@pytest.mark.asyncio
async def test_model_select_gateway_error_return_uses_failure_header(self):
"""The gateway's error-prefixed return (in-place swap rollback,
#50163) must get the failed header too — both failure shapes.
"""
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
async def on_selected(chat_id, model_id, provider_slug):
return f"Error: Model switch to {model_id} failed (boom); staying on old."
self._seed_state(
adapter, stage="model", selected_provider="openrouter", on_selected=on_selected
)
ack = AsyncMock()
action = {"action_id": "hermes_model_model", "selected_option": {"value": "0"}}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
last_update = mock_client.chat_update.call_args_list[-1][1]
assert last_update["text"].startswith("⚙ Model Switch Failed")
assert "staying on old" in last_update["text"]
@pytest.mark.asyncio
async def test_model_select_invalid_index_expires_picker(self):
"""An unresolvable option value means message↔state desync.
The picker can no longer resolve, so it dies visibly (expired
notice) instead of leaving a dead control.
"""
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
on_selected = AsyncMock()
self._seed_state(
adapter, stage="model", selected_provider="openrouter", on_selected=on_selected
)
ack = AsyncMock()
action = {
"action_id": "hermes_model_model",
"selected_option": {"value": "bogus"},
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
on_selected.assert_not_called()
mock_client.chat_update.assert_called_once()
assert "expired" in mock_client.chat_update.call_args[1]["text"].lower()
assert ("T1", "1234.5678") not in adapter._model_picker_state
@pytest.mark.asyncio
async def test_model_select_out_of_range_index_expires_picker(self):
"""Out-of-range and negative indices must not resolve (or wrap)."""
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
on_selected = AsyncMock()
self._seed_state(
adapter, stage="model", selected_provider="openrouter", on_selected=on_selected
)
for token in ("2", "-1"):
ack = AsyncMock()
action = {
"action_id": "hermes_model_model",
"selected_option": {"value": token},
}
# Re-seed: the first miss pops the entry.
if ("T1", "1234.5678") not in adapter._model_picker_state:
self._seed_state(
adapter, stage="model", selected_provider="openrouter",
on_selected=on_selected,
)
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
on_selected.assert_not_called()
assert "expired" in mock_client.chat_update.call_args[1]["text"].lower()
@pytest.mark.asyncio
async def test_provider_select_invalid_index_expires_picker(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter)
ack = AsyncMock()
action = {
"action_id": "hermes_model_provider",
"selected_option": {"value": "7"}, # only 2 providers seeded
}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
mock_client.chat_update.assert_called_once()
assert "expired" in mock_client.chat_update.call_args[1]["text"].lower()
assert ("T1", "1234.5678") not in adapter._model_picker_state
@pytest.mark.asyncio
async def test_cancel_clears_state(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter)
ack = AsyncMock()
action = {"action_id": "hermes_model_cancel", "value": "cancel"}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
ack.assert_called_once()
assert ("T1", "1234.5678") not in adapter._model_picker_state
mock_client.chat_update.assert_called_once()
assert "cancelled" in mock_client.chat_update.call_args[1]["text"].lower()
@pytest.mark.asyncio
async def test_back_returns_to_provider(self):
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter, stage="model", selected_provider="openrouter")
ack = AsyncMock()
action = {"action_id": "hermes_model_back", "value": "openrouter"}
await adapter._handle_model_picker_action(ack, _interaction_body(), action)
mock_client.chat_update.assert_called_once()
update_kwargs = mock_client.chat_update.call_args[1]
elements = update_kwargs["blocks"][1]["elements"]
assert elements[0]["action_id"] == "hermes_model_provider"
state = adapter._model_picker_state[("T1", "1234.5678")]
assert state["stage"] == "provider"
assert state["selected_provider_slug"] == ""
@pytest.mark.asyncio
async def test_state_not_found_shows_expiry(self):
"""A click with missing picker state must visibly kill the control.
The dict is the picker's only state (no gateway-side registry), so a
gateway restart or aged-out entry would otherwise leave a
live-looking dropdown that silently swallows clicks.
"""
adapter = _make_adapter()
_attach_auth_runner(adapter)
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
ack = AsyncMock()
action = {"action_id": "hermes_model_provider", "selected_option": {"value": "0"}}
await adapter._handle_model_picker_action(
ack, _interaction_body(msg_ts="nonexistent"), action
)
ack.assert_called_once()
mock_client.chat_update.assert_called_once()
assert "expired" in mock_client.chat_update.call_args[1]["text"].lower()
@pytest.mark.asyncio
async def test_unauthorized_user_blocked(self, monkeypatch):
adapter = _make_adapter()
_attach_auth_runner(adapter, auth_fn=lambda s: s.user_id == "U_OWNER")
mock_client = adapter._team_clients["T1"]
mock_client.chat_update = AsyncMock()
self._seed_state(adapter)
ack = AsyncMock()
action = {"action_id": "hermes_model_provider", "selected_option": {"value": "openrouter"}}
await adapter._handle_model_picker_action(
ack, _interaction_body(user="intruder", uid="U_BAD"), action
)
ack.assert_called_once()
mock_client.chat_update.assert_not_called()
# State unchanged
assert adapter._model_picker_state[("T1", "1234.5678")]["stage"] == "provider"
# ===========================================================================
# Gateway integration — routes /model to the picker
# ===========================================================================
class TestSlackModelPickerGatewayIntegration:
"""Verify _handle_model_command detects the Slack picker capability."""
@pytest.mark.asyncio
async def test_bare_model_triggers_picker(self, tmp_path, monkeypatch):
import types
import hermes_yaml as yaml
from gateway.platforms.event import MessageEvent, MessageType
from gateway.session import SessionSource
captured = {}
class SlackPickerAdapter:
async def send_model_picker(self, *, on_model_selected, **kwargs):
captured["called"] = True
captured["callback"] = on_model_selected
return types.SimpleNamespace(success=True)
adapter = SlackPickerAdapter()
from gateway.run import GatewayRunner
runner = object.__new__(GatewayRunner)
runner.adapters = {Platform.SLACK: adapter}
runner._voice_mode = {}
runner._session_model_overrides = {}
runner._running_agents = {}
hermes_home = tmp_path / ".hermes"
hermes_home.mkdir()
cfg_path = hermes_home / "config.yaml"
cfg_path.write_text(
yaml.safe_dump({
"model": {"default": "old-model", "provider": "openrouter"},
"providers": {},
}),
encoding="utf-8",
)
import gateway.run as gateway_run
monkeypatch.setattr(gateway_run, "_hermes_home", hermes_home)
monkeypatch.setattr("agent.models_dev.fetch_models_dev", lambda: {})
monkeypatch.setattr(
"hermes_cli.model_switch_providers.list_picker_providers",
lambda **kw: [{"slug": "openrouter", "name": "OR", "models": ["m1"], "total_models": 1}],
)
event = MessageEvent(
text="/model",
message_type=MessageType.TEXT,
source=SessionSource(
platform=Platform.SLACK, chat_id="C1", chat_type="group", user_id="U1"
),
)
result = await runner._handle_model_command(event)
assert result is None
assert captured.get("called") is True
@pytest.mark.asyncio
async def test_text_fallback_when_no_picker(self, tmp_path, monkeypatch):
import hermes_yaml as yaml
from gateway.platforms.event import MessageEvent, MessageType
from gateway.session import SessionSource
class SlackNoPickerAdapter:
pass # no send_model_picker
adapter = SlackNoPickerAdapter()
from gateway.run import GatewayRunner
runner = object.__new__(GatewayRunner)
runner.adapters = {Platform.SLACK: adapter}
runner._voice_mode = {}
runner._session_model_overrides = {}
runner._running_agents = {}
hermes_home = tmp_path / ".hermes"
hermes_home.mkdir()
cfg_path = hermes_home / "config.yaml"
cfg_path.write_text(
yaml.safe_dump({
"model": {"default": "old-model", "provider": "openrouter"},
"providers": {},
}),
encoding="utf-8",
)
import gateway.run as gateway_run
monkeypatch.setattr(gateway_run, "_hermes_home", hermes_home)
monkeypatch.setattr("agent.models_dev.fetch_models_dev", lambda: {})
monkeypatch.setattr(
"hermes_cli.model_switch_providers.list_authenticated_providers",
lambda **kw: [],
)
event = MessageEvent(
text="/model",
message_type=MessageType.TEXT,
source=SessionSource(
platform=Platform.SLACK, chat_id="C1", chat_type="group", user_id="U1"
),
)
result = await runner._handle_model_command(event)
assert isinstance(result, str)
assert "old-model" in result