39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
72 lines
2.5 KiB
Python
72 lines
2.5 KiB
Python
"""Regression tests for the TUI gateway's ``session.list`` handler.
|
|
|
|
History:
|
|
- The original implementation hardcoded an allow-list of known gateway
|
|
sources (``tui, cli, telegram, discord, slack, ...``). New or unlisted
|
|
sources (``acp``, ``webhook``, user-defined ``HERMES_SESSION_SOURCE``
|
|
values, newly-added platforms) were silently dropped from the resume
|
|
picker — users reported "lots of sessions are missing from browse
|
|
but exist in .hermes/sessions."
|
|
- The handler now deny-lists only the internal/noisy source ``tool``
|
|
(sub-agent runs) and surfaces every other source to the picker.
|
|
- The default ``limit`` raised from 20 to 200 so longer-running users
|
|
can scroll through their history without hitting an artificial cap.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from tui_gateway import server
|
|
|
|
|
|
class _StubDB:
|
|
def __init__(self, rows):
|
|
self.rows = rows
|
|
self.calls: list[dict] = []
|
|
|
|
def list_sessions_rich(self, **kwargs):
|
|
self.calls.append(kwargs)
|
|
return list(self.rows)
|
|
|
|
|
|
def _call(limit: int | None = None):
|
|
params: dict = {}
|
|
if limit is not None:
|
|
params["limit"] = limit
|
|
return server.handle_request({
|
|
"id": "1",
|
|
"method": "session.list",
|
|
"params": params,
|
|
})
|
|
|
|
|
|
def test_session_list_surfaces_all_user_facing_sources(monkeypatch):
|
|
"""acp / webhook / custom sources should all appear; only ``tool`` is hidden."""
|
|
rows = [
|
|
{"id": "tui-1", "source": "tui", "started_at": 9},
|
|
{"id": "tool-1", "source": "tool", "started_at": 8},
|
|
{"id": "tg-1", "source": "telegram", "started_at": 7},
|
|
{"id": "acp-1", "source": "acp", "started_at": 6},
|
|
{"id": "cli-1", "source": "cli", "started_at": 5},
|
|
{"id": "webhook-1", "source": "webhook", "started_at": 4},
|
|
{"id": "custom-1", "source": "my-custom-source", "started_at": 3},
|
|
]
|
|
db = _StubDB(rows)
|
|
monkeypatch.setattr(server, "_get_db", lambda: db)
|
|
|
|
resp = _call(limit=10)
|
|
ids = [s["id"] for s in resp["result"]["sessions"]]
|
|
|
|
# Every human-facing source — including previously-hidden acp, webhook,
|
|
# and custom sources — must surface in the picker now.
|
|
assert "tg-1" in ids
|
|
assert "tui-1" in ids
|
|
assert "cli-1" in ids
|
|
assert "acp-1" in ids, "acp sessions were being hidden by the old allow-list"
|
|
assert "webhook-1" in ids, "webhook sessions were being hidden by the old allow-list"
|
|
assert "custom-1" in ids, "custom HERMES_SESSION_SOURCE values were being hidden"
|
|
|
|
# Only internal sub-agent runs stay hidden.
|
|
assert "tool-1" not in ids
|
|
|
|
|