39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
37 lines
1.1 KiB
Python
37 lines
1.1 KiB
Python
"""Tests for Discord channel_skill_bindings auto-skill resolution."""
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_adapter():
|
|
"""Create a minimal DiscordAdapter with mocked config."""
|
|
from plugins.platforms.discord.adapter import DiscordAdapter
|
|
adapter = object.__new__(DiscordAdapter)
|
|
adapter.config = MagicMock()
|
|
adapter.config.extra = {}
|
|
return adapter
|
|
|
|
|
|
class TestResolveChannelSkills:
|
|
|
|
|
|
def test_match_by_parent_id(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "200", "skills": ["forum-skill"]},
|
|
]
|
|
}
|
|
# channel_id doesn't match, but parent_id does (forum thread)
|
|
assert adapter._resolve_channel_skills("999", parent_id="200") == ["forum-skill"]
|
|
|
|
def test_no_match_returns_none(self):
|
|
adapter = _make_adapter()
|
|
adapter.config.extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "100", "skills": ["skill-a"]},
|
|
]
|
|
}
|
|
assert adapter._resolve_channel_skills("999") is None
|
|
|
|
|