cd3de040ab
Squash of the 54 commits on victor-kyriazakos:feat/user-channel-warning-suppression (PR #112302, head f45c640e55) so the contributor's authorship survives a rebase-merge; the commits interleave with a cron delivery-ledger rework that the salvage removes in follow-up commits, so per-commit cherry-picks were not practical. Adds display.suppress_warning_notifications (global + per-platform, default false): one resolver (gateway/warning_notifications.py), BasePlatformAdapter.emit_warning / emit_media_warning / warning_text, a notification_category classification carried through wakes, queues and persistence, and render/present boundaries for CLI/TUI.
61 lines
3.0 KiB
Python
61 lines
3.0 KiB
Python
"""Suppressed automatic diagnostics retain failed jobs without invented delivery receipts."""
|
|
import pytest
|
|
|
|
from cron import executions, incidents, jobs, scheduler
|
|
from gateway.config import GatewayConfig, Platform, PlatformConfig
|
|
|
|
|
|
@pytest.mark.parametrize("mode", ["failure", "crash", "success"])
|
|
@pytest.mark.parametrize("suppress", [False, True])
|
|
@pytest.mark.parametrize("external_worker", [False, True])
|
|
def test_real_run_ledger_and_incident_match_actual_presentation(tmp_path, monkeypatch, mode, suppress, external_worker):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
(tmp_path / "config.yaml").write_text(
|
|
f"display: {{suppress_warning_notifications: {str(suppress).lower()}}}\n"
|
|
)
|
|
config = GatewayConfig()
|
|
config.platforms[Platform.TELEGRAM] = PlatformConfig(enabled=True)
|
|
monkeypatch.setattr("gateway.config.load_gateway_config", lambda: config)
|
|
sent = []
|
|
|
|
async def send(platform, pconfig, chat_id, text, **kwargs):
|
|
sent.append(text)
|
|
return {"success": True, "message_id": "receipt"}
|
|
|
|
monkeypatch.setattr("tools.send_message_tool._send_to_platform", send)
|
|
|
|
def run(job, **kwargs):
|
|
if mode == "crash":
|
|
raise RuntimeError("isolated provider failure")
|
|
return (mode == "success", "retained raw output", "required result", None if mode == "success" else "isolated provider failure")
|
|
|
|
monkeypatch.setattr(scheduler, "run_job", run)
|
|
job = jobs.create_job(prompt="fixture only", schedule="every 1h", deliver="telegram:fixture")
|
|
if external_worker:
|
|
from cron import delivery_queue
|
|
execution = executions.create_execution(job["id"], source="fixture")
|
|
job["execution_id"] = execution["id"]
|
|
monkeypatch.setenv("_HERMES_CRON_EXTERNAL_WORKER", execution["id"])
|
|
original_wait = delivery_queue.enqueue_and_wait
|
|
|
|
def drain_before_wait(execution_id, job, content, *, for_failure=False):
|
|
delivery_queue.enqueue(execution_id, job, content, for_failure=for_failure)
|
|
assert scheduler.drain_delivery_queue({}, None) == 1
|
|
return original_wait(execution_id, job, content, for_failure=for_failure)
|
|
|
|
monkeypatch.setattr(delivery_queue, "enqueue_and_wait", drain_before_wait)
|
|
scheduler.run_one_job(job)
|
|
row = executions.latest_execution(job["id"])
|
|
expected_suppression = suppress and mode != "success"
|
|
assert len(sent) == (0 if expected_suppression else 1)
|
|
assert row["delivery_outcome"] == ("suppressed" if expected_suppression else "delivered")
|
|
saved = jobs.get_job(job["id"])
|
|
assert saved["last_status"] == ("ok" if mode == "success" else "error")
|
|
if mode != "success":
|
|
assert "isolated provider failure" in saved["last_error"]
|
|
incident = next(i for i in incidents.list_incidents() if i["job_id"] == job["id"])
|
|
assert incident["state"] == ("detected" if suppress else "alerted")
|
|
if mode != "crash":
|
|
outputs = list((tmp_path / "cron" / "output" / job["id"]).glob("*.md"))
|
|
assert outputs and "retained raw output" in outputs[0].read_text()
|