284dbaf537
Activation reaches plugin discovery before the application dependencies exist. Give PM its own locked Python project and runtime so it can install or repair the application without importing that dependency tree. Keep PM outside the application workspace. A shared uv workspace resolves the application graph and cannot provide this isolation. Route mutations through an isolated worker and preserve transaction callbacks, cancellation, custom package registrations, and correlated receipts. Use the same runtime builder for source installs and packaged payloads. Keep offline wheelhouse support in that builder. Nix builds the independent PM lock as a separate derivation. Refuse lazy-disabled bootstrap before installing tools or dependencies. Move first-party YAML readers and writers to ruamel. Keep the application lock's transitive PyYAML requirements for third-party packages. Verification: - Focused canonical Python suite: 177 passed, 1 host-gated skip. - Electron backend probes: 12 passed. Electron typecheck passed. - Both uv locks, scoped lint, Bash syntax, and whitespace checks passed. - Cold activation, corrupt-app repair, offline staging, and relocation ran. - Built and exercised the Nix PM runtime and standalone YAML merge script. Six broader caller test files retain the same 24 failing test IDs as an archive of HEAD. The existing real-home guard blocks those tests before they can exercise the affected paths. No full-suite pass is claimed. Native Windows signing and full Bionic package execution remain unverified.
104 lines
3.0 KiB
Python
104 lines
3.0 KiB
Python
"""Tests for pet slash-command config helpers."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from agent.pet import store
|
|
from agent.pet.constants import FRAME_H, FRAME_W
|
|
|
|
|
|
@pytest.fixture
|
|
def boba_installed(tmp_path, monkeypatch):
|
|
from PIL import Image
|
|
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
|
|
sheet = Image.new("RGBA", (FRAME_W * 8, FRAME_H * 9), (0, 0, 0, 0))
|
|
pet_dir = store.pets_dir() / "boba"
|
|
pet_dir.mkdir(parents=True, exist_ok=True)
|
|
sheet.save(pet_dir / "spritesheet.webp")
|
|
(pet_dir / "pet.json").write_text(
|
|
'{"id":"boba","displayName":"Boba","description":"d","spritesheetPath":"spritesheet.webp"}'
|
|
)
|
|
return home
|
|
|
|
|
|
def _write_config(home, *, enabled: bool, slug: str = "") -> None:
|
|
import hermes_yaml as yaml
|
|
|
|
cfg = {"display": {"pet": {"enabled": enabled, "slug": slug, "scale": 0.33}}}
|
|
(home / "config.yaml").write_text(yaml.safe_dump(cfg), encoding="utf-8")
|
|
|
|
|
|
|
|
|
|
def test_toggle_pet_display_errors_with_no_installed_pets(tmp_path, monkeypatch):
|
|
from hermes_cli.pets import toggle_pet_display
|
|
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
_write_config(home, enabled=False, slug="")
|
|
|
|
enabled, name, err = toggle_pet_display()
|
|
|
|
assert enabled is False
|
|
assert name is None
|
|
assert err is not None
|
|
|
|
|
|
def test_pets_cli_quoted_false_disables_and_toggle_enables(tmp_path, monkeypatch):
|
|
"""Quoted `display.pet.enabled: "false"` must read as disabled.
|
|
|
|
bool('false') is True — before the is_truthy_value fix, _has_active_pet
|
|
reported an active pet and /pet toggle DISABLED instead of enabling.
|
|
"""
|
|
import hermes_yaml as yaml
|
|
|
|
from hermes_cli.pets import _has_active_pet, toggle_pet_display
|
|
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
(home / "config.yaml").write_text(
|
|
yaml.safe_dump(
|
|
{"display": {"pet": {"enabled": "false", "slug": "", "scale": 0.33}}}
|
|
),
|
|
encoding="utf-8",
|
|
)
|
|
|
|
assert _has_active_pet() is False
|
|
# Toggle must take the ENABLE branch (reaching the "no pets installed"
|
|
# error), not the disable branch (which would return err=None).
|
|
enabled, name, err = toggle_pet_display()
|
|
assert err is not None and "no pets installed" in err
|
|
assert enabled is False
|
|
assert name is None
|
|
|
|
|
|
@pytest.fixture
|
|
def empty_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
return home
|
|
|
|
|
|
def test_set_pet_scale_writes_clamped_value(empty_home):
|
|
from agent.pet.constants import MAX_SCALE, MIN_SCALE
|
|
from hermes_cli.pets import _pet_config, set_pet_scale
|
|
|
|
applied, err = set_pet_scale("0.5")
|
|
assert err is None
|
|
assert applied == 0.5
|
|
assert _pet_config()["scale"] == 0.5
|
|
|
|
# Out-of-range values clamp to the bounds rather than erroring.
|
|
assert set_pet_scale(99) == (MAX_SCALE, None)
|
|
assert set_pet_scale(0) == (MIN_SCALE, None)
|
|
|
|
|