a5bd246865
* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
82 lines
2.8 KiB
Python
82 lines
2.8 KiB
Python
#!/usr/bin/env python3
|
|
"""Read the in-app terminal pane in the Hermes desktop GUI.
|
|
|
|
The buffer lives in the desktop renderer (xterm.js), so this round-trips through the
|
|
gateway's blocking-prompt bridge (as `clarify` does): tui_gateway emits
|
|
``terminal.read.request``, the renderer answers ``terminal.read.respond``. Lives in the
|
|
``desktop_ui`` toolset, enabled only for desktop-sourced sessions.
|
|
"""
|
|
|
|
from typing import Callable, Optional
|
|
|
|
from tools.desktop_ui import passthrough_json
|
|
from tools.registry import registry, tool_error
|
|
|
|
|
|
def read_pane(callback: Optional[Callable], window, errors: tuple) -> str:
|
|
"""Shared body of the read_terminal / read_preview / read_window bridges. ``window`` is
|
|
``((key, value, floor), ...)`` (None omitted, else int-coerced and floored); ``errors`` =
|
|
(not_desktop, not_integers, fail_prefix, empty)."""
|
|
if callback is None:
|
|
return tool_error(errors[0])
|
|
try:
|
|
kwargs = {key: max(floor, int(val)) for key, val, floor in window if val is not None}
|
|
except (TypeError, ValueError):
|
|
return tool_error(errors[1])
|
|
try:
|
|
raw = callback(**kwargs)
|
|
except Exception as exc:
|
|
return tool_error(f"{errors[2]}{exc}")
|
|
if not raw:
|
|
return tool_error(errors[3])
|
|
return passthrough_json(raw)
|
|
|
|
|
|
def read_terminal_tool(
|
|
start_line: Optional[int] = None,
|
|
count: Optional[int] = None,
|
|
callback: Optional[Callable] = None,
|
|
) -> str:
|
|
"""Return the in-app terminal's contents (+ line metadata) as a JSON string."""
|
|
return read_pane(callback, (("start", start_line, 0), ("count", count, 1)), (
|
|
"read_terminal is only available in the Hermes desktop app.",
|
|
"start_line and count must be integers.",
|
|
"Failed to read terminal: ",
|
|
"No in-app terminal is open, or the read timed out.",
|
|
))
|
|
|
|
|
|
READ_TERMINAL_SCHEMA = {
|
|
"name": "read_terminal",
|
|
"description": (
|
|
"Read the in-app terminal pane beside this chat. No args = visible "
|
|
"screen + total_lines; page scrollback with start_line (0 = oldest) "
|
|
"+ count. JSON: {total_lines, start, end, viewport_rows, cursor_row, "
|
|
"text}."
|
|
),
|
|
"parameters": {
|
|
"type": "object",
|
|
"properties": {
|
|
"start_line": {
|
|
"type": "integer",
|
|
"description": "0-indexed first line (0 = oldest). Omit for the visible screen.",
|
|
},
|
|
"count": {
|
|
"type": "integer",
|
|
"description": "Lines to read from start_line. Defaults to the visible row count.",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
|
|
registry.register(
|
|
name="read_terminal",
|
|
toolset="desktop_ui",
|
|
schema=READ_TERMINAL_SCHEMA,
|
|
handler=lambda args, **kw: read_terminal_tool(
|
|
start_line=args.get("start_line"), count=args.get("count"), callback=kw.get("callback")
|
|
),
|
|
emoji="🖥️",
|
|
)
|