818d781c0b
The file-safety salvage carried five tests and the execute_code salvage four; fold them into the two behaviour contracts per fix: (a) the named-profile scope exempts the root's direct files and the write lands with no prompt; a child env sees the ACTIVE profile's home per turn; (b) negatives hold: a checkout's .hermes/config.yaml stays gated fail-closed, a lookalike profiles/ tree exempts nothing; a dedicated process with no override is untouched. Both red on base. Also compress the _hermes_exempt_homes docstring (WHY only; cite #110630).
60 lines
2.0 KiB
Python
60 lines
2.0 KiB
Python
"""execute_code child env honors the multiplexed per-turn HERMES_HOME override (#110303).
|
|
|
|
Under a multiplexed Desktop/Dashboard connection one server process serves several
|
|
profiles, binding a context-local HERMES_HOME override per turn. ``_build_child_env``
|
|
scrubs the server process's ``os.environ`` — which carries the machine-default
|
|
HERMES_HOME — so without the rewrite below, skill scripts run via ``execute_code``
|
|
silently read/write the wrong profile's directory.
|
|
"""
|
|
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
from hermes_constants import (
|
|
get_hermes_home_override,
|
|
reset_hermes_home_override,
|
|
set_hermes_home_override,
|
|
)
|
|
from tools.code_execution_env import _build_child_env
|
|
|
|
|
|
@pytest.fixture
|
|
def home_override():
|
|
tokens = []
|
|
|
|
def _set(path):
|
|
tokens.append(set_hermes_home_override(path))
|
|
return str(path)
|
|
|
|
yield _set
|
|
for token in reversed(tokens):
|
|
reset_hermes_home_override(token)
|
|
|
|
|
|
def _child_env():
|
|
return _build_child_env(
|
|
rpc_endpoint="sock",
|
|
rpc_token="tok",
|
|
tmpdir="/tmp/hermes-test",
|
|
child_python=sys.executable,
|
|
)
|
|
|
|
|
|
class TestMultiplexedHermesHome:
|
|
def test_override_rewrites_stale_server_default_per_turn(self, monkeypatch, home_override, tmp_path):
|
|
"""The reported bug: a child must see the ACTIVE profile's home, not the server default,
|
|
and sequential turns for different profiles each see their own."""
|
|
monkeypatch.setenv("HERMES_HOME", "/machine/default/.hermes")
|
|
alpha = home_override(tmp_path / "profiles" / "alpha")
|
|
assert _child_env()["HERMES_HOME"] == alpha
|
|
beta = home_override(tmp_path / "profiles" / "beta")
|
|
assert _child_env()["HERMES_HOME"] == beta
|
|
|
|
def test_no_override_leaves_inherited_value_untouched(self, monkeypatch):
|
|
"""Dedicated per-profile processes (no override): zero behavior change."""
|
|
assert get_hermes_home_override() is None
|
|
monkeypatch.setenv("HERMES_HOME", "/machine/default/.hermes")
|
|
|
|
assert _child_env()["HERMES_HOME"] == "/machine/default/.hermes"
|