1e1e5c0fa7
The fallback root when the system temp dir sits inside the operator's Hermes home was PROJECT_ROOT/.pytest_cache, but the default install checks the repo out inside that very home (~/.hermes/hermes-agent, %LOCALAPPDATA%\hermes\hermes-agent), so the relocated basetemp still resolved under the native home and get_default_hermes_root() pointed the sandbox back at the live install. mkdtemp under native.parent is outside the home by construction, and a loud assertion now fails collection if the chosen basetemp ever resolves inside it. Review finding: fallback basetemp under PROJECT_ROOT/.pytest_cache stays inside the native home when the repo lives in ~/.hermes.
68 lines
2.9 KiB
Python
68 lines
2.9 KiB
Python
"""pytest's basetemp must never sit inside the operator's platform-native Hermes home.
|
|
|
|
Every per-test sandbox is ``<basetemp>/.../hermes_test`` and ``get_default_hermes_root()``
|
|
prefers the platform-native home whenever ``HERMES_HOME`` sits *under* it — so a basetemp
|
|
inside the home silently turns the sandbox back into the live install (#111101).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
import hermes_constants
|
|
from tests import conftest as suite_conftest
|
|
|
|
|
|
def _config_with_basetemp(given: Path | None) -> SimpleNamespace:
|
|
return SimpleNamespace(
|
|
_tmp_path_factory=SimpleNamespace(_given_basetemp=given),
|
|
option=SimpleNamespace(basetemp=str(given) if given else None),
|
|
)
|
|
|
|
|
|
def test_basetemp_inside_the_native_home_is_relocated_outside_it(tmp_path, monkeypatch):
|
|
native = tmp_path / "native-home"
|
|
native.mkdir()
|
|
monkeypatch.setattr(hermes_constants, "_get_platform_default_hermes_home", lambda: native)
|
|
config = _config_with_basetemp(native / ".repro")
|
|
|
|
suite_conftest._relocate_basetemp_outside_operator_home(config)
|
|
|
|
relocated = config._tmp_path_factory._given_basetemp
|
|
assert relocated is not None and not relocated.resolve().is_relative_to(native.resolve())
|
|
assert config.option.basetemp == str(relocated)
|
|
# The sandbox derived from it no longer resolves to the native root.
|
|
monkeypatch.setenv("HERMES_HOME", str(relocated / "t0" / "hermes_test"))
|
|
assert hermes_constants.get_default_hermes_root() == relocated / "t0" / "hermes_test"
|
|
|
|
|
|
def test_basetemp_outside_the_native_home_is_left_alone(tmp_path, monkeypatch):
|
|
native = tmp_path / "native-home"
|
|
native.mkdir()
|
|
monkeypatch.setattr(hermes_constants, "_get_platform_default_hermes_home", lambda: native)
|
|
given = tmp_path / "elsewhere"
|
|
config = _config_with_basetemp(given)
|
|
|
|
suite_conftest._relocate_basetemp_outside_operator_home(config)
|
|
|
|
assert config._tmp_path_factory._given_basetemp == given
|
|
assert config.option.basetemp == str(given)
|
|
|
|
|
|
def test_fallback_root_escapes_a_repo_checked_out_inside_the_native_home(tmp_path, monkeypatch):
|
|
# Default install: repo at ~/.hermes/hermes-agent and TEMP under the home (Windows).
|
|
native = tmp_path / "native-home"
|
|
(native / "hermes-agent").mkdir(parents=True)
|
|
monkeypatch.setattr(hermes_constants, "_get_platform_default_hermes_home", lambda: native)
|
|
monkeypatch.setattr(suite_conftest, "PROJECT_ROOT", native / "hermes-agent")
|
|
monkeypatch.setattr(suite_conftest.tempfile, "gettempdir", lambda: str(native / "tmp"))
|
|
monkeypatch.delenv("PYTEST_DEBUG_TEMPROOT", raising=False)
|
|
config = _config_with_basetemp(None)
|
|
|
|
suite_conftest._relocate_basetemp_outside_operator_home(config)
|
|
|
|
relocated = config._tmp_path_factory._given_basetemp
|
|
assert relocated is not None and not relocated.resolve().is_relative_to(native.resolve())
|