`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
65 lines
1.8 KiB
Python
65 lines
1.8 KiB
Python
"""Streamed response lines must be flush-left (no leading indent).
|
|
|
|
The 4-space ``_STREAM_PAD`` indent made every copied line carry leading
|
|
whitespace, so pasting a response out of the terminal produced broken
|
|
text. The pad is now empty and the final-response Rich Panel uses zero
|
|
horizontal padding for the same reason (July 2026).
|
|
"""
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", ".."))
|
|
|
|
|
|
def _strip_ansi(s: str) -> str:
|
|
return re.sub(r"\x1b\[[0-9;]*m", "", s)
|
|
|
|
|
|
@pytest.fixture
|
|
def cli_stub(monkeypatch):
|
|
from cli import HermesCLI
|
|
import cli as climod
|
|
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
cli.show_reasoning = False
|
|
cli.final_response_markdown = "raw"
|
|
cli.show_timestamps = False
|
|
cli._reset_stream_state()
|
|
|
|
emitted = []
|
|
monkeypatch.setattr(climod, "_cprint", lambda s: emitted.append(s))
|
|
monkeypatch.setattr(climod, "_terminal_width_for_streaming", lambda: 74)
|
|
return cli, emitted
|
|
|
|
|
|
def test_stream_pad_is_empty():
|
|
import cli as climod
|
|
|
|
assert climod._STREAM_PAD == ""
|
|
|
|
|
|
def test_streamed_content_lines_have_no_leading_whitespace(cli_stub):
|
|
cli, emitted = cli_stub
|
|
cli._stream_delta("First streamed line of text.\nSecond streamed line.\n")
|
|
cli._flush_stream()
|
|
content = [
|
|
_strip_ansi(e)
|
|
for e in emitted
|
|
if "streamed line" in _strip_ansi(e)
|
|
]
|
|
assert content, "no content lines captured"
|
|
for line in content:
|
|
assert not line.startswith(" "), f"leading whitespace leaked: {line!r}"
|
|
|
|
|
|
def test_intentional_markdown_indentation_is_preserved(cli_stub):
|
|
cli, emitted = cli_stub
|
|
cli._stream_delta("- item\n - nested item\n")
|
|
cli._flush_stream()
|
|
plain = [_strip_ansi(e) for e in emitted]
|
|
assert any(line == "- item" for line in plain)
|
|
assert any(line == " - nested item" for line in plain)
|