2452b882ad
Users who set a sticky profile with `hermes profile use <name>` saw
`[HERMES_HOME fallback] HERMES_HOME is unset but active profile is '<name>'
... Any data this process writes will land in the wrong profile` printed by
EVERY `hermes` invocation (`--version`, `update`, `gateway restart`), even
though the CLI re-homes to that profile a few lines later and nothing lands
in the wrong place.
`main._apply_profile_override` scans argv with `top_level_value_flag_sets()`,
which builds the real parser BEFORE the override sets HERMES_HOME. Since
23036e20a6 the `--no-config` help string spells the config path through
`display_hermes_home()` -> `get_hermes_home()`, and that lookup fires the
one-shot fallback warning for a throwaway help string.
`display_hermes_home()` takes an optional `home`; the parser's `_cfg_path()`
passes `get_process_hermes_home()`, which reads HERMES_HOME without the
warning and, after the override, IS the profile home — so `hermes -p coder
--help` still shows `~/.hermes/profiles/coder/config.yaml`. The genuine
warning (a process that really runs under the wrong home) is untouched.
Fixes #112319
Part of #112839
41 lines
1.5 KiB
Python
41 lines
1.5 KiB
Python
"""The top-level parser's help text must not trip the wrong-profile fallback warning.
|
|
|
|
``main._apply_profile_override`` builds the parser (``top_level_value_flag_sets``) before it
|
|
re-homes the process to the sticky ``active_profile``; a help string that resolved the home through
|
|
``get_hermes_home()`` printed ``[HERMES_HOME fallback] ... wrong profile`` on every ``hermes``
|
|
command for users of ``hermes profile use`` (#112319, also reported in #112839).
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def sticky_profile_home(monkeypatch, tmp_path):
|
|
import hermes_constants
|
|
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.delenv("HERMES_HOME", raising=False)
|
|
root = tmp_path / ".hermes"
|
|
(root / "profiles" / "coder").mkdir(parents=True)
|
|
(root / "active_profile").write_text("coder\n", encoding="utf-8")
|
|
monkeypatch.setattr(hermes_constants, "_profile_fallback_warned", False)
|
|
return root
|
|
|
|
|
|
def test_building_the_parser_before_the_profile_override_stays_silent(sticky_profile_home, capsys):
|
|
from hermes_cli._parser import build_top_level_parser
|
|
|
|
build_top_level_parser()
|
|
|
|
assert "HERMES_HOME fallback" not in capsys.readouterr().err
|
|
|
|
|
|
def test_help_text_names_the_profile_config_once_the_process_is_re_homed(sticky_profile_home, monkeypatch):
|
|
from hermes_cli._parser import _cfg_path
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(sticky_profile_home / "profiles" / "coder"))
|
|
|
|
assert _cfg_path() == "~/.hermes/profiles/coder/config.yaml"
|