d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
70 lines
2.2 KiB
Python
70 lines
2.2 KiB
Python
"""The CLI spells out auto-resume when a delegate_task goes to the background.
|
|
|
|
A top-level ``delegate_task`` returns a handle immediately and runs the subagent
|
|
in the background; the result re-enters the conversation as a fresh turn when it
|
|
finishes. ``_on_tool_complete`` prints a one-line, no-spinner reassurance at
|
|
dispatch so the idle prompt doesn't read as "nothing happened".
|
|
"""
|
|
|
|
import json
|
|
|
|
import cli
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli():
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj._pending_edit_snapshots = {}
|
|
return cli_obj
|
|
|
|
|
|
def _capture(monkeypatch):
|
|
printed: list[str] = []
|
|
monkeypatch.setattr(cli, "_cprint", lambda text: printed.append(text))
|
|
return printed
|
|
|
|
|
|
def test_background_dispatch_prints_resume_notice(monkeypatch):
|
|
cli_obj = _make_cli()
|
|
printed = _capture(monkeypatch)
|
|
|
|
result = json.dumps({"status": "dispatched", "mode": "background", "count": 1})
|
|
cli_obj._on_tool_complete("tc1", "delegate_task", {"goal": "x"}, result)
|
|
|
|
joined = "\n".join(printed)
|
|
assert "resume" in joined.lower()
|
|
assert "it finishes" in joined
|
|
|
|
|
|
def test_background_batch_dispatch_pluralizes(monkeypatch):
|
|
cli_obj = _make_cli()
|
|
printed = _capture(monkeypatch)
|
|
|
|
result = json.dumps({"status": "dispatched", "mode": "background", "count": 3})
|
|
cli_obj._on_tool_complete("tc2", "delegate_task", {"tasks": []}, result)
|
|
|
|
joined = "\n".join(printed)
|
|
assert "3 tasks" in joined
|
|
assert "they finish" in joined
|
|
|
|
|
|
def test_synchronous_delegate_result_prints_no_notice(monkeypatch):
|
|
"""A non-background result (e.g. the stateless sync fallback) must not claim
|
|
a background dispatch."""
|
|
cli_obj = _make_cli()
|
|
printed = _capture(monkeypatch)
|
|
|
|
result = json.dumps({"results": [{"status": "completed", "summary": "done"}]})
|
|
cli_obj._on_tool_complete("tc3", "delegate_task", {"goal": "x"}, result)
|
|
|
|
assert not any("resume" in p.lower() for p in printed)
|
|
|
|
|
|
def test_non_delegate_tool_prints_no_notice(monkeypatch):
|
|
cli_obj = _make_cli()
|
|
printed = _capture(monkeypatch)
|
|
|
|
cli_obj._on_tool_complete("tc4", "read_file", {"path": "a"}, '{"ok": true}')
|
|
|
|
assert not any("resume" in p.lower() for p in printed)
|