d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
85 lines
3.0 KiB
Python
85 lines
3.0 KiB
Python
"""Tests that invalid context_length values in config produce visible warnings."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _build_agent(model_cfg, custom_providers=None, model=None):
|
|
"""Build an AIAgent with the given model config."""
|
|
cfg = {"model": model_cfg}
|
|
if custom_providers is not None:
|
|
cfg["custom_providers"] = custom_providers
|
|
|
|
base_url = model_cfg.get("base_url", "")
|
|
|
|
with (
|
|
patch("hermes_cli.config.load_config", return_value=cfg),
|
|
patch("hermes_cli.config.load_config_readonly", return_value=cfg),
|
|
patch("agent.model_metadata.get_model_context_length", return_value=128_000),
|
|
patch("model_tools.get_tool_definitions", return_value=[]),
|
|
patch("model_tools.check_toolset_requirements", return_value={}),
|
|
patch("agent.process_bootstrap.OpenAI"),
|
|
):
|
|
from run_agent import AIAgent
|
|
|
|
agent = AIAgent(
|
|
model=model or model_cfg.get("default") or "anthropic/claude-opus-4.6",
|
|
api_key="test-key-1234567890",
|
|
base_url=base_url,
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
return agent
|
|
|
|
|
|
def test_valid_integer_context_length_no_warning():
|
|
"""Plain integer context_length should work silently."""
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent({"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"context_length": 256000})
|
|
assert agent._config_context_length == 256000
|
|
# No warning about invalid context_length
|
|
for c in mock_logger.warning.call_args_list:
|
|
assert "Invalid" not in str(c)
|
|
|
|
|
|
def test_string_k_suffix_context_length_warns():
|
|
"""context_length: '256K' should warn the user clearly."""
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent({"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"context_length": "256K"})
|
|
assert agent._config_context_length is None
|
|
# Should have warned
|
|
warning_calls = [c for c in mock_logger.warning.call_args_list
|
|
if "Invalid" in str(c) and "256K" in str(c)]
|
|
assert len(warning_calls) == 1
|
|
assert "plain integer" in str(warning_calls[0])
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_custom_providers_valid_context_length():
|
|
"""Valid integer in custom_providers should work silently."""
|
|
custom_providers = [
|
|
{
|
|
"name": "LiteLLM",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"models": {
|
|
"gpt5.4": {"context_length": 256000}
|
|
},
|
|
}
|
|
]
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent(
|
|
{"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1"},
|
|
custom_providers=custom_providers,
|
|
model="gpt5.4",
|
|
)
|
|
for c in mock_logger.warning.call_args_list:
|
|
assert "Invalid" not in str(c)
|