d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
"""Tests that verify SQL injection mitigations in insights and state modules."""
|
|
|
|
import re
|
|
|
|
from agent.insights import InsightsEngine
|
|
|
|
|
|
def test_session_cols_no_injection_chars():
|
|
"""_SESSION_COLS must not contain SQL injection vectors."""
|
|
cols = InsightsEngine._SESSION_COLS
|
|
assert ";" not in cols
|
|
assert "--" not in cols
|
|
assert "'" not in cols
|
|
assert "DROP" not in cols.upper()
|
|
|
|
|
|
def test_get_sessions_all_query_is_parameterized():
|
|
"""_GET_SESSIONS_ALL must use a ? placeholder for the cutoff value."""
|
|
query = InsightsEngine._GET_SESSIONS_ALL
|
|
assert "?" in query
|
|
assert "started_at >= ?" in query
|
|
# Must not embed any runtime-variable content via brace interpolation
|
|
assert "{" not in query
|
|
|
|
|
|
def test_get_sessions_with_source_query_is_parameterized():
|
|
"""_GET_SESSIONS_WITH_SOURCE must use ? placeholders for both parameters."""
|
|
query = InsightsEngine._GET_SESSIONS_WITH_SOURCE
|
|
assert query.count("?") == 2
|
|
assert "started_at >= ?" in query
|
|
assert "source = ?" in query
|
|
assert "{" not in query
|
|
|
|
|
|
def test_session_col_names_are_safe_identifiers():
|
|
"""Every column name listed in _SESSION_COLS must be a simple identifier."""
|
|
cols = InsightsEngine._SESSION_COLS
|
|
identifiers = [c.strip() for c in cols.split(",")]
|
|
safe_identifier = re.compile(r"^[a-zA-Z_][a-zA-Z0-9_]*$")
|
|
for col in identifiers:
|
|
assert safe_identifier.match(col), (
|
|
f"Column name {col!r} is not a safe SQL identifier"
|
|
)
|