dbf19a6cfa
Follow-up to the salvaged #114480 (@jonameijers) and #114553 (@JoaoMarcos44). A small summarizer can emit both the canonical "## Historical Task Snapshot" and the legacy "## Active Task" heading in one summary (the 4B model in the issue "duplicates the section set"). With count=1 the grounding pass replaced only the first match and left the second as a live-looking, undisclaimed task section. Replace the first task section with the deterministic snapshot and drop every later one. Tests: fold the two contributor test files into one file with two invariants (prompt names the emitted heading; grounding collapses alias + duplicate sections). The original #114480 test asserted the pre-fix prepend behaviour, which #114553 makes false. Co-authored-by: joaomarcos <joaomarcosdias444@gmail.com>
52 lines
2.2 KiB
Python
52 lines
2.2 KiB
Python
"""Task-snapshot heading identity across the summarizer prompt, the template, and grounding.
|
|
|
|
The iterative-update instruction, the emitted template, and ``_ground_historical_task_snapshot`` must agree on
|
|
one heading. A leftover ``## Active Task`` section is not disclaimed by SUMMARY_PREFIX and reads as live work,
|
|
so grounding must replace it (and any duplicate task section) rather than prepend a second one.
|
|
"""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
from agent.context_compressor import ContextCompressor, HISTORICAL_TASK_HEADING
|
|
|
|
_LEGACY_ACTIVE_TASK_HEADING = "## Active Task"
|
|
|
|
|
|
def _headings(text: str) -> list[str]:
|
|
return [line for line in text.splitlines() if line.startswith("## ")]
|
|
|
|
|
|
def test_update_instruction_names_the_emitted_heading():
|
|
"""The prompt built when a previous summary exists (the update path) names HISTORICAL_TASK_HEADING."""
|
|
stub = SimpleNamespace(
|
|
tail_mode="lean",
|
|
_previous_summary="PREVIOUS SUMMARY BODY",
|
|
_bound_summary_input=lambda text: text,
|
|
)
|
|
stub._summary_template_sections = ContextCompressor._summary_template_sections
|
|
stub._build_summary_prompt = ContextCompressor._build_summary_prompt.__get__(stub)
|
|
prompt = stub._build_summary_prompt("NEW TURNS", 2000, None, "", True)
|
|
|
|
assert f'Update "{HISTORICAL_TASK_HEADING}"' in prompt
|
|
assert f'"{_LEGACY_ACTIVE_TASK_HEADING}"' not in prompt
|
|
|
|
|
|
def test_grounding_collapses_alias_and_duplicate_task_sections():
|
|
"""A summarizer that emits the legacy alias, or both headings, ends up with exactly one grounded section."""
|
|
body = (
|
|
f"{HISTORICAL_TASK_HEADING}\nUser asked: 'stale canonical'\n\n"
|
|
"## Goal\nthing\n\n"
|
|
f"{_LEGACY_ACTIVE_TASK_HEADING}\nUser asked: 'stale alias'\n\n"
|
|
"## Constraints & Preferences\n- none\n"
|
|
)
|
|
grounded = ContextCompressor._ground_historical_task_snapshot.__func__(
|
|
ContextCompressor, body, [{"role": "user", "content": "fresh ask"}]
|
|
)
|
|
|
|
headings = _headings(grounded)
|
|
assert headings.count(HISTORICAL_TASK_HEADING) == 1
|
|
assert _LEGACY_ACTIVE_TASK_HEADING not in headings
|
|
assert headings[1:] == ["## Goal", "## Constraints & Preferences"]
|
|
assert "fresh ask" in grounded
|
|
assert "stale" not in grounded
|