39e480c051
SessionDB could leave native SQLite handles open when construction failed partway through schema/pragma/FTS/repair/lock/interrupt handling. Other short-lived callers (MCP reads/polling, session search, reactions, trace upload, insights, shutdown recovery) opened temporary SessionDB handles without a complete ownership boundary. API-server profile caches and RetainDB shutdown had similar late-close races. Under sustained load this exhausted file descriptors (EMFILE). - Close partially initialized SessionDB connections on every constructor exception path via a finally block guarded by an initialization-complete flag. - Close temporary/cross-profile SessionDB handles in finally blocks across CLI, MCP, search, trace, reactions, insights, and recovery paths. - Add API-server per-profile cache ownership and disconnect cleanup. - Make RetainDB writer-queue shutdown exception-safe: track connections per thread, close on worker exit, reject new enqueues after shutdown starts, and sweep any connections left by short-lived threads. - Add regression coverage for constructor failures, worker-thread readers, API disconnect failures, shutdown recovery, RetainDB late enqueue, and foreign-loop async clients. Salvage notes: the original PR's per-thread WAL-reader ownership changes were superseded by main's read-connection pool (permits + checkout/return); its cron timeout-abandon fix is credited separately to #72822's earlier identical fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
56 lines
1.8 KiB
Python
56 lines
1.8 KiB
Python
from unittest.mock import MagicMock, patch
|
|
from types import SimpleNamespace
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.main import cmd_insights
|
|
|
|
|
|
class _InsightsEngineStub:
|
|
calls = []
|
|
|
|
def __init__(self, db):
|
|
self.db = db
|
|
|
|
def generate(self, *, days=30, source=None):
|
|
self.calls.append({"days": days, "source": source})
|
|
return {"days": days, "source": source}
|
|
|
|
def format_terminal(self, report):
|
|
return f"days={report['days']} source={report['source']}"
|
|
|
|
|
|
def _run_show_insights(command: str):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
db = MagicMock()
|
|
_InsightsEngineStub.calls = []
|
|
with patch("hermes_state.SessionDB", return_value=db), \
|
|
patch("agent.insights.InsightsEngine", _InsightsEngineStub):
|
|
cli_obj._show_insights(command)
|
|
return _InsightsEngineStub.calls, db
|
|
|
|
|
|
def test_cli_insights_accepts_positional_days(capsys):
|
|
calls, db = _run_show_insights("/insights 7")
|
|
|
|
assert calls == [{"days": 7, "source": None}]
|
|
db.close.assert_called_once()
|
|
assert "days=7 source=None" in capsys.readouterr().out
|
|
|
|
|
|
def test_cli_insights_keeps_days_flag_and_source(capsys):
|
|
calls, db = _run_show_insights("/insights --days 14 --source discord")
|
|
|
|
assert calls == [{"days": 14, "source": "discord"}]
|
|
db.close.assert_called_once()
|
|
assert "days=14 source=discord" in capsys.readouterr().out
|
|
|
|
|
|
def test_subcommand_insights_closes_database_when_generation_fails(capsys):
|
|
db = MagicMock()
|
|
with patch("hermes_state.SessionDB", return_value=db), \
|
|
patch("agent.insights.InsightsEngine", side_effect=RuntimeError("boom")):
|
|
cmd_insights(SimpleNamespace(days=30, source=None))
|
|
|
|
db.close.assert_called_once()
|
|
assert "Error generating insights: boom" in capsys.readouterr().out
|