Follow-up to the salvaged CommandCode signature fix: accepting base_url but ignoring it left custom endpoints (user-configured model.base_url / COMMANDCODE_BASE_URL proxies) fetching the public catalog instead of the configured one. Reviewer dansigma flagged this on PR #88851. Class-wide fix, not a CommandCode patch: - providers/base.py: a caller base_url that DIFFERS from the profile's default now wins over models_url. Equality with the default means "not customised" (callers pass base_url unconditionally, defaulting to the profile's own URL) and keeps models_url as the endpoint, preserving the OpenRouter-style split-catalog behavior. - commandcode: _fetch_commandcode_models() takes the endpoint override; both profile overrides forward base_url. - Tests: base-class precedence (custom beats models_url, default does not), CommandCode redirect via live local HTTP server incl. claude-* filter, and default-echo hitting the canonical endpoint. All verified to fail against the pre-fix implementation (sabotage run).
2 lines
9 B
Plaintext
2 lines
9 B
Plaintext
greyvito
|