6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
70 lines
2.9 KiB
Python
70 lines
2.9 KiB
Python
"""Test the platform-branched PTY bridge import in hermes_cli.web_server.
|
|
|
|
The /api/pty WebSocket handler in web_server.py picks its bridge at import
|
|
time via ``sys.platform.startswith("win")`` — Windows gets the ConPTY
|
|
backend, POSIX gets the fcntl/termios one. Both branches must:
|
|
|
|
1. Expose ``PtyBridge`` as the bridge class (or None) and
|
|
``PtyUnavailableError`` as an exception class.
|
|
2. Set ``_PTY_BRIDGE_AVAILABLE`` correctly.
|
|
3. Never raise at import time when the platform-native dependency is
|
|
missing — the dashboard's non-chat tabs must keep loading.
|
|
|
|
This test asserts the live state on whichever platform CI runs on, plus a
|
|
source-text check confirming the branch shape is preserved so a future
|
|
refactor can't accidentally collapse it back to a POSIX-only import.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import web_server
|
|
|
|
|
|
def test_web_server_exposes_pty_bridge_symbols():
|
|
"""The two symbols /api/pty consumes must always exist."""
|
|
assert hasattr(web_server, "PtyBridge")
|
|
assert hasattr(web_server, "PtyUnavailableError")
|
|
assert hasattr(web_server, "_PTY_BRIDGE_AVAILABLE")
|
|
# PtyUnavailableError is always an exception class — either the real
|
|
# one from the platform bridge, or the local fallback class.
|
|
assert isinstance(web_server.PtyUnavailableError, type)
|
|
assert issubclass(web_server.PtyUnavailableError, BaseException)
|
|
|
|
|
|
@pytest.mark.skipif(sys.platform.startswith("win"), reason="POSIX-only")
|
|
def test_web_server_uses_posix_pty_bridge_on_posix():
|
|
"""On POSIX, the bridge must be the fcntl/termios PtyBridge."""
|
|
from hermes_cli.pty_bridge import PtyBridge as PosixBridge
|
|
from hermes_cli.pty_bridge import PtyUnavailableError as PosixErr
|
|
|
|
assert web_server.PtyBridge is PosixBridge
|
|
assert web_server._PTY_BRIDGE_AVAILABLE is True
|
|
assert web_server.PtyUnavailableError is PosixErr
|
|
|
|
|
|
def test_pty_bridge_import_block_is_platform_branched():
|
|
"""Source-level guard: a future refactor must not collapse the branch
|
|
back to a single POSIX import. Reads web_server.py directly so this
|
|
fails the same way on every OS — the runtime symbol checks above can
|
|
pass even when the branch shape is wrong on the current platform."""
|
|
src = pytest.importorskip("inspect").getsource(web_server)
|
|
# The shape we expect (from PR #39913):
|
|
#
|
|
# if sys.platform.startswith("win"):
|
|
# try:
|
|
# from hermes_cli.win_pty_bridge import WinPtyBridge as PtyBridge, ...
|
|
# except ImportError:
|
|
# PtyBridge = None
|
|
# ...
|
|
# else:
|
|
# try:
|
|
# from hermes_cli.pty_bridge import PtyBridge, PtyUnavailableError
|
|
# ...
|
|
assert 'sys.platform.startswith("win")' in src or "sys.platform.startswith('win')" in src
|
|
assert "from hermes_cli.win_pty_bridge import" in src
|
|
assert "from hermes_cli.pty_bridge import" in src
|