39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
88 lines
2.7 KiB
Python
88 lines
2.7 KiB
Python
"""Per-platform typing-indicator toggle (PlatformConfig.typing_indicator).
|
|
|
|
The "typing…" / "is thinking…" status bubble is driven by the generic
|
|
``_keep_typing`` refresh loop that ``_process_message_background`` spawns for
|
|
every inbound message on every platform. ``typing_indicator`` (default True)
|
|
gates that spawn: when False, the loop is never started, so ``send_typing``
|
|
is never called and no status indicator is shown — while message delivery is
|
|
otherwise unchanged.
|
|
|
|
These are behavioral tests against the real dispatch path, not snapshots.
|
|
"""
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import (
|
|
BasePlatformAdapter,
|
|
MessageEvent,
|
|
MessageType,
|
|
)
|
|
from gateway.session import SessionSource, build_session_key
|
|
|
|
|
|
class _StubAdapter(BasePlatformAdapter):
|
|
async def connect(self, *, is_reconnect: bool = False):
|
|
pass
|
|
|
|
async def disconnect(self):
|
|
pass
|
|
|
|
async def send(self, chat_id, text, **kwargs):
|
|
return None
|
|
|
|
async def get_chat_info(self, chat_id):
|
|
return {}
|
|
|
|
|
|
def _make_adapter(typing_indicator: bool) -> _StubAdapter:
|
|
adapter = _StubAdapter(
|
|
PlatformConfig(enabled=True, token="t", typing_indicator=typing_indicator),
|
|
Platform.SLACK,
|
|
)
|
|
# Record send_typing calls without performing any platform I/O.
|
|
adapter.send_typing = AsyncMock(return_value=None)
|
|
adapter._send_with_retry = AsyncMock(return_value=None)
|
|
# Handler returns immediately; the typing loop only fires if it was spawned.
|
|
adapter._message_handler = AsyncMock(return_value="ok")
|
|
return adapter
|
|
|
|
|
|
def _make_event(chat_id="C123"):
|
|
return MessageEvent(
|
|
text="hi",
|
|
message_type=MessageType.TEXT,
|
|
source=SessionSource(platform=Platform.SLACK, chat_id=chat_id, chat_type="dm"),
|
|
)
|
|
|
|
|
|
def _sk(chat_id="C123"):
|
|
return build_session_key(
|
|
SessionSource(platform=Platform.SLACK, chat_id=chat_id, chat_type="dm")
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_indicator_enabled_spawns_refresh_loop():
|
|
"""Default (typing_indicator=True): the refresh loop calls send_typing."""
|
|
adapter = _make_adapter(typing_indicator=True)
|
|
|
|
# Real handlers take time (tool calls); yield long enough for the spawned
|
|
# refresh loop to fire at least one send_typing before delivery completes.
|
|
async def _slow_handler(_event):
|
|
await asyncio.sleep(0.05)
|
|
return "ok"
|
|
|
|
adapter._message_handler = _slow_handler
|
|
event = _make_event()
|
|
adapter._active_sessions[_sk()] = asyncio.Event()
|
|
|
|
await adapter._process_message_background(event, _sk())
|
|
|
|
assert adapter.send_typing.await_count >= 1
|
|
|
|
|