39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
50 lines
1.7 KiB
Python
50 lines
1.7 KiB
Python
"""Regression: background tasks respect profile secret scope when multiplexing.
|
|
|
|
Issue #60726: /background spawns _run_background_task as a fire-and-forget
|
|
asyncio task with no profile scope, so _resolve_session_agent_runtime()'s
|
|
credential reads raise UnscopedSecretError when multiplex_profiles is on.
|
|
The fix wraps the task body in _profile_runtime_scope, mirroring _run_agent.
|
|
"""
|
|
import asyncio
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
from gateway.config import GatewayConfig
|
|
from gateway.run import GatewayRunner
|
|
|
|
|
|
def _make_runner(multiplex: bool) -> GatewayRunner:
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner.config = GatewayConfig(multiplex_profiles=multiplex)
|
|
return runner
|
|
|
|
|
|
class TestBackgroundTaskProfileScope:
|
|
"""_run_background_task installs _profile_runtime_scope when multiplexing is active."""
|
|
|
|
def test_wraps_in_profile_scope_when_multiplex_active(self):
|
|
runner = _make_runner(multiplex=True)
|
|
inner = mock.AsyncMock(return_value=None)
|
|
runner._run_background_task_inner = inner
|
|
|
|
source = mock.MagicMock()
|
|
source.profile = "test_profile"
|
|
|
|
with mock.patch.object(
|
|
GatewayRunner,
|
|
"_resolve_profile_home_for_source",
|
|
return_value=Path("/fake/profile"),
|
|
), mock.patch("gateway.run._profile_runtime_scope") as scope:
|
|
scope.return_value.__enter__ = mock.MagicMock()
|
|
scope.return_value.__exit__ = mock.MagicMock(return_value=False)
|
|
asyncio.run(
|
|
runner._run_background_task(
|
|
prompt="test", source=source, task_id="bg_test"
|
|
)
|
|
)
|
|
|
|
scope.assert_called_once_with(Path("/fake/profile"))
|
|
inner.assert_awaited_once()
|
|
|
|
|