Guilherme Artiles 610e2e02fb fix(curator): tell the background reviewer to read before it writes ...

`_background_review_read_before_write_guard` refuses a background-review
`skill_manage` write when the target file was not loaded via `skill_view` in
the same review turn (patch, edit, write_file over an existing file,
remove_file).

`CURATOR_REVIEW_PROMPT` never says so. It lists `skill_view` only under "read
the current landscape", so the reviewer goes straight to the write and every
mutation is refused. The failure is silent from the outside: the curator run
completes, writes nothing, and reads like a pass that simply found nothing to
consolidate. On our deployment that was 32 of 32 attempted writes rejected over
48h before anyone read the logs.

This adds the missing instruction to the toolset block, plus a test that fails
if a future guarded action is added to `skill_manager_tool` without being named
in the prompt — the guard and the prompt have to drift together or not at all.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-25 00:31:14 -07:00

..

lsp

fix(lsp): abort diagnostics waits after transport death

2026-08-25 01:48:43 +05:30

monitoring

fix(otlp): span exporter now inherits configured resource_attributes

2026-08-08 18:11:02 -07:00

pet

fix(pets): remove the non-PNG base draft after hardening

2026-08-15 00:33:01 -07:00

proxy_sources

…

secret_sources

fix(update): avoid cryptography self-lock on Windows

2026-08-15 13:28:14 -07:00

transports

feat(model): Codex GPT slugs default back to 272K; explicit -900k picker variants opt into the verified large window

2026-08-23 02:14:35 -07:00

verify

Integrate verify subsystem with the existing verification stack

2026-08-07 10:11:05 -07:00

__init__.py

…

account_usage.py

…

agent_init.py

fix(codex): identify Hermes requests

2026-08-24 11:25:04 -07:00

agent_runtime_helpers.py

fix(fallback): surface provider transitions and primary recovery

2026-08-25 12:12:08 +05:30

anthropic_adapter.py

fix(anthropic): send an explicit thinking disable on the native Messages wire

2026-08-20 12:29:11 -05:00

async_utils.py

…

aux_accounting.py

…

auxiliary_client.py

feat: browser snapshots drop LLM summarization — truncate-and-store like web_extract; auxiliary.web_extract slot removed

2026-08-24 20:11:18 -07:00

azure_identity_adapter.py

…

backend_identity.py

…

background_review.py

fix(background-review): teach review prompts the enforced read-before-write handshake

2026-08-25 00:18:35 -07:00

battery.py

…

bedrock_adapter.py

refactor(bedrock): make resolve_bedrock_runtime_region the single region chokepoint

2026-08-21 15:02:29 -07:00

billing_links.py

…

billing_usage.py

…

billing_view.py

…

bounded_response.py

…

browser_provider.py

feat(browser): integrate Browser Use CLI 3.0

2026-08-10 10:45:44 -07:00

browser_registry.py

fix(plugins): isolate ownership by profile

2026-08-12 19:13:32 -07:00

chat_completion_helpers.py

fix(fallback): surface provider transitions and primary recovery

2026-08-25 12:12:08 +05:30

codex_responses_adapter.py

fix(native_compaction): preserve compression summary messages during pre-checkpoint pruning

2026-08-21 17:24:22 +05:30

codex_runtime.py

fix: route codex payloads around the SDK's GIL-holding request transform (#93650)

2026-08-24 15:29:45 +05:30

coding_context.py

fix: system prompt no longer references tools/skills the session can't use; hermes-agent skill is always kept

2026-08-24 20:25:10 -07:00

command_token_source.py

fix(auth): bound the no-TTL key_cmd token cache; docs for key_cmd

2026-08-15 03:16:21 -07:00

compaction_display.py

fix(clients): hide compaction carriers across surfaces

2026-08-21 21:53:11 +05:30

context_breakdown.py

…

context_compressor.py

Merge branch 'pr-81234' into salv/81234-retry-carrier

2026-08-24 03:15:07 -07:00

context_engine.py

Revert "fix: rewire DCP context engine to current main architecture"

2026-08-08 23:09:45 +05:30

context_references.py

feat(plugins): allow plugins to register custom @-prefix context references

2026-08-12 18:41:59 -07:00

conversation_compression.py

refactor: consolidate _db_persisted literal + marker-insensitive no-op check (#92231 follow-up)

2026-08-23 13:34:32 +05:30

conversation_loop.py

fix(agent): bypass response cache for empty retries

2026-08-23 23:31:54 -07:00

copilot_acp_client.py

fix(acp): make --acp probe tri-state, cached, and mock-safe

2026-08-16 06:31:46 -07:00

credential_persistence.py

…

credential_pool.py

fix(auth): rotate credentials for named custom providers after 401/429

2026-08-23 20:01:18 -07:00

credential_sources.py

fix(auth): read .env as utf-8-sig in the dotenv-vs-shell detector

2026-08-08 12:32:23 -07:00

credits_tracker.py

refactor(credits): fold review findings for stealth free-tier fix

2026-08-22 04:20:48 +05:30

curator_backup.py

fix(curator): abort rollback when safety snapshot fails

2026-08-16 22:06:41 -07:00

curator.py

fix(curator): tell the background reviewer to read before it writes

2026-08-25 00:31:14 -07:00

deadline.py

fix(mcp): recover poisoned connections + fail fast on dead stdio transports (#85125 3b)

2026-08-25 01:34:55 +05:30

delegation_context.py

fix(cron): don't let a cron job inherit a kanban worker's dispatcher identity

2026-08-06 03:16:26 +05:30

display.py

feat(delegation): live orchestration of running subagents via delegate_task action param

2026-08-13 09:34:36 -07:00

empty_response_guard.py

refactor(agent): move empty-response guard settings from env vars to config.yaml

2026-08-16 22:06:08 -07:00

error_classifier.py

fix(classifier): 429 quota walls route to billing across providers; reset signals stay rate-limited

2026-08-23 20:02:07 -07:00

error_surface.py

fix(desktop): error card honors the classifier's retry verdict + failing-session identity (review feedback)

2026-08-21 15:24:03 -07:00

errors.py

…

estop.py

fix: post-merge audit follow-ups for #81138/#81139/#81141/#81148

2026-08-08 05:21:09 -07:00

file_safety.py

fix(file-safety): approval-gate ~/.ssh/config writes instead of hard-denying (#84663)

2026-08-12 11:04:45 -07:00

gemini_native_adapter.py

test(gemini): cover nested/list/non-pointer ref cases; document false-positive tolerance

2026-08-23 18:27:04 -07:00

gemini_schema.py

…

i18n.py

…

image_gen_provider.py

feat(media): opt-in upscale pass for image_generate and video_generate across FAL and Krea

2026-08-08 14:49:28 -07:00

image_gen_registry.py

fix(tools): dispatch image/video FAL strictly on the stored hermes tools selection

2026-08-19 16:10:01 -07:00

image_routing.py

fix(vision): forward the API key to the server-type probe and cache failed verdicts

2026-08-23 17:47:50 -07:00

insights.py

refactor(usage): simplify-pass follow-ups

2026-08-14 02:04:24 +05:30

interrupt_compat.py

fix(agent): separate cancellation diagnostics from tool output

2026-08-23 18:25:19 -07:00

iteration_budget.py

…

jiter_preload.py

…

kanban_stop.py

…

learn_prompt.py

fix(learn): process large sources incrementally

2026-08-08 05:09:43 -07:00

learning_graph_render.py

…

learning_graph.py

…

learning_mutations.py

…

lmstudio_reasoning.py

…

manual_compression_feedback.py

fix(compression): /compress refusal no longer reports a successful rewrite

2026-08-19 22:41:05 -07:00

markdown_tables.py

…

memory_manager.py

fix(memory): log when a configured provider's tools are gated off by toolset config

2026-08-24 21:45:30 -07:00

memory_provider.py

fix: security + efficiency review fixes for salvaged PR #74379

2026-08-13 23:15:25 +05:30

message_content.py

…

message_metadata.py

fix: create message_metadata module and update chat_completion_helpers

2026-08-15 01:04:19 -07:00

message_sanitization.py

fix(agent): preserve tool results across ID variants

2026-08-23 18:24:43 -07:00

moa_loop.py

fix: restore stale-base revert hunks in conversation_loop.py and moa_loop.py

2026-08-13 23:10:16 +05:30

moa_trace.py

feat(langfuse): widen tracing to errors, sessions, subagents, and MoA fan-out

2026-08-13 23:10:16 +05:30

model_metadata.py

fix(model-metadata): local ctx probe must not read max_tokens as the context window

2026-08-24 03:20:57 -07:00

models_dev.py

refactor(models): simplify-pass follow-ups on the refresh path

2026-08-14 03:31:22 +05:30

moonshot_schema.py

…

native_compaction.py

fix(native_compaction): preserve compression summary messages during pre-checkpoint pruning

2026-08-21 17:24:22 +05:30

nous_rate_guard.py

…

onboarding.py

…

oneshot.py

…

outbound_webhooks.py

…

plugin_llm.py

fix(plugins): complete task-routed LLM integration

2026-08-12 16:25:20 -07:00

plugin_stream_hooks.py

feat(plugins): add streaming output observer hooks

2026-08-12 18:38:25 -07:00

portal_tags.py

…

process_bootstrap.py

docs: note httpcore pin dependency in _enable_happy_eyeballs

2026-08-24 21:46:05 -07:00

prompt_builder.py

fix: system prompt no longer references tools/skills the session can't use; hermes-agent skill is always kept

2026-08-24 20:25:10 -07:00

prompt_cache_boundary.py

refactor(cache): share the boundary-declaration helper and simplify the registry

2026-08-09 15:25:12 +05:30

prompt_cache_scope.py

refactor(cache): never-raising scope resolver shared by both call sites

2026-08-15 11:09:56 +05:30

prompt_caching.py

refactor(prompt_caching): shallow strip copy, exact-count guards, dedupe idempotency tests

2026-08-21 12:23:47 +05:30

rate_limit_tracker.py

…

reactions.py

…

reasoning_effort.py

fix(zai): GLM-5.3 low/medium reasoning effort reaches the wire instead of clamping to high

2026-08-21 14:58:37 -07:00

reasoning_summaries.py

fix(reasoning): keep gpt-5.x summary parts as separate blocks on the chat wire

2026-08-06 22:02:37 -05:00

reasoning_timeouts.py

feat: stealth/ox-alpha free model in the OpenRouter catalog

2026-08-20 23:12:38 -07:00

redact.py

fix: reuse redact_sensitive_text, fix leaky abstraction, fix test data

2026-08-13 23:10:16 +05:30

relay_llm.py

feat(relay): activate configured dynamic plugins

2026-08-19 08:52:01 -07:00

relay_runtime.py

fix(relay): complete native plugin cutover

2026-08-19 08:52:03 -07:00

relay_tools.py

fix(relay): bypass managed execution for nested calls inside managed callbacks

2026-08-08 23:46:17 -07:00

repetition_guard.py

fix(agent+discord): guard truncated-response continuation loops and cap Discord split delivery (#86581)

2026-08-16 01:55:51 -07:00

replay_cleanup.py

…

retry_utils.py

…

review_engine.py

feat: every subagent's prompt embeds the workspace's project context files

2026-08-23 19:04:37 -07:00

runtime_cwd.py

…

secret_scope.py

fix(gateway): classify relay routing stamps as process-global deployment config

2026-08-21 13:21:46 +10:00

session_activity.py

refactor(agent): pin session activity heartbeat cadence + harden best-effort write

2026-08-02 16:16:36 -07:00

shell_hooks.py

feat(hooks): pre_tool_call content transformation via modify directive

2026-08-15 23:03:52 -07:00

skill_bundles.py

…

skill_commands.py

fix(skills): publish and read the (map, platform) pair under one lock

2026-08-19 19:41:42 -07:00

skill_preprocessing.py

…

skill_utils.py

fix: system prompt no longer references tools/skills the session can't use; hermes-agent skill is always kept

2026-08-24 20:25:10 -07:00

ssl_guard.py

fix(ssl_guard): tolerate truststore SSLContext.get_ca_certs() NotImplementedError on Windows

2026-08-08 15:10:24 +05:30

ssl_verify.py

…

stream_diag.py

…

stream_single_writer.py

…

subagent_lifecycle.py

fix(agent): separate cancellation diagnostics from tool output

2026-08-23 18:25:19 -07:00

subdirectory_hints.py

Port from earendil-works/pi#7681: support AGENTS.override.md context override

2026-08-16 22:07:43 -07:00

subscription_view.py

…

system_prompt.py

fix(agent): gate memory provider system_prompt_block on toolset config (#81014)

2026-08-24 21:45:30 -07:00

terminal_env_provider.py

feat(terminal): pluggable terminal environment backends via plugin registry

2026-08-24 20:10:44 -07:00

terminal_env_registry.py

feat(terminal): pluggable terminal environment backends via plugin registry

2026-08-24 20:10:44 -07:00

think_scrubber.py

…

thinking_timeout_guidance.py

…

thread_scoped_output.py

fix(agent): stop thread output descriptor leaks

2026-08-15 00:33:01 -07:00

title_generator.py

Port from can1357/oh-my-pi#7306: reject answer-shaped auto-title output

2026-08-16 22:10:02 -07:00

tool_dispatch_helpers.py

fix(agent): preserve tool results across ID variants

2026-08-23 18:24:43 -07:00

tool_executor.py

feat: browser snapshots drop LLM summarization — truncate-and-store like web_extract; auxiliary.web_extract slot removed

2026-08-24 20:11:18 -07:00

tool_guardrails.py

feat: identical re-calls enter context as reference stubs, not duplicate payloads

2026-08-20 00:16:22 -07:00

tool_result_classification.py

…

trace_upload.py

fix(state): close leaked SessionDB connections on exception paths (#83226)

2026-08-14 21:41:26 -07:00

trajectory.py

…

transcription_provider.py

feat(plugins): add pre_transcription hook and STT prompt threading

2026-08-12 19:01:30 -07:00

transcription_registry.py

fix(plugins): isolate ownership by profile

2026-08-12 19:13:32 -07:00

tts_provider.py

…

tts_registry.py

fix(plugins): isolate ownership by profile

2026-08-12 19:13:32 -07:00

turn_context.py

Merge branch 'pr-81234' into salv/81234-retry-carrier

2026-08-24 03:15:07 -07:00

turn_finalizer.py

refactor: consolidate _db_persisted literal + marker-insensitive no-op check (#92231 follow-up)

2026-08-23 13:34:32 +05:30

turn_retry_state.py

feat(compression): native OpenAI Responses server-side compaction for gpt-5.6

2026-08-08 11:24:45 -07:00

turn_summary.py

…

usage_pricing.py

fix(pricing): support Gemini context-tiered rates in pricing snapshot (#93469)

2026-08-24 03:23:07 -07:00

verification_evidence.py

fix(agent): reject masked verification results

2026-08-16 00:14:58 -07:00

verification_stop.py

fix: make verify_on_stop opt-in everywhere (default False, not auto) (#84383)

2026-08-12 01:15:25 -07:00

verify_hooks.py

…

vertex_adapter.py

fix(picker): harden keyless provider gate logging and credentials path validation

2026-08-22 23:25:43 -07:00

video_gen_provider.py

feat(media): opt-in upscale pass for image_generate and video_generate across FAL and Krea

2026-08-08 14:49:28 -07:00

video_gen_registry.py

fix(tools): dispatch image/video FAL strictly on the stored hermes tools selection

2026-08-19 16:10:01 -07:00

web_search_provider.py

feat: web search/extract now work keyless on fresh installs via Parallel + Exa free tiers

2026-08-19 15:15:27 -07:00

web_search_registry.py

feat: keyless web tier becomes a 5-vendor round-robin ring (adds Tavily, Firecrawl, Keenable)

2026-08-20 00:17:25 -07:00