92686159d1
Prepare dependency generations before selecting them. Keep shipped tool bytes separate from writable additions, and store facts beside their entries. Validate proposed plugin sets before config publication. Restore the previous config if the facts write fails. Consolidate duplicate updater, backup, setup, and voice helpers. Repair launcher selection, dependency consumers, download ownership, update feeds, and native Windows process and file handling. Verification: 206 changed/prior-failing Python files reported 4630 passed, one failed, and 330 skipped. Fix the remaining Hindsight fixture boundary. The final targeted rerun reported 234 passed and two skipped. The store review regression batch reported 83 passed and one skipped. Desktop TypeScript checks, 56 selected Electron tests, 24 release tests, and the removed-import/compatibility guards passed. This is an integration checkpoint, not full audit acceptance. The complete Python suite has not run on this fixed tree. Crash-atomic plugin publication, generation cleanup, receipt correlation, and packaged lifecycle acceptance remain open in docs/pm-audit-status.md.
82 lines
2.8 KiB
Python
82 lines
2.8 KiB
Python
"""The runner's status glyphs must not crash narrow console encodings.
|
|
|
|
On native Windows, piped or legacy-console stdio defaults to cp1252, which
|
|
cannot encode the runner's ✓/✗ progress glyphs — before the fix, the first
|
|
per-file status line killed the whole run with UnicodeEncodeError. The
|
|
failure depends only on the stream's encoding, so these tests pin it on
|
|
every OS by building a cp1252 stream explicitly.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import io
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
_RUNNER_PATH = REPO_ROOT / "scripts" / "run_tests_parallel.py"
|
|
|
|
|
|
def _load_runner():
|
|
spec = importlib.util.spec_from_file_location("run_tests_parallel", _RUNNER_PATH)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(mod)
|
|
return mod
|
|
|
|
|
|
def test_silent_child_failure_reports_exit_code(tmp_path, monkeypatch):
|
|
from types import SimpleNamespace
|
|
mod = _load_runner()
|
|
child = SimpleNamespace(pid=123, returncode=23, communicate=lambda **kwargs: ("", None))
|
|
monkeypatch.setattr(mod.subprocess, "Popen", lambda *args, **kwargs: child)
|
|
monkeypatch.setattr(mod, "_kill_tree", lambda *args, **kwargs: None)
|
|
_, code, output, counts, _ = mod._run_one_file_once(tmp_path / "test.py", [], tmp_path, 30)
|
|
assert code == 23
|
|
assert "23" in output and "no output" in output.lower()
|
|
assert counts == {}
|
|
|
|
|
|
def _cp1252_stream() -> tuple[io.TextIOWrapper, io.BytesIO]:
|
|
raw = io.BytesIO()
|
|
return io.TextIOWrapper(raw, encoding="cp1252", errors="strict"), raw
|
|
|
|
|
|
def test_cp1252_stream_reproduces_the_crash_without_the_fix() -> None:
|
|
# Baseline for the bug: a strict cp1252 stream cannot take the glyph.
|
|
stream, _raw = _cp1252_stream()
|
|
try:
|
|
stream.write("✓")
|
|
except UnicodeEncodeError:
|
|
return
|
|
raise AssertionError("expected UnicodeEncodeError on strict cp1252")
|
|
|
|
|
|
def test_glyph_safe_stdio_survives_cp1252(monkeypatch) -> None:
|
|
mod = _load_runner()
|
|
stream, raw = _cp1252_stream()
|
|
monkeypatch.setattr(sys, "stdout", stream)
|
|
monkeypatch.setattr(sys, "stderr", stream)
|
|
|
|
mod._make_stdio_glyph_safe()
|
|
print("✓ tests/foo.py (3 tests, 1.2s) ✗")
|
|
sys.stdout.flush()
|
|
|
|
out = raw.getvalue()
|
|
assert "✓".encode("utf-8") in out, "stream should now carry UTF-8 glyphs"
|
|
assert b"tests/foo.py (3 tests, 1.2s)" in out, "line content must survive"
|
|
|
|
|
|
def test_glyph_safe_stdio_noop_without_reconfigure(monkeypatch) -> None:
|
|
# Streams without .reconfigure (e.g. pytest's capture buffers, plain
|
|
# StringIO) must pass through untouched instead of raising.
|
|
mod = _load_runner()
|
|
plain = io.StringIO()
|
|
monkeypatch.setattr(sys, "stdout", plain)
|
|
monkeypatch.setattr(sys, "stderr", plain)
|
|
|
|
mod._make_stdio_glyph_safe()
|
|
print("✓ still fine")
|
|
|
|
assert "✓ still fine" in plain.getvalue()
|