284dbaf537
Activation reaches plugin discovery before the application dependencies exist. Give PM its own locked Python project and runtime so it can install or repair the application without importing that dependency tree. Keep PM outside the application workspace. A shared uv workspace resolves the application graph and cannot provide this isolation. Route mutations through an isolated worker and preserve transaction callbacks, cancellation, custom package registrations, and correlated receipts. Use the same runtime builder for source installs and packaged payloads. Keep offline wheelhouse support in that builder. Nix builds the independent PM lock as a separate derivation. Refuse lazy-disabled bootstrap before installing tools or dependencies. Move first-party YAML readers and writers to ruamel. Keep the application lock's transitive PyYAML requirements for third-party packages. Verification: - Focused canonical Python suite: 177 passed, 1 host-gated skip. - Electron backend probes: 12 passed. Electron typecheck passed. - Both uv locks, scoped lint, Bash syntax, and whitespace checks passed. - Cold activation, corrupt-app repair, offline staging, and relocation ran. - Built and exercised the Nix PM runtime and standalone YAML merge script. Six broader caller test files retain the same 24 failing test IDs as an archive of HEAD. The existing real-home guard blocks those tests before they can exercise the affected paths. No full-suite pass is claimed. Native Windows signing and full Bionic package execution remain unverified.
125 lines
4.5 KiB
Python
125 lines
4.5 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
import hermes_cli.memory_setup as memory_setup
|
|
from hermes_cli.memory_setup import _CANCELLED, _curses_select
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_cmd_setup_generic_choice_cancel_writes_nothing(tmp_path, monkeypatch):
|
|
class ChoiceProvider:
|
|
def __init__(self):
|
|
self.save_config = MagicMock()
|
|
|
|
def get_config_schema(self):
|
|
return [{
|
|
"key": "mode",
|
|
"description": "Mode",
|
|
"default": "one",
|
|
"choices": ["one", "two"],
|
|
}]
|
|
|
|
provider = ChoiceProvider()
|
|
selections = iter([0, _CANCELLED])
|
|
save_config = MagicMock()
|
|
install_dependencies = MagicMock()
|
|
|
|
monkeypatch.setattr(memory_setup, "_get_available_providers", lambda: [("fake", "local", provider)])
|
|
monkeypatch.setattr(memory_setup, "_curses_select", lambda *args, **kwargs: next(selections))
|
|
monkeypatch.setattr(memory_setup, "_install_dependencies", install_dependencies)
|
|
monkeypatch.setattr(memory_setup, "get_hermes_home", lambda: tmp_path)
|
|
monkeypatch.setattr("hermes_cli.config.load_config", lambda: {"memory": {}})
|
|
monkeypatch.setattr("hermes_cli.config.save_config", save_config)
|
|
|
|
memory_setup.cmd_setup(SimpleNamespace())
|
|
|
|
install_dependencies.assert_called_once_with("fake")
|
|
save_config.assert_not_called()
|
|
provider.save_config.assert_not_called()
|
|
assert not (tmp_path / ".env").exists()
|
|
|
|
|
|
# _write_env_vars's CR/LF-stripping, denylist, and plain-value-roundtrip
|
|
# behavior is covered by tests/hermes_cli/test_memory_setup_env_denylist.py,
|
|
# which exercises the current save_env_value-routed signature
|
|
# (env_writes, hermes_home=None) \u2014 these three tests pinned the prior direct
|
|
# Path.write_text(env_path, env_writes) signature/implementation and were
|
|
# removed along with it (#60587).
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# provider extras — mode-aware expansion (#70636)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
def test_install_dependencies_force_resyncs_declared_extra(tmp_path, monkeypatch):
|
|
"""force=True re-syncs the provider's extra even when it imports fine,
|
|
so a downgraded/stripped bridge package is restored on hermes update."""
|
|
import hermes_yaml as _yaml
|
|
|
|
plugin_dir = tmp_path / "mem0"
|
|
plugin_dir.mkdir()
|
|
(plugin_dir / "plugin.yaml").write_text(
|
|
_yaml.safe_dump({"extra": "mem0"}), encoding="utf-8"
|
|
)
|
|
monkeypatch.setattr(
|
|
"plugins.memory.find_provider_dir", lambda name: plugin_dir
|
|
)
|
|
|
|
synced = []
|
|
|
|
import pm
|
|
|
|
monkeypatch.setattr(pm, "available", lambda extra: True)
|
|
monkeypatch.setattr(
|
|
pm, "sync_venv",
|
|
lambda extras=None, explicit=False: synced.append((list(extras or []), explicit)),
|
|
)
|
|
|
|
memory_setup._install_dependencies("mem0", force=True)
|
|
|
|
assert synced == [(["mem0"], True)]
|
|
|
|
|
|
def test_cmd_status_memory_tool_gate_disabled(capsys, monkeypatch):
|
|
"""When both memory stores are disabled, Memory status reports memory tool as disabled."""
|
|
_cfg = {"memory": {"memory_enabled": False, "user_profile_enabled": False}}
|
|
monkeypatch.setattr("hermes_cli.config.load_config", lambda: _cfg)
|
|
# check_memory_requirements() reads the readonly loader, not load_config.
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config_readonly", lambda: _cfg, raising=False
|
|
)
|
|
monkeypatch.setattr(memory_setup, "_get_available_providers", lambda: [])
|
|
|
|
memory_setup.cmd_status(SimpleNamespace())
|
|
|
|
captured = capsys.readouterr().out
|
|
assert "Memory tool: disabled ✗" in captured
|
|
assert "Memory injection: disabled ✗" in captured
|
|
assert "User profile: disabled ✗" in captured
|
|
|
|
|
|
def test_cmd_status_memory_tool_gate_enabled(capsys, monkeypatch):
|
|
"""When at least one memory store is enabled, Memory status reports memory tool as enabled."""
|
|
_cfg = {"memory": {"memory_enabled": True, "user_profile_enabled": False}}
|
|
monkeypatch.setattr("hermes_cli.config.load_config", lambda: _cfg)
|
|
monkeypatch.setattr(
|
|
"hermes_cli.config.load_config_readonly", lambda: _cfg, raising=False
|
|
)
|
|
monkeypatch.setattr(memory_setup, "_get_available_providers", lambda: [])
|
|
|
|
memory_setup.cmd_status(SimpleNamespace())
|
|
|
|
captured = capsys.readouterr().out
|
|
assert "Memory tool: enabled ✓" in captured
|
|
assert "Memory injection: enabled ✓" in captured
|
|
assert "User profile: disabled ✗" in captured
|