d67c9d2a28
_is_sensitive_path documents itself as the read-side guard for list/read/ download (#57505), but only fs_read_data_url and fs_download called it. fs_read_text returned .env / auth.json / mcp-tokens/* contents to an authenticated dashboard session and fs_list enumerated them. Move the check into _fs_regular_file, the resolver every fs reader goes through, and drop the two per-handler copies. fs_list filters on the same predicate alongside _FS_READDIR_HIDDEN. Reported-by: Brian Grablin <bgrablin@gmail.com>
119 lines
4.0 KiB
Python
119 lines
4.0 KiB
Python
import base64
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import web_server
|
|
|
|
pytest.importorskip("starlette.testclient")
|
|
from starlette.testclient import TestClient
|
|
|
|
|
|
@pytest.fixture
|
|
def client(monkeypatch):
|
|
previous_auth_required = getattr(web_server.app.state, "auth_required", None)
|
|
web_server.app.state.auth_required = False
|
|
test_client = TestClient(web_server.app)
|
|
test_client.headers[web_server._SESSION_HEADER_NAME] = web_server._SESSION_TOKEN
|
|
try:
|
|
yield test_client
|
|
finally:
|
|
if previous_auth_required is None:
|
|
try:
|
|
delattr(web_server.app.state, "auth_required")
|
|
except AttributeError:
|
|
pass
|
|
else:
|
|
web_server.app.state.auth_required = previous_auth_required
|
|
|
|
|
|
def test_fs_list_sorts_and_hides_noise(client, tmp_path):
|
|
root = tmp_path / "project"
|
|
root.mkdir()
|
|
(root / "b.txt").write_text("b")
|
|
(root / "a_dir").mkdir()
|
|
(root / "a.txt").write_text("a")
|
|
(root / "node_modules").mkdir()
|
|
(root / ".git").mkdir()
|
|
|
|
response = client.get("/api/fs/list", params={"path": str(root)})
|
|
|
|
assert response.status_code == 200
|
|
entries = response.json()["entries"]
|
|
assert [entry["name"] for entry in entries] == ["a_dir", "a.txt", "b.txt"]
|
|
assert entries[0] == {"name": "a_dir", "path": str(root / "a_dir"), "isDirectory": True}
|
|
assert all(entry["name"] not in {".git", "node_modules"} for entry in entries)
|
|
|
|
|
|
def test_fs_read_data_url_rejects_over_cap(client, tmp_path, monkeypatch):
|
|
monkeypatch.setattr(web_server, "_FS_DATA_URL_MAX_BYTES", 3)
|
|
target = tmp_path / "image.png"
|
|
target.write_bytes(b"1234")
|
|
|
|
response = client.get("/api/fs/read-data-url", params={"path": str(target)})
|
|
|
|
assert response.status_code == 413
|
|
|
|
|
|
def test_fs_download_streams_file_without_data_url_cap(client, tmp_path, monkeypatch):
|
|
monkeypatch.setattr(web_server, "_FS_DATA_URL_MAX_BYTES", 3)
|
|
target = tmp_path / "report with spaces.pdf"
|
|
target.write_bytes(b"123456")
|
|
|
|
response = client.get("/api/fs/download", params={"path": str(target)})
|
|
|
|
assert response.status_code == 200
|
|
assert response.content == b"123456"
|
|
assert response.headers["content-type"].startswith("application/pdf")
|
|
assert "report%20with%20spaces.pdf" in response.headers["content-disposition"]
|
|
|
|
|
|
def test_fs_download_rejects_sensitive_files(client, tmp_path):
|
|
target = tmp_path / ".env"
|
|
target.write_text("SECRET=1")
|
|
|
|
response = client.get("/api/fs/download", params={"path": str(target)})
|
|
|
|
assert response.status_code == 403
|
|
|
|
|
|
@pytest.mark.parametrize("endpoint", ["/api/fs/read-text", "/api/fs/read-data-url", "/api/fs/download"])
|
|
@pytest.mark.parametrize("relative", [".env", "auth.json", "mcp-tokens/github.json"])
|
|
def test_fs_readers_reject_sensitive_paths(client, tmp_path, endpoint, relative):
|
|
target = tmp_path / relative
|
|
target.parent.mkdir(parents=True, exist_ok=True)
|
|
target.write_text("SECRET=1")
|
|
|
|
response = client.get(endpoint, params={"path": str(target)})
|
|
|
|
assert response.status_code == 403
|
|
assert "SECRET" not in response.text
|
|
|
|
|
|
def test_fs_list_hides_sensitive_entries(client, tmp_path):
|
|
root = tmp_path / "project"
|
|
root.mkdir()
|
|
(root / ".env").write_text("SECRET=1")
|
|
(root / "auth.json").write_text("{}")
|
|
(root / "mcp-tokens").mkdir()
|
|
(root / "notes.txt").write_text("ok")
|
|
|
|
response = client.get("/api/fs/list", params={"path": str(root)})
|
|
|
|
assert response.status_code == 200
|
|
assert [entry["name"] for entry in response.json()["entries"]] == ["notes.txt"]
|
|
|
|
|
|
def test_fs_endpoints_require_auth(tmp_path):
|
|
client = TestClient(web_server.app)
|
|
target = tmp_path / "secret.txt"
|
|
target.write_text("secret")
|
|
|
|
list_response = client.get("/api/fs/list", params={"path": str(tmp_path)})
|
|
read_response = client.get("/api/fs/read-text", params={"path": str(target)})
|
|
default_response = client.get("/api/fs/default-cwd")
|
|
|
|
assert list_response.status_code == 401
|
|
assert read_response.status_code == 401
|
|
assert default_response.status_code == 401
|