d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
97 lines
3.4 KiB
Python
97 lines
3.4 KiB
Python
"""Regression guard: opencode-free client keyless header handling.
|
|
|
|
OpenCode's free tier at ``https://opencode.ai/zen/v1`` is served ANONYMOUSLY:
|
|
requests with no recognizable Authorization bearer succeed, while any bearer
|
|
the relay doesn't recognize — placeholders included — is rejected with 401
|
|
"Invalid API key" (verified live 2026-08-21).
|
|
|
|
The client therefore must ship an EMPTY ``Authorization`` default header for
|
|
every opencode-free build, which overrides the OpenAI SDK's always-injected
|
|
``Authorization: Bearer <api_key>`` so no credential-shaped value ever
|
|
reaches the wire.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from agent.agent_runtime_helpers import create_openai_client
|
|
|
|
ZEN_V1 = "https://opencode.ai/zen/v1"
|
|
|
|
|
|
class _FakeAgent:
|
|
def __init__(self, api_key):
|
|
self.provider = "opencode-free"
|
|
self.base_url = ZEN_V1
|
|
self.api_key = api_key
|
|
self.model = "x-preview-f-free"
|
|
self.api_mode = "chat_completions"
|
|
|
|
def _client_log_context(self):
|
|
return {}
|
|
|
|
def _build_keepalive_http_client(self, base_url, verify=True):
|
|
return None
|
|
|
|
|
|
def _zen_call_headers(mock_openai):
|
|
matching = [
|
|
c for c in mock_openai.call_args_list
|
|
if c.kwargs.get("base_url") == ZEN_V1
|
|
]
|
|
assert matching, "OpenAI was never constructed with the zen base_url"
|
|
return dict(matching[-1].kwargs.get("default_headers") or {})
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_opencode_free_blanks_authorization_header(mock_openai):
|
|
"""Whatever api_key value reaches the client build (placeholder, stale
|
|
key, empty), the Authorization default header must be blanked so the
|
|
SDK's Bearer never hits the wire."""
|
|
mock_openai.return_value = MagicMock()
|
|
for key in ("opencode-zen-free-keyless", "no-key-required", "", "sk-stale"):
|
|
mock_openai.reset_mock()
|
|
create_openai_client(
|
|
_FakeAgent(api_key=key),
|
|
{"api_key": key, "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert headers.get("Authorization") == "", (
|
|
f"opencode-free with api_key={key!r} must blank Authorization; "
|
|
f"got {headers!r}"
|
|
)
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_opencode_free_sends_hermes_attribution(mock_openai):
|
|
"""Keyless requests still identify as Hermes (attribution headers match
|
|
the opencode zen/go profiles)."""
|
|
mock_openai.return_value = MagicMock()
|
|
create_openai_client(
|
|
_FakeAgent(api_key="opencode-zen-free-keyless"),
|
|
{"api_key": "opencode-zen-free-keyless", "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert headers.get("X-Title") == "Hermes Agent"
|
|
assert str(headers.get("User-Agent", "")).startswith("HermesAgent/")
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_other_providers_unaffected(mock_openai):
|
|
"""The opencode-free header policy must not leak to other providers."""
|
|
mock_openai.return_value = MagicMock()
|
|
agent = _FakeAgent(api_key="sk-real")
|
|
agent.provider = "opencode-zen"
|
|
create_openai_client(
|
|
agent,
|
|
{"api_key": "sk-real", "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert "Authorization" not in headers, (
|
|
"opencode-zen (keyed) must not have its Authorization header blanked"
|
|
)
|