6504b665ba
Completing a card with no result/summary (or whitespace-only) left done rows with no handover. Gate before the write txn, audit completion_blocked_empty_result, raise EmptyCompletionError. Review approvals stay exempt.
78 lines
2.8 KiB
Python
78 lines
2.8 KiB
Python
"""``complete_task`` refuses empty / whitespace-only evidence (#117483)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban_db as kb
|
|
from hermes_cli import kanban_db_connect as kbc
|
|
|
|
|
|
@pytest.fixture
|
|
def conn(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
db_path = kb.kanban_db_path(board="default")
|
|
kb._INITIALIZED_PATHS.discard(str(db_path.resolve()))
|
|
kb.init_db()
|
|
with kbc.connect() as c:
|
|
yield c
|
|
|
|
|
|
def _ready_task(conn) -> str:
|
|
tid = kb.create_task(conn, title="demo", assignee="coder")
|
|
assert kb.claim_task(conn, tid, claimer=kb._claimer_id()) is not None
|
|
return tid
|
|
|
|
|
|
def test_complete_without_evidence_raises(conn):
|
|
tid = _ready_task(conn)
|
|
with pytest.raises(kb.EmptyCompletionError):
|
|
kb.complete_task(conn, tid)
|
|
row = conn.execute("SELECT status, result FROM tasks WHERE id = ?", (tid,)).fetchone()
|
|
assert row["status"] == "running"
|
|
assert not row["result"]
|
|
kinds = [r["kind"] for r in conn.execute(
|
|
"SELECT kind FROM task_events WHERE task_id = ? ORDER BY id", (tid,)
|
|
).fetchall()]
|
|
assert "completion_blocked_empty_result" in kinds
|
|
assert "completed" not in kinds
|
|
|
|
|
|
def test_whitespace_result_raises(conn):
|
|
tid = _ready_task(conn)
|
|
with pytest.raises(kb.EmptyCompletionError):
|
|
kb.complete_task(conn, tid, result=" ")
|
|
assert conn.execute("SELECT status FROM tasks WHERE id = ?", (tid,)).fetchone()["status"] == "running"
|
|
|
|
|
|
def test_whitespace_stored_result_does_not_count(conn):
|
|
tid = _ready_task(conn)
|
|
conn.execute("UPDATE tasks SET result = ? WHERE id = ?", (" ", tid))
|
|
conn.commit()
|
|
with pytest.raises(kb.EmptyCompletionError):
|
|
kb.complete_task(conn, tid)
|
|
assert kb.complete_task(conn, tid, result="shipped the gate") is True
|
|
assert conn.execute("SELECT status FROM tasks WHERE id = ?", (tid,)).fetchone()["status"] == "done"
|
|
|
|
|
|
def test_review_approval_exempt(conn):
|
|
tid = kb.create_task(conn, title="review-me", assignee="coder")
|
|
assert kb.claim_task(conn, tid, claimer=kb._claimer_id()) is not None
|
|
assert kb.request_review(conn, tid, summary="please look") is True
|
|
assert kb.get_task(conn, tid).status == "review"
|
|
assert kb.complete_task(conn, tid) is True
|
|
assert kb.get_task(conn, tid).status == "done"
|
|
|
|
|
|
def test_reject_then_succeed(conn):
|
|
tid = _ready_task(conn)
|
|
with pytest.raises(kb.EmptyCompletionError):
|
|
kb.complete_task(conn, tid, summary=" ")
|
|
assert kb.complete_task(conn, tid, summary="fixed empty complete") is True
|
|
assert conn.execute("SELECT status FROM tasks WHERE id = ?", (tid,)).fetchone()["status"] == "done"
|