9931e3c349
Drop three pieces that change behaviour beyond plugin skills: - _session_home_scope binding the full runtime scope (secret hydration, which can run external secret CLIs, and terminal policy) on every catalog, completion and dispatch RPC: a cross-cutting change for all callers. - slash.exec moving plugin commands ahead of the skill/bundle gate: a separate precedence question that predates plugin skills. - commands.catalog filing every skill under a new Skills category. Plugin skills still list, complete and dispatch under the existing home scope.
86 lines
2.8 KiB
Python
86 lines
2.8 KiB
Python
"""Tests for the ``/reload-skills`` CLI slash command (``HermesCLI._reload_skills``).
|
|
|
|
The CLI handler prints the diff (name + description) for the user and —
|
|
when any skills were added or removed — queues a one-shot note on
|
|
``self._pending_skills_reload_note``. The note is prepended to the NEXT
|
|
user message (see cli.py ~L8770, same pattern as
|
|
``_pending_model_switch_note``) and cleared after use, so no phantom user
|
|
turn is persisted to ``conversation_history``.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _make_cli():
|
|
"""Build a minimal HermesCLI shell exposing ``_reload_skills``."""
|
|
import cli as cli_mod
|
|
|
|
obj = object.__new__(cli_mod.HermesCLI)
|
|
obj._command_running = False
|
|
obj.conversation_history = []
|
|
obj.agent = None
|
|
return obj
|
|
|
|
|
|
class TestReloadSkillsCLI:
|
|
def test_reports_added_and_removed_and_queues_note(self, capsys):
|
|
cli = _make_cli()
|
|
with patch(
|
|
"agent.skill_commands.reload_skills",
|
|
return_value={
|
|
"added": [
|
|
{"name": "alpha", "description": "Run alpha to do xyz"},
|
|
{"name": "beta", "description": "Run beta to do abc"},
|
|
],
|
|
"removed": [
|
|
{"name": "gamma", "description": "Old removed skill"},
|
|
],
|
|
"unchanged": ["delta"],
|
|
"total": 3,
|
|
"commands": 3,
|
|
},
|
|
):
|
|
cli._reload_skills()
|
|
|
|
out = capsys.readouterr().out
|
|
for name in ("alpha", "beta", "gamma"):
|
|
assert name in out
|
|
|
|
# Must NOT pollute conversation_history — alternation-safe.
|
|
assert cli.conversation_history == []
|
|
|
|
# One-shot note queued with system-prompt-style formatting.
|
|
note = getattr(cli, "_pending_skills_reload_note", None)
|
|
assert note is not None
|
|
for name in ("alpha", "beta", "gamma"):
|
|
assert name in note
|
|
|
|
def test_reports_no_changes_and_queues_nothing(self, capsys):
|
|
cli = _make_cli()
|
|
with patch(
|
|
"agent.skill_commands.reload_skills",
|
|
return_value={
|
|
"added": [],
|
|
"removed": [],
|
|
"unchanged": ["alpha"],
|
|
"total": 1,
|
|
"commands": 1,
|
|
},
|
|
):
|
|
cli._reload_skills()
|
|
|
|
assert cli.conversation_history == []
|
|
assert getattr(cli, "_pending_skills_reload_note", None) is None
|
|
|
|
def test_handles_reload_failure_gracefully(self, capsys):
|
|
cli = _make_cli()
|
|
with patch(
|
|
"agent.skill_commands.reload_skills",
|
|
side_effect=RuntimeError("boom"),
|
|
):
|
|
cli._reload_skills()
|
|
|
|
assert "boom" in capsys.readouterr().out
|
|
assert cli.conversation_history == []
|
|
assert getattr(cli, "_pending_skills_reload_note", None) is None
|