059efe8b29
Path-based review (workflows, composite actions, eslint/prettier config, the MCP catalog, install-hook files) moves to .github/CODEOWNERS. GitHub requests and enforces that review, so CI no longer classifies those paths, checks a label, or reruns failed jobs when the label is added. Removes review-labels.yml, emit_review_status.py, the rerun-review-labels job, and the ci_review / ci_review_files / mcp_catalog classifier outputs. The run-e2e rerun job in label-rerun.yml stays. The supply-chain scan keeps its content patterns (base64 decode + exec, obfuscated subprocess), which CODEOWNERS cannot express. It fails on its own again, as it did before #68833 routed it through the label gate. Its .pth and install-hook path checks are dropped in favour of CODEOWNERS.
76 lines
3.1 KiB
Python
76 lines
3.1 KiB
Python
"""Behavior tests for the strict CI aggregate gate (scripts/ci/required_results.py)."""
|
|
|
|
import importlib.util
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
SCRIPT = Path(__file__).resolve().parents[2] / "scripts" / "ci" / "required_results.py"
|
|
|
|
_spec = importlib.util.spec_from_file_location("required_results", SCRIPT)
|
|
required_results = importlib.util.module_from_spec(_spec)
|
|
_spec.loader.exec_module(required_results)
|
|
|
|
evaluate_gate = required_results.evaluate_gate
|
|
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize("release", [False, True])
|
|
@pytest.mark.parametrize("job", ["tests", "osv-scanner", "history-check", "e2e-desktop"])
|
|
@pytest.mark.parametrize("result,ordinary,excluded", [
|
|
("success", True, True), ("skipped", False, True), ("failure", False, False),
|
|
("cancelled", False, False), ("with-status", False, False),
|
|
("action_required", False, False), ("unknown", False, False), (None, False, False),
|
|
])
|
|
def test_status_policy(job, result, ordinary, excluded, release):
|
|
expected = excluded if job in ("history-check", "e2e-desktop") else ordinary
|
|
if result == "skipped" and not release:
|
|
expected = True
|
|
verdict = evaluate_gate({job: {} if result is None else {"result": result}}, release=release)
|
|
assert verdict == {"ok": expected, "failed": [] if expected else [job],
|
|
"allowed_skips": [job] if expected and result == "skipped" else []}
|
|
|
|
|
|
def test_release_exclusion_policy():
|
|
assert required_results.EXCLUDED_JOBS == {
|
|
"history-check", "lockfile-diff", "supply-chain", "e2e-desktop",
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("needs", [{}, None])
|
|
@pytest.mark.parametrize("release", [False, True])
|
|
def test_empty_needs_fails_closed(needs, release):
|
|
assert evaluate_gate(needs, release=release) == {
|
|
"ok": False, "failed": ["<no-needs>"], "allowed_skips": [],
|
|
}
|
|
assert required_results.compact_results(needs) == {}
|
|
|
|
|
|
@pytest.mark.parametrize("release,results,code,report", [
|
|
(True, {"detect": "success", "e2e-desktop": "skipped"}, 0, "All checks passed"),
|
|
(True, {"tests": "skipped", "history-check": "skipped", "lint": "failure"},
|
|
1, "::error::2 job(s) failed: lint, tests"),
|
|
(False, {"tests": "failure"}, 1, "::error::1 job(s) failed: tests"),
|
|
])
|
|
def test_cli_stdin_exit_codes_and_output(tmp_path, release, results, code, report):
|
|
output = tmp_path / "github-output.txt"
|
|
needs = {name: {"result": result, "outputs": {"detail": "kept"}}
|
|
for name, result in results.items()}
|
|
child = subprocess.run(
|
|
[sys.executable, str(SCRIPT), *(["--release"] if release else [])],
|
|
input=json.dumps(needs), capture_output=True, text=True, timeout=30,
|
|
env={**os.environ, "GITHUB_OUTPUT": str(output)},
|
|
)
|
|
assert child.returncode == code, child.stderr
|
|
assert report in child.stdout
|
|
key, value = output.read_text(encoding="utf-8").strip().split("=", 1)
|
|
assert key == "needs-json"
|
|
assert json.loads(value) == results
|
|
assert f"{key}={value}" in child.stdout
|
|
for name, result in results.items():
|
|
assert f"{name}: {result}" in child.stdout
|